- Use correct format for Versions.props package name
- Pass ExcludeFromDotNetBuild=false to build UBValidation Tests
- Remove DirectoryBuildProps
- Remove gitignore
We know the minimum and 'bundled' MSbuild versions, but users may build a project with newer SDKs than we expected (specifically when full-framework MSBuild is starting the build of an SDK-style project).
When this occurs, we'd like to automatically condition the use of PackageReferences meant to ensure compatibility of the Roslyn toolchain, so we need to know if we are in this mismatched situation.
A fast and simple way to do this is to 'stamp' the 'expected' version
of MSBuild during product construction and compare that to the
'current' version being used during the actual build.
We know the minimum and 'bundled' MSbuild versions, but users may build a project with newer SDKs than we expected (specifically when full-framework MSBuild is starting the build of an SDK-style project).
When this occurs, we'd like to automatically condition the use of PackageReferences meant to ensure compatibility of the Roslyn toolchain, so we need to know if we are in this mismatched situation.
A fast and simple way to do this is to 'stamp' the 'expected' version
of MSBuild during product construction and compare that to the
'current' version being used during the actual build.
- Move Directory.Build.props to build UB tests with arcade
- Use msbuild task to run tests rather than exec
- Update old condition for building UB tests
This reverts commit f0c4e4e14c.
Fixes [AB#1994786](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1994786/)
The MSBuild change which took advantage of this was reverted in 17.9 because it introduced issues in installations that don't have the .NET SDK component installed. We are fixing the bug in 9.0 by making changes to the dependencies of `Microsoft.DotNet.MSBuildSdkResolver` (see https://github.com/dotnet/sdk/pull/39573) so this should stay in main. I am reverting it only in 8.0.3xx / 17.10 to fix the `Build_Ngen_InvalidAssemblyCount` counter which was flagged as a regression by PerfDDRITs.
- Extract common archive diffing into a base class
- Move Diff utils to a separate class
- Return all valid archives and assert only one valid SDK archive
- Use Arcade VersionIdentifier util class
[main] Update dependencies from dotnet/sdk
- Coherency Updates:
- Microsoft.WindowsDesktop.App.Ref: from 9.0.0-preview.2.24120.1 to 9.0.0-preview.2.24122.1 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0: from 9.0.0-preview.2.24120.1 to 9.0.0-preview.2.24122.1 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0: from 9.0.0-preview.2.24120.1 to 9.0.0-preview.2.24122.1 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.NetCore.SharedFramework.x64.9.0: from 9.0.0-preview.2.24120.11 to 9.0.0-preview.2.24122.4 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.App.Ref: from 9.0.0-preview.2.24120.11 to 9.0.0-preview.2.24122.4 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.NetCore.TargetingPack.x64.9.0: from 9.0.0-preview.2.24120.11 to 9.0.0-preview.2.24122.4 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.App.Host.win-x64: from 9.0.0-preview.2.24120.11 to 9.0.0-preview.2.24122.4 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.Platforms: from 9.0.0-preview.2.24120.11 to 9.0.0-preview.2.24122.4 (parent: Microsoft.NET.Sdk)
- Microsoft.SourceBuild.Intermediate.runtime.linux-x64: from 9.0.0-preview.2.24120.11 to 9.0.0-preview.2.24122.4 (parent: Microsoft.NET.Sdk)
- Microsoft.WindowsDesktop.App.Runtime.win-x64: from 9.0.0-preview.2.24120.1 to 9.0.0-preview.2.24122.1 (parent: Microsoft.NET.Sdk)
- Microsoft.Dotnet.WinForms.ProjectTemplates: from 9.0.0-preview.2.24118.1 to 9.0.0-preview.2.24122.2 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
- Microsoft.WindowsDesktop.App.Runtime.win-x64: from 9.0.0-preview.2.24120.1 to 9.0.0-preview.2.24122.1 (parent: Microsoft.NET.Sdk)
- Microsoft.DotNet.Wpf.ProjectTemplates: from 9.0.0-preview.2.24119.1 to 9.0.0-preview.2.24122.1 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
- Microsoft.FSharp.Compiler: from 12.8.300-beta.24120.1 to 12.8.300-beta.24122.3 (parent: Microsoft.NET.Sdk)
- Microsoft.SourceBuild.Intermediate.fsharp: from 8.0.300-beta.24120.1 to 8.0.300-beta.24122.3 (parent: Microsoft.NET.Sdk)
- Microsoft.NET.Test.Sdk: from 17.10.0-preview-24119-01 to 17.10.0-preview-24120-01 (parent: Microsoft.NET.Sdk)
- Microsoft.SourceBuild.Intermediate.vstest: from 17.10.0-preview-24119-01 to 17.10.0-preview-24120-01 (parent: Microsoft.NET.Sdk)
- Microsoft.NET.ILLink.Tasks: from 9.0.0-preview.2.24120.11 to 9.0.0-preview.2.24122.4 (parent: Microsoft.NET.Sdk)
- Microsoft.Net.Compilers.Toolset: from 4.10.0-2.24120.7 to 4.10.0-2.24122.3 (parent: Microsoft.NET.Sdk)
- Microsoft.SourceBuild.Intermediate.roslyn: from 4.10.0-2.24120.7 to 4.10.0-2.24122.3 (parent: Microsoft.NET.Sdk)
- Microsoft.Build: from 17.10.0-preview-24120-06 to 17.10.0-preview-24122-01 (parent: Microsoft.NET.Sdk)
- Microsoft.SourceBuild.Intermediate.msbuild: from 17.10.0-preview-24120-06 to 17.10.0-preview-24122-01 (parent: Microsoft.NET.Sdk)
- NuGet.Build.Tasks: from 6.10.0-preview.2.32 to 6.10.0-preview.2.41 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.App.Runtime.win-x64: from 9.0.0-preview.2.24120.11 to 9.0.0-preview.2.24122.4 (parent: Microsoft.NET.Sdk)
- Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport: from 9.0.0-preview.2.24114.5 to 9.0.0-preview.2.24121.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Microsoft.NETCore.App.Runtime.win-x64: from 9.0.0-preview.2.24120.11 to 9.0.0-preview.2.24122.4 (parent: Microsoft.NET.Sdk)
- Microsoft.SourceBuild.Intermediate.emsdk: from 9.0.0-preview.2.24114.5 to 9.0.0-preview.2.24121.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Rebase fsharp patch
- Roslyn patch to fix NetRoslyn value
As a prerequisite to enabling parallel builds of the repos in the VMR, it's necessary to isolate the package flow between repos. This ensures that repo dependencies are defined correctly. Prior to these changes, the packages outputted by repos went to the same directory (Shipping or NonShipping) and those two directories were used as the package feed inputs to dependent repos. This would be dangerous in the context of running builds in parallel across repos because any ill-defined dependencies could lead to race conditions. For example, consider the msbuild repo's dependency on System.Text.Json from the runtime repo. If runtime was not defined as a dependency of msbuild, then there's no guarantee that System.Text.Json will exist when it restores it. Based on timing, it may exist in one build and then not exist in another build.
To solve this problem, the packages output from a repos build are placed in a repo-specific package location as a sub-directory of the package location (Shipping or NonShipping). Previously, all repos would output their packages to `artifacts/packages/Release/[NonShipping|Shipping]`. With these changes, they output to `artifacts/packages/Release/[NonShipping|Shipping]/<repo-name>`. This isolates all packages on a per-repo basis. The next step is to provide access to these packages based on dependencies. Going back to msbuild's dependency on runtime, this is accomplished by modifying msbuild's nuget.config file to include feeds specific to runtime:
```xml
<add key="source-built-runtime" value="/vmr/artifacts/packages/Release/Shipping/runtime/" />
<add key="source-built-transport-runtime" value="/vmr/artifacts/packages/Release/NonShipping/runtime/" />
```
[main] Update dependencies from dotnet/sdk
- Coherency Updates:
- Microsoft.WindowsDesktop.App.Ref: from 9.0.0-preview.2.24112.5 to 9.0.0-preview.2.24113.4 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0: from 9.0.0-preview.2.24112.5 to 9.0.0-preview.2.24113.4 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0: from 9.0.0-preview.2.24112.5 to 9.0.0-preview.2.24113.4 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.NetCore.SharedFramework.x64.9.0: from 9.0.0-preview.2.24112.33 to 9.0.0-preview.2.24113.5 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.App.Ref: from 9.0.0-preview.2.24112.33 to 9.0.0-preview.2.24113.5 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.NetCore.TargetingPack.x64.9.0: from 9.0.0-preview.2.24112.33 to 9.0.0-preview.2.24113.5 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.App.Host.win-x64: from 9.0.0-preview.2.24112.33 to 9.0.0-preview.2.24113.5 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.Platforms: from 9.0.0-preview.2.24112.33 to 9.0.0-preview.2.24113.5 (parent: Microsoft.NET.Sdk)
- Microsoft.SourceBuild.Intermediate.runtime.linux-x64: from 9.0.0-preview.2.24112.33 to 9.0.0-preview.2.24113.5 (parent: Microsoft.NET.Sdk)
- Microsoft.AspNetCore.App.Ref: from 9.0.0-preview.2.24112.25 to 9.0.0-preview.2.24113.4 (parent: Microsoft.NET.Sdk)
- Microsoft.AspNetCore.App.Ref.Internal: from 9.0.0-preview.2.24112.25 to 9.0.0-preview.2.24113.4 (parent: Microsoft.NET.Sdk)
- Microsoft.AspNetCore.App.Runtime.win-x64: from 9.0.0-preview.2.24112.25 to 9.0.0-preview.2.24113.4 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0: from 9.0.0-preview.2.24112.25 to 9.0.0-preview.2.24113.4 (parent: Microsoft.NET.Sdk)
- dotnet-dev-certs: from 9.0.0-preview.2.24112.25 to 9.0.0-preview.2.24113.4 (parent: Microsoft.NET.Sdk)
- dotnet-user-jwts: from 9.0.0-preview.2.24112.25 to 9.0.0-preview.2.24113.4 (parent: Microsoft.NET.Sdk)
- dotnet-user-secrets: from 9.0.0-preview.2.24112.25 to 9.0.0-preview.2.24113.4 (parent: Microsoft.NET.Sdk)
- Microsoft.SourceBuild.Intermediate.aspnetcore: from 9.0.0-preview.2.24112.25 to 9.0.0-preview.2.24113.4 (parent: Microsoft.NET.Sdk)
- Microsoft.WindowsDesktop.App.Runtime.win-x64: from 9.0.0-preview.2.24112.5 to 9.0.0-preview.2.24113.4 (parent: Microsoft.NET.Sdk)
- Microsoft.Dotnet.WinForms.ProjectTemplates: from 9.0.0-preview.2.24112.2 to 9.0.0-preview.2.24112.7 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
- Microsoft.WindowsDesktop.App.Runtime.win-x64: from 9.0.0-preview.2.24112.5 to 9.0.0-preview.2.24113.4 (parent: Microsoft.NET.Sdk)
- Microsoft.DotNet.Wpf.ProjectTemplates: from 9.0.0-preview.2.24112.2 to 9.0.0-preview.2.24112.4 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
- Microsoft.FSharp.Compiler: from 12.8.300-beta.24112.4 to 12.8.300-beta.24113.3 (parent: Microsoft.NET.Sdk)
- Microsoft.SourceBuild.Intermediate.fsharp: from 8.0.300-beta.24112.4 to 8.0.300-beta.24113.3 (parent: Microsoft.NET.Sdk)
- Microsoft.NET.Test.Sdk: from 17.10.0-preview-24107-02 to 17.10.0-preview-24112-02 (parent: Microsoft.NET.Sdk)
- Microsoft.SourceBuild.Intermediate.vstest: from 17.10.0-preview-24107-02 to 17.10.0-preview-24112-02 (parent: Microsoft.NET.Sdk)
- Microsoft.NET.ILLink.Tasks: from 9.0.0-preview.2.24112.33 to 9.0.0-preview.2.24113.5 (parent: Microsoft.NET.Sdk)
- Microsoft.Net.Compilers.Toolset: from 4.10.0-2.24112.4 to 4.10.0-2.24113.3 (parent: Microsoft.NET.Sdk)
- Microsoft.SourceBuild.Intermediate.roslyn: from 4.10.0-2.24112.4 to 4.10.0-2.24113.3 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.App.Runtime.win-x64: from 9.0.0-preview.2.24112.33 to 9.0.0-preview.2.24113.5 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.App.Runtime.win-x64: from 9.0.0-preview.2.24112.33 to 9.0.0-preview.2.24113.5 (parent: Microsoft.NET.Sdk)
- Delete obsolete format patch
- Update WASI container to react to 1a9e0cdb3b
- Update aspnetcore.proj
