This is a scenario that is no longer valid, using the Microsoft.DotNet.Cli.Utils library in a project tool to invoke another project tool.
It was breaking because the dependency-tool-invoker was using a different version of MSBuild than the CLI, which caused problems
when the ToolsVersion changed from 15.0 to Current.
This commit implements the requested changes from the PR code review.
- Remove unnecessary comments
- Use Directory.Exists rather than getting file attributes
- Use GracefulException where appripriate
- Improve test names and fix spacing
- Don't force trailing slash on directory
- Don't use option forwarding
- Delete unnecessary MSBuild.exe[.config] files from test project
- Use forwarded options
* dotnet/release/2.1.5xx:
MSBuild 15.9.8-preview
MSBuild SDK Resolver Improvements (#9547)
Remove fallback folder
Remove redundent call, ensure no apt list
Update links in the readme to release/2.1.5xx
MSBuild 15.9.0-preview-000006
Use prebuild image
Revert "Disabled MSBuildTreatWarningsAsErrors"
Disabled MSBuildTreatWarningsAsErrors
Add back: "PUBLISH_NUPKG_TO_BLOB_FEED" to manage the no-suffix builds in 2.1
Adding the 2.1.3 runtime blob feed as a feed for the CLI
Update CLI branding to 2.1.402
Updated test
TestPlatform 15.9.0-preview Insertion
Update CLI branding to 2.1.203.
Fix warnings-as-errors in Linux packaging
Don't let crossgen warnings become msbuild warnings-as-errors
Fix build warning and treat msbuild warnings as errors
Conflicts:
README.md
build/DependencyVersions.props
build/package/Installer.DEB.proj
1. When there's no global.json, use latest SDK that is compatible with msbuild, not latest SDK overall
2. Respect VS setting to allow / disallow resolving to preview SDKs
This commit fixes the `ItPublishesFrameworkDependentWithRid` test to ensure
the apphost is present in the published files.
It also runs the application from the apphost to ensure it executes
successfully.
Fixes#9843.
The most recent SDK for 2.2.1xx pinned netstandard.library to 2.0.3 due to
https://github.com/dotnet/sdk/issues/2410.
This commit changes the expected version to match.
This commit suppresses the output that is displayed by the `dotnet run` command
when launch settings are being used, unless the verbosity level is above
"quiet".
Fixes#9545.
This commit integrates a fix from the SDK repo that sets
`DefaultProjectTypeGuid` for VB and C# projects when the projects are
multitargeting. This property is used by `dotnet sln add` to determine the
project type guid to map in the solution file.
Adding additional tests that cover the multitargeting scenario for `dotnet sln
add`.
Fixes#9477.
This commit adds a `--runtime` option to the `dotnet test` command for
consistency with other commands.
The option does not have a short form of `-r`, however, because `dotnet test`
already uses the short form for another option (results directory).
Fixes#9583.
