This commit adds the verbosity option to the run command.
This will be used in tests for visibility into what the run command is
doing.
The default verbosity is unaffected.
Fixes issue #7932.
* Tools shim maker and env path handling
Includes component:
* Given executable, create shim (all three OSs)
* Add executable path to Env PATH during first run
* including manual instruction when there is no access
Add ExeutablePackageObtainer
Given a tools package id, it can create a fake project and restore to correct folder
- DI, aka no circular dependency of commands
- Parser of config XML
- I try to create test nupkg at build time, so I can run test and debug
easily with VSCode. The code is in test csproj.
This commit fixes#6198.
When a project is removed from a solution using the `sln remove`
command, any projects in the solution with a project dependency (note:
this is different from a project reference) on the project should have
the project removed as a dependency.
The fix is to scan the projects in the solution and remove any
dependencies on the projects being removed. If the dependencies section
is empty after the remove, we skip serialization of the section like
Visual Studio does.
We were publishing a -debug zip with sdk code and symbols, but it was captured before
publishing was finished and had incorrect code content. Trying to use it would blow up
due to incorrect runtimeconfig.json.
Replace it with a -symbols zip that contains only symbols and that can be overlayed
over the main zip. This is just like the -langpack zip that has satellite assemblies.
Also add an option to leave the PDBs in the same directory/packages as code:
/p:SeparateSymbolsArchive=false. Setting this on local builds facilitates
debugging and profiling by removing the need to adjust symbol paths or copy PDBs
around.
It is not currently possible when there is a -f|--framework argument because
we cannot force a TargetFramework global property on to the restore evaluation.
Doing so completely breaks restore by applying the TargetFramework to all
projects transitively. The correct behavior is to restore for all frameworks,
then build/publish/etc for the given target framework. Achieving that still
requires two distinct msbuild invocations.
This also changes the verbosity of implicit restore from quiet to that
of the subsequent command (default=minimal). Similar to global properties,
we cannot specify a distinct console verbosity for the /restore portion of
the overall execution. For consistency, we apply the same verbosity change
to the case where we still use two separate msbuild invocations.
This also fixes an issue where the separate restore invocation's msbuild log
would be overwritten by the subsequent command execution. However, this remains
unfixed in the case where we still use two separate msbuild invocations.
We were taking care to set the console verbosity to minimal, but
only when no verbosity argument is passed. However, the default
verbosity for all CLI msbuild commands is already minimal and so
we can just get out of the way.
On Windows, `PathUtility.GetRelativePath` was not properly handling
paths that differed by case in the drive reference (e.g. "C:\" vs.
"c:\"). The fix was to add the missing case-insensitive comparison
argument.
Replaced uses of `PathUtility.GetRelativePath` with
`Path.GetRelativePath` where possible (requires 2.0.0+).
Additionally, `PathUtility.RemoveExtraPathSeparators` was not handling
paths with drive references on Windows. If the path contained a drive
reference, the separator between the drive reference and the first part
of the path was removed. This is due to `Path.Combine` not handling
this case, so an explicit concatenation of the separator was added.
This commit resolves issue #7699.
* dotnet/release/15.5: (21 commits)
Manually merging some changes that git merged wrong and deleted from the 15.5 branch.
Separating the 'legacy' URL construction from the 'current' URL construction methods and logic.
Use temporary path for fake deps.json in test
Use same build number for roslyn and F# satellites
Updating Roslyn satellites and SDK versions
Insert NuGet Build 4.5.0-preview2-4529 into cli
Update NuGet to 4529 (signed)
MSBuild 15.5.154
MSBuild 15.5.153
removed commented out config I'd meant to remove
added a way to specify the asp.net template versions
Porting 'dotnet-install.sh' from CLI:master to CLI:release/2.0.0
'NuGet.master.config' does not appear to be used.
Fixed tests
Update branch info to release/15.5
Updating the websdk version to 2.0.0-rel-20171010-665
Insert NuGet Build 4.5.0-preview1-4526 into cli
Update DependencyVersions.props
Updated version of TestPlatform to 15.5.0-preview-20170923-02
MSBuild 15.4.8
...
1. Publish satellites with a separate project and merge the resulting .deps.json
into (csc|vbc).deps.json
2. Move the build tasks satellites to the correct location next to main assembly
(one level higher than bincore\)
On Linux the dotnet installed by the dotnet packages is a
symlink (/usr/bin/dotnet -> ../share/dotnet/dotnet).
We need to resolve the symlink so we're passing the path to
the actual .NET Core installation to libhostfxr.
Fixes https://github.com/dotnet/cli/issues/7125
On Linux the dotnet installed by the dotnet packages is a
symlink (/usr/bin/dotnet -> ../share/dotnet/dotnet).
We need to resolve the symlink so we're passing the path to
the actual .NET Core installation to libhostfxr.
Fixes https://github.com/dotnet/cli/issues/7125
Issue https://github.com/dotnet/cli/issues/7091
Add internal command dotnet internal-reportinstallsuccess. Before
Windows installer finishes, run this command instead of dotnet new. It
will trigger the first time experience as well as sending telemetry with
installer exe name.
This command blocks to ensure that the webservice call completes.
Remove non MIT licensed components from the CLI when building on non
windows platforms. The shared framework provides the LICENSE file that is
included with the tarballs, so we just need to ensure we don't pull any
windows specific stuff that is not MIT licensed.
Fixes: dotnet/core-setup#676
* dotnet/release/2.0.0: (27 commits)
Updating the runtime to pick up the satellite assembly host fix.
Fixing some merges from release/2.0.0-preview2.
Create the Dotnet User Profile folder when running the first experience, if the folder does not exist, if will fail the first run because it will fail to create the first notice sentinel.
Add F# and Roslyn satellites
Fix tests expecting unlocalized messages from dotnet/sdk
Generating a layout folder with the satellite assemblies only which we use to generate a language pack tarball/zip. Initially, I wanted a IncludeOnlyFilter, but couldn't quite get that to work on tar, just passing the filter in the command line didn't work because the shell does not do recursive globbing. So, I opted for the layout folder.
Update SPA templates version to 1.0.0-preview-000321
Fixdotnet/sdk#1364
Add rhel and Debian download link
Exclude satellite assemblies from archive.
Remove failed workaround for Microsoft.Composition warning
Update templates to add missing BrowserLink package
Update to SetupCrossgen 215 - Coherence 25794
Update templates to suppress the warning for Microsoft.Composition and AssetTargetFallback
Add explicit dependency for pakcage smoke test
Update templates to remove the package NETStandard.Library.NETFramework
Update F# compiler to latest
Update to SetupCrossgen 213 - Coherence 25769
Pinning to the dotnet-install to version '2.0.0-preview2-006470'
Updating branch/channel information.
...
* dotnet/release/2.0.0: (35 commits)
Fixing an issue in the RepoDirectoriesProvider where it assumed that the only directory under SDK was the SDK directories. This is no longer true now that we moved the NuGet fallback folder there.
Simple clean up to the store tests
Updating xlf files for the Configurer.
Removing NuGetConfig from the first run experience and replacing the sentinel with the FirstUseNoticeSentinel when needed.
Moving the expanding fallback folder to the dotnet folder hive. The folder will be expanded at sdk/NuGetFallbackFolder.
Fixing CRLF issue.
Updating xlf and fixing line ending problems with one file.
Add rhel and Debian download link
Fix race in telemetry msbuild arg tests
Avoid repeating the first-run message if lzma archive is missing
Use fluent helper for line-end normalization
Update CoreSetup to preview3-25419-01
Updating Roslyn to 2.3.0-beta3-61816-04
Update CoreSetup to preview3-25418-01
insert new tpv2 which fixes following issue https://github.com/Microsoft/vstest/issues/632https://github.com/Microsoft/vstest/issues/844https://github.com/Microsoft/vstest/issues/847https://github.com/Microsoft/vstest/issues/840https://github.com/Microsoft/vstest/issues/843
Windows installer refresh
Update SDK to 1.1.0-alpha-20170615-3
Updating NuGet to 4.3.0-preview3-4168
MSBuild 15.3.388
Make dotnet-sln-add.Tests pass on localized setup
...
If the LZMA archive is missing, the first-run message is printed every time.
This commit fixes that.
Split the first-run message into two pieces:
- The first-run (welcome and telemetry) message is printed only once, no matter
whether the cache was primed or not.
- The cache-priming message is printed only if the cache is avaialble.
Otherwise skip the cache introduction and the ccache priming operation.
* dotnet/release/2.0.0: (72 commits)
Updating the signing project to reflect the new location of the resolver.
Another update to MSBuild. To 15.3.0-preview-000385-01.
Another update to msbuild. To 15.3.0-preview-000385-01.
Update to SetupCrossgen 183 - Coherence 25615
Don't include .NET Core MS.NET.Build.Extensions tasks for .NET Framework and vice versa
Update version of SDK and MS.NET.Build.Extensions, adapt to layout change
Updating MSBuild to 15.3.0-preview-000384-01
Update MSBuild to 15.3.0-preview-000384-01
test pack command
Changing NuGet version to Preview3-4154
Updating NuGet version to Preview3-4154
Add Microsoft.NET.Build.Extensions files to package for VS insertion
reenable smoke test of F# templates
empty commit
Don't try to CrossGen .NET Framework support DLLs
Update test platform to 15.3.0-preview-20170609-02.
Turning off implicit restore when publishing the build project.
Updating the vstest.console to use the same runtime that is shipping with the CLI.
Update to template build 256 to fix Web Auth scenarios
Add test for consuming .NET Standard 2.0 library from .NET Framework 4.6.1 project
...
Adding tests for implicit restore for all the affected commands.
Fixing an issue where the command target was being passed to the restore command during implicit restore.
Adding restore params to all commands with implicit restore. Also, implicitly set the restore output to quiet.
Adding tests for the no-restore option.
* rel/1.1.0: (41 commits)
Updating the Sdk to one that includes the error surfacing work.
Update NuGet to 4.3.0-preview2-4082
Update NuGet to 4.3.0-preview1-4081 and SDK to corresponding 1.1.0 based version
Updating MSBuild to 15.3.0-preview-000246-05 to match VS.
Updating the global.json creation to use the IFile interface and adding a unit test to cover it.
Making restore use a config file so that it does not use fallback folders that may exist in the machine.
Dropping a global.json when running the first run experience with a version that matches the version of the CLI being used in the command that triggered the first run.
Updating the websdk version for 1.0
Trying to fix the opensuse42 test failure, where we tried to invoke a tool that target 1.0.4 where the 1.0 runtime is not available.
Pinning the stage0 to the last build out of rel/1.0.1 and adding a project to download 1.0 dependencies for test assets.
Updating the branding to rel/1.1.0
Dummy commit.
Adding the access token to the lzma url.
Dummy change to force a build.
Reverting the msbuild version to the release version.
Adding the web feed to nuget.config, as some packages failed to mirror and we need a build ASAP.
Updating the msbuild, SDK and Web SDK versions.
Dummy commit to kick off the build.
the FSharp.NET.Sdk version `-bundled` contains only the Sdk dir
bump f# sdk package version
...
Prior to this change the exception on line 138 could not
be thrown, as far as I can tell. The reason for this
is that`HeaderPrefix` contained a trailing space, and we
had verified that `line` (trimmed) started with
`HeaderPrefix`. Hence `line` must contain something more
than `HeaderPrefix` otherwise the tailing space would
have been removed, so the length of `line` could not be
less than or equal to the length of `HeaderPrefix`.
Added and changed tests to ensure that both exceptions
regarding `FormatVersion` are thrown.
Fixes#5978
Remove ProjectJsonMigration and its test from solution file
Change dependecy by package reference instead of project 2 project
Construct the sln and dotnet new with wrapper that is used in migrate
package
Add reference to Nuget ProjectModel etc since CrossGen need it and it
cannot automatically get the reference
