Commit graph

101 commits

Author SHA1 Message Date
Jason Zhai
12c008a2a4 Merge branch 'release/8.0.3xx' of https://github.com/dotnet/installer into merge/release/8.0.1xx-to-release/8.0.3xx 2024-06-11 20:07:45 -07:00
Ladi Prosek
2e4e62f639
Redo "NGEN Microsoft.DotNet.MSBuildSdkResolver.dll and its dependencies" for devenv only (#19399)
Fixes: [AB#2014670](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2014670)

### Description

A change was made in 8.0.2xx to register MSBuildSdkResolver for NGEN (#17732), against both devenv.exe and MSBuild.exe. Later a bug was found in the way MSBuild.exe loads the resolver so the change was reverted in 8.0.3xx (#19112). However, because the change had a measurable positive perf effect, the revert was effectively a regression for devenv.exe and got flagged so by PerfDDRITs.

This PR is a re-do of the original change, only this time with MSBuild.exe omitted, i.e. we're NGENing the resolver only for the default architecture of devenv.exe.

### Customer Impact

Startup perf regression, about 5% more methods JITted in scenarios measured by Visual Studio PerfDDRITs.

### Regression

Yes, perf regression in VS 17.10.

### Risk 

Low
2024-04-12 09:20:24 -05:00
Marc Paine
8edfe5367b
match the version of SRM msbuild depends on 2024-04-03 13:41:57 -07:00
Ladi Prosek
4c8fb55b04
Revert "[release/8.0.2xx] NGEN Microsoft.DotNet.MSBuildSdkResolver.dll and its dependencies (#17750)" (#19112)
This reverts commit f0c4e4e14c.

Fixes [AB#1994786](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1994786/)

The MSBuild change which took advantage of this was reverted in 17.9 because it introduced issues in installations that don't have the .NET SDK component installed. We are fixing the bug in 9.0 by making changes to the dependencies of `Microsoft.DotNet.MSBuildSdkResolver` (see https://github.com/dotnet/sdk/pull/39573) so this should stay in main. I am reverting it only in 8.0.3xx / 17.10 to fix the `Build_Ngen_InvalidAssemblyCount` counter which was flagged as a regression by PerfDDRITs.
2024-03-20 16:34:57 +01:00
Marc Paine
3788d3c64d Update to the shipping version of MSBuild 2024-03-12 15:42:44 -07:00
Jason Zhai
81db5e02ce Merge branch 'release/8.0.1xx' into release/8.0.2xx 2024-01-10 02:11:32 -08:00
Nikola Milosavljevic
426d535488
[release/8.0.1xx] Use SHA256 for RPM digest (#18111) 2024-01-09 11:06:50 -08:00
Forgind
5bfcb0cf50 Merge branch 'baseline-manifest' of https://github.com/Forgind/installer into baseline-manifest-8.0.2 2023-12-19 12:07:04 -08:00
github-actions[bot]
f0c4e4e14c
[release/8.0.2xx] NGEN Microsoft.DotNet.MSBuildSdkResolver.dll and its dependencies (#17750)
Backport of #17732 to release/8.0.2xx

MSBuild.exe currently spends a significant amount of time JITting `Microsoft.DotNet.MSBuildSdkResolver` and its dependencies, see https://github.com/dotnet/msbuild/issues/9303 for details.

This PR makes Visual Studio installer add these assemblies to the NGEN queue, which is a necessary condition for eliminating JITting. Just like `Microsoft.Build.*` assemblies, we need to NGEN these with two configurations: vsn.exe so it works in the devenv process, and MSBuild.exe so it works in MSBuild satellite processes.
2023-11-14 10:49:41 +01:00
Tom Deseyn
1078c97cf8 Use symbolic links instead of hard links in runtime pack directories.
The hard links are causing issues with package tooling.
This changes to use symbolic links instead.

Besides fixing the issues with the package tooling,
symbolic links are easier to preserve throughout
the packaging process.
2023-10-18 08:37:51 +02:00
dotnet-maestro[bot]
a5cadd18b6
[release/8.0.1xx] Update dependencies from dotnet/source-build-externals (#17266) 2023-08-31 07:58:50 -05:00
Forgind
465fe07004 PR feedback 2023-07-31 09:49:10 -07:00
Forgind
f76662028c Add some copyright headers 2023-07-27 12:58:00 -07:00
Forgind
9606060377 Tweak task to make it more general 2023-07-26 15:14:04 -07:00
Forgind
406f7ed423 Create task to parse json files 2023-07-25 16:08:41 -07:00
Tom Deseyn
69f653a226 Rename Task. 2023-06-09 16:21:45 +02:00
Tom Deseyn
8e20e9586e Fix .NET Framework build. 2023-06-09 11:42:50 +02:00
Tom Deseyn
df78b1fe28 Don't use nullable because it's not supported by C# 7.3 builds. 2023-06-09 09:55:44 +02:00
Tom Deseyn
2d8d854867 PR feedback. 2023-06-09 09:34:25 +02:00
Tom Deseyn
308b0076e8 Replace rdfind invocation with Task that replaces duplicate files with links. 2023-06-08 09:09:57 +02:00
Michael Simons
8f01b7d3f7
Enable source-build pvp flow for installer (#16550)
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
2023-06-01 19:01:35 +00:00
Marc Paine
5645dfe608
Merge branch 'main' into merge/release/7.0.4xx-to-main 2023-04-24 17:06:04 -07:00
Marc Paine
a4ec49fae3
Fix the swr file logic
It was supposed to be && and not || to avoid copying those files
2023-04-21 10:14:05 -07:00
dotnet-maestro-bot
16c10f8115
[automated] Merge branch 'release/7.0.4xx' => 'main' (#16134)
Co-authored-by: dotnet-bot <dotnet-bot@microsoft.com>
Co-authored-by: DotNet-Bot <dn-bot@microsoft.com>
Co-authored-by: Matt Mitchell (.NET) <mmitche@microsoft.com>
Co-authored-by: Sean Reeser <v-seanreeser@microsoft.com>
Co-authored-by: Marc Paine <marcpop@microsoft.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Noah Gilson <noahgilson@microsoft.com>
Co-authored-by: v-wuzhai <46013274+v-wuzhai@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: NET Source-Build Bot <102560831+dotnet-sb-bot@users.noreply.github.com>
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
Co-authored-by: vseanreesermsft <78103370+vseanreesermsft@users.noreply.github.com>
Co-authored-by: Jason Zhai <v-wuzhai@microsoft.com>
2023-04-18 14:32:12 +02:00
Marc Paine
0f9a87bd8e Include the swr file in the nuget package 2023-04-14 15:22:44 -07:00
Nikola Milosavljevic
3b2ceb2072 Add support for partial tarball extraction 2023-03-10 23:06:01 +00:00
Jason Zhai
448a42d109 Merge branch 'release/7.0.3xx' 2023-02-22 00:25:05 -08:00
Marc Paine
db2e7bac4f Change how VS setup authoring is configured. 2023-02-14 16:35:54 -08:00
Drew Scoggins
c48f6b9ef7 Addres pr feedback 2023-01-30 11:29:00 -08:00
Drew Scoggins
c1a4771218 Change approach to only extract files that match criteria 2023-01-26 16:04:14 -08:00
EgorBo
9469f5c7d1 address feedback 2022-02-05 23:56:28 +03:00
Egor Bogatov
1dc073731d
Update GetDependencyInfo.cs 2022-01-27 20:19:51 +03:00
EgorBo
8fa51f49e8 Save dependent dotnet/runtime's commit and version to productCommit-rid.txt 2022-01-27 19:21:52 +03:00
Djuradj Kurepa
8762385417 include System.Net.Http version 4.3.4 2021-11-08 10:41:56 +01:00
Djuradj Kurepa
4b5642d215 Change back to WindowsAzure.Storage and update the version to 9.3.3 2021-11-05 12:57:17 +01:00
Djuradj Kurepa
0336fa748e Resolve Microsoft.Data.OData Component Governance alert 2021-11-04 15:47:36 +01:00
Bruno Garcia
c57d3051d8
remove unused env var
* DOTNET_SKIP_FIRST_TIME_EXPERIENCE
2021-09-12 16:24:08 -04:00
Matt Mitchell
9994b20baa
Changes for internal runtime build support for .NET 6 (#11422)
- Cherry pick the internal runtime download changes over
- Cherry pick changes to the arcade SB template over (making the next update a noop and unblocking P7+)
- Hoist out the variable groups and parameters needed for the internal download to the top level yaml file.
- Remove the old DownloadFile task and replace this with the Arcade version. Specifically this allows us to remove
  set/use of the DOTNETCLIMSRC_READ_SAS_TOKEN environment variable and instead rely on that task's ability to decode and
  use a base64 encoded SAS token. The reason for the environment variable usage before was that the
  non-encoded SAS token was getting mangled by msbuild/bash/etc. on non-Windows OSs.
- Update the source build tarball template with support for internal runtimes

Update to source build template
2021-08-06 13:54:33 -07:00
dotnet-maestro[bot]
130a6b657a
[main] Update dependencies from dotnet/arcade (#11416)
[main] Update dependencies from dotnet/arcade
- Coherency Updates:
  - Microsoft.DotNet.XliffTasks: from 1.0.0-beta.21378.1 to 1.0.0-beta.21380.1 (parent: Microsoft.DotNet.Arcade.Sdk)

 - Disable implicit namespaces
2021-08-06 20:18:02 +00:00
Marc Paine
238e293a44 Update our version of newtonsoft.json.dll to latest. 2021-07-30 15:56:26 -07:00
Pranav K
97675dbc5a
Modify GenerateLayout to work with runtime configs that contain more than one runtime (#10901) 2021-06-17 09:36:05 -07:00
Manish Godse
959245b50a CR feedback 2021-06-13 17:47:24 -07:00
Manish Godse
bc6490c598 fix musl built on alpine 2021-06-12 01:55:58 -07:00
Manish Godse
38a2c60199 Fix cross builds. 2021-06-11 22:54:54 -07:00
Manish Godse
ed9c92df3a propagate targetArch to crossgen2 2021-06-11 21:25:25 -07:00
Manish Godse
88b8fc6b33 replace crossgen with crossgen2
crossgen is now defunct. This is validated on windows x64. More work will be required to get it to work across OS/arch.
2021-06-11 21:11:16 -07:00
Matt Mitchell
e58843bebc
Remove Copy Blobs To Latest functionality and clean up some publishing (#10773)
- The stage has been subsumed by the aka.ms functionality and now can be removed.
- Clean up dead properties and functionality no longer needed because of it.
- Removing publishing of nupkg files as blobs. This used to be useful before because we often needed to get at the nupkgs in a flat, easy to copy format for pushing to the VS feed. But now the staging pipeline takes care of this, and moreover the use of post-build signing means that these files are not useful straight out of the build anyway. This should reduce publishing time and some post-build signing time.

Remove nupkg install in publishing.props
2021-05-26 15:13:19 -07:00
Josh Soref
3676a74548 spelling: parameters
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2021-05-26 05:16:13 -04:00
Josh Soref
16efdaacbb spelling: package
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2021-05-26 05:16:13 -04:00
Josh Soref
4a643533f3 spelling: occurred
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2021-05-26 05:16:13 -04:00