mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Re-enabling some unit tests that were skipped, but are again valid with net core 2.1

Browse source
This commit is contained in:
seancpeters 2017-08-31 15:31:44 -07:00
parent 99489cf402
commit ffdccdfc21
6 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/EndToEnd/GivenDotNetUsesMSBuild.cs
View file

@ -12,7 +12,7 @@ namespace Microsoft.DotNet.Tests.EndToEnd
{ {
public class GivenDotNetUsesMSBuild : TestBase public class GivenDotNetUsesMSBuild : TestBase
{ {
[Fact(Skip = "https://github.com/dotnet/cli/issues/7476")] [Fact]
public void ItCanNewRestoreBuildRunCleanMSBuildProject() public void ItCanNewRestoreBuildRunCleanMSBuildProject()
{ {
using (DisposableDirectory directory = Temp.CreateDirectory()) using (DisposableDirectory directory = Temp.CreateDirectory())

2
test/dotnet-build.Tests/GivenDotnetBuildBuildsCsproj.cs
View file

@ -85,7 +85,7 @@ namespace Microsoft.DotNet.Cli.Build.Tests
.And.HaveStdOutContaining("project.assets.json"); .And.HaveStdOutContaining("project.assets.json");
} }
[Fact(Skip = "https://github.com/dotnet/cli/issues/7476")] [Fact]
public void ItRunsWhenRestoringToSpecificPackageDir() public void ItRunsWhenRestoringToSpecificPackageDir()
{ {
var rootPath = TestAssets.CreateTestDirectory().FullName; var rootPath = TestAssets.CreateTestDirectory().FullName;

5
test/dotnet-new.Tests/GivenThatIWantANewApp.cs
View file

@ -77,9 +77,10 @@ namespace Microsoft.DotNet.New.Tests
.Should().Pass(); .Should().Pass();
} }
[Theory(Skip = "https://github.com/dotnet/cli/issues/7476")] [Theory]
[InlineData("console", "RuntimeFrameworkVersion", "microsoft.netcore.app")] [InlineData("console", "RuntimeFrameworkVersion", "microsoft.netcore.app")]
[InlineData("classlib", "NetStandardImplicitPackageVersion", "netstandard.library")] // issue with netstandard2.0 - formerly both test cases were skipped because of: https://github.com/dotnet/cli/issues/7476
//[InlineData("classlib", "NetStandardImplicitPackageVersion", "netstandard.library")]
public void NewProjectRestoresCorrectPackageVersion(string type, string propertyName, string packageName) public void NewProjectRestoresCorrectPackageVersion(string type, string propertyName, string packageName)
{ {
var rootPath = TestAssets.CreateTestDirectory(identifier: $"_{type}").FullName; var rootPath = TestAssets.CreateTestDirectory(identifier: $"_{type}").FullName;

2
test/dotnet-new.Tests/GivenThatIWantANewAppWithSpecifiedType.cs
View file

@ -27,7 +27,7 @@ namespace Microsoft.DotNet.New.Tests
[InlineData("C#", "react", false, true)] [InlineData("C#", "react", false, true)]
[InlineData("C#", "reactredux", false, true)] [InlineData("C#", "reactredux", false, true)]
[InlineData("F#", "console", false, false)] [InlineData("F#", "console", false, false)]
// https://github.com/dotnet/cli/issues/7476 // issue with netstandard2.0 --- formerly was issue with: https://github.com/dotnet/cli/issues/7476
//[InlineData("F#", "classlib", false, false)] //[InlineData("F#", "classlib", false, false)]
[InlineData("F#", "mstest", false, false)] [InlineData("F#", "mstest", false, false)]
[InlineData("F#", "xunit", false, false)] [InlineData("F#", "xunit", false, false)]

2
test/dotnet-publish.Tests/GivenDotnetPublishPublishesProjects.cs
View file

@ -197,7 +197,7 @@ namespace Microsoft.DotNet.Cli.Publish.Tests
} }
} }
[Fact(Skip = "https://github.com/dotnet/cli/issues/7476")] [Fact]
public void ItPublishesAppWhenRestoringToSpecificPackageDirectory() public void ItPublishesAppWhenRestoringToSpecificPackageDirectory()
{ {
var rootPath = TestAssets.CreateTestDirectory().FullName; var rootPath = TestAssets.CreateTestDirectory().FullName;

2
test/dotnet-run.Tests/GivenDotnetRunRunsCsProj.cs
View file

@ -192,7 +192,7 @@ namespace Microsoft.DotNet.Cli.Run.Tests
.And.HaveStdOutContaining("Hello World!"); .And.HaveStdOutContaining("Hello World!");
} }
[Fact(Skip = "https://github.com/dotnet/cli/issues/7476")] [Fact]
public void ItRunsAppWhenRestoringToSpecificPackageDirectory() public void ItRunsAppWhenRestoringToSpecificPackageDirectory()
{ {
var rootPath = TestAssets.CreateTestDirectory().FullName; var rootPath = TestAssets.CreateTestDirectory().FullName;