Re-enabling some unit tests that were skipped, but are again valid with net core 2.1

This commit is contained in:
seancpeters 2017-08-31 15:31:44 -07:00
parent 99489cf402
commit ffdccdfc21
6 changed files with 8 additions and 7 deletions

View file

@ -12,7 +12,7 @@ namespace Microsoft.DotNet.Tests.EndToEnd
{
public class GivenDotNetUsesMSBuild : TestBase
{
[Fact(Skip = "https://github.com/dotnet/cli/issues/7476")]
[Fact]
public void ItCanNewRestoreBuildRunCleanMSBuildProject()
{
using (DisposableDirectory directory = Temp.CreateDirectory())

View file

@ -85,7 +85,7 @@ namespace Microsoft.DotNet.Cli.Build.Tests
.And.HaveStdOutContaining("project.assets.json");
}
[Fact(Skip = "https://github.com/dotnet/cli/issues/7476")]
[Fact]
public void ItRunsWhenRestoringToSpecificPackageDir()
{
var rootPath = TestAssets.CreateTestDirectory().FullName;

View file

@ -77,9 +77,10 @@ namespace Microsoft.DotNet.New.Tests
.Should().Pass();
}
[Theory(Skip = "https://github.com/dotnet/cli/issues/7476")]
[Theory]
[InlineData("console", "RuntimeFrameworkVersion", "microsoft.netcore.app")]
[InlineData("classlib", "NetStandardImplicitPackageVersion", "netstandard.library")]
// issue with netstandard2.0 - formerly both test cases were skipped because of: https://github.com/dotnet/cli/issues/7476
//[InlineData("classlib", "NetStandardImplicitPackageVersion", "netstandard.library")]
public void NewProjectRestoresCorrectPackageVersion(string type, string propertyName, string packageName)
{
var rootPath = TestAssets.CreateTestDirectory(identifier: $"_{type}").FullName;

View file

@ -27,7 +27,7 @@ namespace Microsoft.DotNet.New.Tests
[InlineData("C#", "react", false, true)]
[InlineData("C#", "reactredux", false, true)]
[InlineData("F#", "console", false, false)]
// https://github.com/dotnet/cli/issues/7476
// issue with netstandard2.0 --- formerly was issue with: https://github.com/dotnet/cli/issues/7476
//[InlineData("F#", "classlib", false, false)]
[InlineData("F#", "mstest", false, false)]
[InlineData("F#", "xunit", false, false)]

View file

@ -197,7 +197,7 @@ namespace Microsoft.DotNet.Cli.Publish.Tests
}
}
[Fact(Skip = "https://github.com/dotnet/cli/issues/7476")]
[Fact]
public void ItPublishesAppWhenRestoringToSpecificPackageDirectory()
{
var rootPath = TestAssets.CreateTestDirectory().FullName;

View file

@ -192,7 +192,7 @@ namespace Microsoft.DotNet.Cli.Run.Tests
.And.HaveStdOutContaining("Hello World!");
}
[Fact(Skip = "https://github.com/dotnet/cli/issues/7476")]
[Fact]
public void ItRunsAppWhenRestoringToSpecificPackageDirectory()
{
var rootPath = TestAssets.CreateTestDirectory().FullName;