mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Add runtime patch to remove unnecessary suppressions (#17030)

Browse source
This commit is contained in:
Matt Thalman 2023-07-21 08:52:01 -05:00 • committed by GitHub
parent 18ea05c055
commit f6339d410e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 64 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

64
src/SourceBuild/patches/runtime/0001-Remove-unnecessary-suppressions.patch Normal file
View file

@ -0,0 +1,64 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Matt Thalman <mthalman@microsoft.com>
Date: Wed, 19 Jul 2023 09:57:31 -0500
Subject: [PATCH] Remove unnecessary suppressions
Backport: https://github.com/dotnet/runtime/issues/89206
---
.../src/CompatibilitySuppressions.xml | 12 ------------
.../src/CompatibilitySuppressions.xml | 6 ------
2 files changed, 18 deletions(-)
diff --git a/src/coreclr/nativeaot/System.Private.CoreLib/src/CompatibilitySuppressions.xml b/src/coreclr/nativeaot/System.Private.CoreLib/src/CompatibilitySuppressions.xml
index c410fee4e53..799cd7ab69d 100644
--- a/src/coreclr/nativeaot/System.Private.CoreLib/src/CompatibilitySuppressions.xml
+++ b/src/coreclr/nativeaot/System.Private.CoreLib/src/CompatibilitySuppressions.xml
@@ -800,10 +800,6 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Diagnostics.DebugAnnotations</Target>
</Suppression>
- <Suppression>
- <DiagnosticId>CP0001</DiagnosticId>
- <Target>T:System.Diagnostics.DebuggerGuidedStepThroughAttribute</Target>
- </Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.MDArray</Target>
@@ -868,10 +864,6 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Reflection.RuntimeAssemblyName</Target>
</Suppression>
- <Suppression>
- <DiagnosticId>CP0001</DiagnosticId>
- <Target>T:System.Runtime.CompilerServices.EagerStaticClassConstructionAttribute</Target>
- </Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.CompilerServices.ForceDictionaryLookupsAttribute</Target>
@@ -1006,8 +998,4 @@
<Left>ref/net8.0/System.Private.CoreLib.dll</Left>
<Right>lib/net8.0/System.Private.CoreLib.dll</Right>
</Suppression>
- <Suppression>
- <DiagnosticId>CP0016</DiagnosticId>
- <Target>M:System.Runtime.InteropServices.Marshal.GetObjectForNativeVariant``1(System.IntPtr)-&gt;T?:[T:System.Diagnostics.CodeAnalysis.MaybeNullAttribute]</Target>
- </Suppression>
</Suppressions>
\ No newline at end of file
diff --git a/src/libraries/System.Runtime.InteropServices.JavaScript/src/CompatibilitySuppressions.xml b/src/libraries/System.Runtime.InteropServices.JavaScript/src/CompatibilitySuppressions.xml
index ce09898be3a..8e4cf516027 100644
--- a/src/libraries/System.Runtime.InteropServices.JavaScript/src/CompatibilitySuppressions.xml
+++ b/src/libraries/System.Runtime.InteropServices.JavaScript/src/CompatibilitySuppressions.xml
@@ -43,12 +43,6 @@
<Left>ref/net8.0/System.Runtime.InteropServices.JavaScript.dll</Left>
<Right>runtimes/browser/lib/net8.0/System.Runtime.InteropServices.JavaScript.dll</Right>
</Suppression>
- <Suppression>
- <DiagnosticId>CP0001</DiagnosticId>
- <Target>T:System.Runtime.InteropServices.JavaScript.WebWorker</Target>
- <Left>ref/net8.0/System.Runtime.InteropServices.JavaScript.dll</Left>
- <Right>runtimes/browser/lib/net8.0/System.Runtime.InteropServices.JavaScript.dll</Right>
- </Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.InteropServices.JavaScript.CancelablePromise</Target>