Some more try...catches

src/dotnet/commands/dotnet-msbuild/MSBuildForwardingApp.cs

@@ -32,10 +32,17 @@ namespace Microsoft.DotNet.Tools.MSBuild
         public MSBuildForwardingApp(IEnumerable<string> argsToForward)
         {
             if (Telemetry.CurrentSessionId != null)
+            {
+                try
                 {
                     Type loggerType = typeof(MSBuildLogger);
 
-                argsToForward = argsToForward.Concat(new[] {$"\"/Logger:{loggerType.FullName},{loggerType.GetTypeInfo().Assembly.Location};{Telemetry.CurrentSessionId}\""});
+                    argsToForward = argsToForward.Concat(new[] { $"\"/Logger:{loggerType.FullName},{loggerType.GetTypeInfo().Assembly.Location}\"" });
+                }
+                catch (Exception)
+                {
+                    // Exceptions during telemetry shouldn't cause anything else to fail
+                }
             }
 
             _forwardingApp = new ForwardingApp(

src/dotnet/commands/dotnet-msbuild/MSBuildLogger.cs

@@ -5,7 +5,6 @@ using System;
 using Microsoft.Build.Framework;
 using Microsoft.Build.Utilities;
 using Microsoft.DotNet.Cli;
-using Microsoft.DotNet.Cli.Utils;
 using Microsoft.DotNet.Configurer;
 
 namespace Microsoft.DotNet.Tools.MSBuild
@@ -16,6 +15,8 @@ namespace Microsoft.DotNet.Tools.MSBuild
         private readonly ITelemetry _telemetry;
 
         public MSBuildLogger()
+        {
+            try
             {
                 string sessionId = Environment.GetEnvironmentVariable(MSBuildForwardingApp.TelemetrySessionIdEnvironmentVariableName);
 
@@ -24,27 +25,47 @@ namespace Microsoft.DotNet.Tools.MSBuild
                     _telemetry = new Telemetry(_sentinel, sessionId);
                 }
             }
+            catch (Exception)
+            {
+                // Exceptions during telemetry shouldn't cause anything else to fail
+            }
+        }
 
         public override void Initialize(IEventSource eventSource)
         {
-            if (_telemetry != null)
+            try
+            {
+                if (_telemetry != null && _telemetry.Enabled)
                 {
                     IEventSource2 eventSource2 = eventSource as IEventSource2;
 
                     if (eventSource2 != null)
                     {
-                    eventSource2.TelemetryLogged += (sender, telemetryEventArgs) =>
+                        eventSource2.TelemetryLogged += OnTelemetryLogged;
+                    }
+                }
+            }
+            catch(Exception)
             {
-                        Console.WriteLine($"Received telemetry event '{telemetryEventArgs.EventName}'");
+                // Exceptions during telemetry shouldn't cause anything else to fail
-                        _telemetry.TrackEvent(telemetryEventArgs.EventName, telemetryEventArgs.Properties, measurements: null);
-                    };
             }
         }
+
+        private void OnTelemetryLogged(object sender, TelemetryEventArgs args)
+        {
+            _telemetry.TrackEvent(args.EventName, args.Properties, measurements: null);
         }
 
         public override void Shutdown()
+        {
+            try
             {
                 _sentinel?.Dispose();
+            }
+            catch (Exception)
+            {
+                // Exceptions during telemetry shouldn't cause anything else to fail
+            }
 
             base.Shutdown();
         }