From e7cd00d5bf94693dbd7f7536add4a9ddf2422275 Mon Sep 17 00:00:00 2001 From: Michael Simons Date: Fri, 6 Aug 2021 18:53:24 -0500 Subject: [PATCH] [ArPow Tarball] Tier 2 - Add runtime-portable repo to arpow tarball (#11078) * [ArPow Tarball] Tier 2 - Add runtime-portable repo to arpow tarball * Update TemporaryBootstrapPackageVersions.props * Revert too aggressive of version updates in TemporaryBootstrapPackageVersions.props * Remove allconfigurations flag since some are not valid in source-build * Don't copy tools anymore after Package This target is no longer needed as it was meant to copy ilasm/ildasm to a known directory to be picked up by SBRP. SBRP now uses the nupkg. * Update binlog param to ensure we get inner binlog * Don't build stable versions for preview * Update DirectoryBuild.props in src if root one isn't found * Add dotnet6 feed to NuGet.Configs * Remove unneeded properties in runtime.common.props * Increase timeout on create tarball job * Update portable build cleanup * Remove timeout on Create Tarball job * Only add source when building online * Update prebuilts version Co-authored-by: dseefeld --- eng/SourceBuild.Version.Details.xml | 5 + eng/Versions.props | 2 +- .../tarball/content/Directory.Build.props | 2 +- .../TemporaryBootstrapPackageVersions.props | 4 +- .../tarball/content/eng/Versions.props | 2 +- .../0001-Remove-allconfigurations-flag.patch | 26 ++++ .../content/repos/Directory.Build.targets | 16 ++- .../tarball/content/repos/known-good.proj | 1 + .../content/repos/runtime-portable.proj | 40 ++----- .../content/repos/runtime.common.props | 113 ++---------------- .../content/repos/runtime.common.targets | 26 ---- .../tarball/content/repos/runtime.proj | 1 - 12 files changed, 71 insertions(+), 167 deletions(-) create mode 100644 src/SourceBuild/tarball/content/patches/runtime/0001-Remove-allconfigurations-flag.patch diff --git a/eng/SourceBuild.Version.Details.xml b/eng/SourceBuild.Version.Details.xml index db9bdda4f..ab47e19c4 100644 --- a/eng/SourceBuild.Version.Details.xml +++ b/eng/SourceBuild.Version.Details.xml @@ -42,6 +42,11 @@ d16c8bd011951d9bd15809d9004276cf7baaa786 + + https://github.com/dotnet/runtime + 566b53a66b0afa573f0dae33d07c8de9685aa5c8 + + https://github.com/dotnet/symreader 1968a003d845d119a9d38ac4daaeea22897f7daf diff --git a/eng/Versions.props b/eng/Versions.props index e3b6c5a3c..6d5d34f6f 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -159,7 +159,7 @@ 15.7.179 15.7.179 0.1.0-6.0.100-bootstrap.11 - 0.1.0-6.0.100-2 + 0.1.0-6.0.100-3 diff --git a/src/SourceBuild/tarball/content/Directory.Build.props b/src/SourceBuild/tarball/content/Directory.Build.props index 5d4450f8d..82c9f1436 100644 --- a/src/SourceBuild/tarball/content/Directory.Build.props +++ b/src/SourceBuild/tarball/content/Directory.Build.props @@ -20,7 +20,7 @@ $(BuildArchitecture) x64 - true + false + + + diff --git a/src/SourceBuild/tarball/content/repos/runtime-portable.proj b/src/SourceBuild/tarball/content/repos/runtime-portable.proj index 0faeb9afc..2f499c223 100644 --- a/src/SourceBuild/tarball/content/repos/runtime-portable.proj +++ b/src/SourceBuild/tarball/content/repos/runtime-portable.proj @@ -1,56 +1,42 @@ - - - runtime - true - false - - - - + - + $(ProjectDirectory)artifacts/portableLog $(ProjectDirectory)artifacts/portableObj - - + + - - + + - - - - + + + + - + - - - - <_BuiltPackages Include="$(ShippingPackagesOutput)/*linux*nupkg" Exclude="$(ShippingPackagesOutput)/*.symbols.nupkg" /> - <_BuiltPackages Include="$(NonShippingPackagesOutput)/*linux*nupkg" Exclude="$(NonShippingPackagesOutput)/*.symbols.nupkg" /> - - - diff --git a/src/SourceBuild/tarball/content/repos/runtime.common.props b/src/SourceBuild/tarball/content/repos/runtime.common.props index 55fe99d15..4ce8f8e1d 100644 --- a/src/SourceBuild/tarball/content/repos/runtime.common.props +++ b/src/SourceBuild/tarball/content/repos/runtime.common.props @@ -1,130 +1,32 @@ + runtime runtime - - - - $(PortableBuild) - true - - $(TargetRid) - osx-x64 - freebsd-x64 - win-x64 - linux-$(Platform) - - false - false - $(UseSystemLibraries) - - - - $(ProjectDirectory)global.json true - - $(CoreClrBuildArguments) -cmakeargs -DCLR_CMAKE_USE_SYSTEM_LIBUNWIND=TRUE - $(CoreClrBuildArguments) skipnuget cross -skiprestore cmakeargs -DFEATURE_GDBJIT=TRUE - $(CoreClrBuildArguments) -clang6.0 /p:PortableBuild=true + + $(StandardSourceBuildArgs.Replace('-bl', '-nobl')) - - $(CoreClrBuildArguments) /p:PortableBuild=false + $(StandardSourceBuildCommand) $(BuildCommandArgs) + $(ArmEnvironmentVariables) $(StandardSourceBuildCommand) $(BuildCommandArgs) - $(CoreClrBuildArguments) /p:PackagesDir=$(PackagesDir) - $(CoreClrBuildArguments) /p:ContinuousIntegrationBuild=true - $(CoreClrBuildArguments) /p:PackageRid=$(OverrideTargetRid) - - $(CoreClrBuildArguments) /p:NoPgoOptimize=true - $(CoreClrBuildArguments) /p:KeepNativeSymbols=true - $(CoreClrBuildArguments) /p:RuntimeOS=$(OverrideTargetRid.Substring(0, $(OverrideTargetRid.IndexOf("-")))) - $(CoreClrBuildArguments) /p:RuntimeOS=$(OverrideTargetRid) - - - - $(LibrariesBuildArguments) $(FlagParameterPrefix)restore $(FlagParameterPrefix)build $(FlagParameterPrefix)pack /p:SkipTests=true - $(LibrariesBuildArguments) $(FlagParameterPrefix)restore $(FlagParameterPrefix)build /p:IncludeTestUtils=true - $(LibrariesBuildArguments) $(FlagParameterPrefix)restore $(FlagParameterPrefix)buildtests $(FlagParameterPrefix)test /p:IncludeTestUtils=true - $(LibrariesBuildArguments) /p:TestRspFile=$(TestExclusionsDir)corefx/linux.docker.rsp - $(LibrariesBuildArguments) /p:ConfigurationGroup=$(Configuration) - $(LibrariesBuildArguments) /p:PackageRid=$(OverrideTargetRid) - - $(LibrariesBuildArguments) /p:RuntimeOS=$(OverrideTargetRid.Substring(0, $(OverrideTargetRid.IndexOf("-")))) - $(LibrariesBuildArguments) /p:RuntimeOS=$(OverrideTargetRid) - $(LibrariesBuildArguments) /p:PortableBuild=$(OverridePortableBuild) - $(LibrariesBuildArguments) /p:BuildAllPackages=true - $(LibrariesBuildArguments) /p:BuildAllOOBPackages=true - $(LibrariesBuildArguments) /p:KeepNativeSymbols=true - $(LibrariesBuildArguments) /p:BuiltSdkPackageOverride="" - $(LibrariesBuildArguments) /p:MicrosoftNETCoreDotNetHostPackageVersion=$(DOTNET_HOST_BOOTSTRAP_VERSION) - $(LibrariesBuildArguments) /p:MicrosoftNETCoreDotNetHostPolicyPackageVersion=$(DOTNET_HOST_BOOTSTRAP_VERSION) - - - - - $(FlagParameterPrefix)restore $(FlagParameterPrefix)build - $(InstallerBuildArguments) /p:PortableBuild=$(OverridePortableBuild) - $(InstallerBuildArguments) /p:KeepNativeSymbols=true - $(InstallerBuildArguments) -cmakeargs -DCLR_CMAKE_USE_SYSTEM_LIBUNWIND=TRUE - $(InstallerBuildArguments) /p:TargetArchitecture=$(Platform) /p:DisableCrossgen=true /p:CrossBuild=true - $(InstallerBuildArguments) /p:BuildDebPackage=false - $(InstallerBuildArguments) /p:BuildAllPackages=true - $(InstallerBuildArguments) /p:RestoreAllBuildRids=false - $(InstallerBuildArguments) /p:OutputRid=$(OverrideTargetRid) - $(InstallerBuildArguments) /p:DotNetOutputBlobFeedDir=$(SourceBuiltBlobFeedDir) - $(InstallerBuildArguments) /p:PublishCompressedFilesPathPrefix=$(SourceBuiltRuntimeDir) - $(InstallerBuildArguments) /p:BuiltSdkPackageOverride="" - $(InstallerBuildArguments) $(FlagParameterPrefix)warnAsError $(ArcadeFalseBoolBuildArg) - - $(FlagParameterPrefix)arch $(Platform) - $(CommonBuildArguments) $(FlagParameterPrefix)configuration $(Configuration) - $(CommonBuildArguments) /p:RuntimeConfiguration=$(Configuration) - $(CommonBuildArguments) /p:MicrosoftNetFrameworkReferenceAssembliesVersion=1.0.0 - $(CommonBuildArguments) $(FlagParameterPrefix)binaryLog - $(CommonBuildArguments) $(FlagParameterPrefix)ci - $(CommonBuildArguments) $(FlagParameterPrefix)runtimeConfiguration $(Configuration) - $(CommonBuildArguments) $(FlagParameterPrefix)verbosity $(LogVerbosity) - - $(CommonBuildArguments) $(FlagParameterPrefix)nodereuse $(ArcadeFalseBoolBuildArg) - $(CommonBuildArguments) $(FlagParameterPrefix)warnAsError $(ArcadeFalseBoolBuildArg) - - $(ProjectDirectory)build-source-build$(ShellExtension) $(CommonBuildArguments) $(FlagParameterPrefix)coreclr-args $(CoreClrBuildArguments) $(FlagParameterPrefix)libraries-args $(LibrariesBuildArguments) $(FlagParameterPrefix)installer-args $(InstallerBuildArguments) $(FlagParameterPrefix)additional-args - $(ArmEnvironmentVariables) $(BuildCommand) $(ProjectDirectory)/clean$(ShellExtension) - false - $(ProjectDirectory)artifacts/packages/$(Configuration)/Shipping/ - $(ProjectDirectory)artifacts/packages/$(Configuration)/NonShipping/ + $(ProjectDirectory)global.json $(ProjectDirectory)NuGet.config + false true - - - $(SourceBuiltPackagesPath) - $(EnvironmentRestoreSources)%3B$(ShippingPackagesOutput) - $(EnvironmentRestoreSources)%3B$(NonShippingPackagesOutput) - $(EnvironmentRestoreSources)%3B$(ReferencePackagesDir)%3B$(PrebuiltPackagesPath) - $(EnvironmentRestoreSources)%3Bhttps://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public%40Local/nuget/v3/index.json - - - @@ -135,7 +37,6 @@ - diff --git a/src/SourceBuild/tarball/content/repos/runtime.common.targets b/src/SourceBuild/tarball/content/repos/runtime.common.targets index a6d5f88ce..ca606b23d 100644 --- a/src/SourceBuild/tarball/content/repos/runtime.common.targets +++ b/src/SourceBuild/tarball/content/repos/runtime.common.targets @@ -22,32 +22,6 @@ Rid="$(TargetRid)-$(Platform)" /> - - - $(ToolPackageExtractDir)coreclr-tools - so - so - dylib - please define AssemblyExtension for $(TargetOS) - - - - - - - - - - - - - - - - -