mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Removing DocumentationFile path from migration and one test asset.

Browse source
This commit is contained in:
Parallels 2016-11-04 11:51:43 -07:00
parent cb7c9360b7
commit d68341b92d
2 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
TestAssets/TestProjects/TestLibraryWithConfiguration/TestLibraryWithConfiguration.csproj
View file

@ -5,7 +5,6 @@
<TargetFramework>netstandard1.5</TargetFramework> <TargetFramework>netstandard1.5</TargetFramework>
<NoWarn>$(NoWarn);CS1591</NoWarn> <NoWarn>$(NoWarn);CS1591</NoWarn>
<GenerateDocumentationFile>true</GenerateDocumentationFile> <GenerateDocumentationFile>true</GenerateDocumentationFile>
<DocumentationFile>$(OutputPath)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>
<Compile Include="**\*.cs" Exclude="bin\**;obj\**;**\*.xproj;packages\**" /> <Compile Include="**\*.cs" Exclude="bin\**;obj\**;**\*.xproj;packages\**" />

9
src/Microsoft.DotNet.ProjectJsonMigration/Rules/MigrateBuildOptionsRule.cs
View file

@ -96,13 +96,7 @@ namespace Microsoft.DotNet.ProjectJsonMigration.Rules
private AddPropertyTransform<CommonCompilerOptions> XmlDocTransform => private AddPropertyTransform<CommonCompilerOptions> XmlDocTransform =>
new AddPropertyTransform<CommonCompilerOptions>("GenerateDocumentationFile", new AddPropertyTransform<CommonCompilerOptions>("GenerateDocumentationFile",
compilerOptions => compilerOptions.GenerateXmlDocumentation.ToString().ToLower(), compilerOptions => compilerOptions.GenerateXmlDocumentation.ToString().ToLower(),
compilerOptions => compilerOptions.GenerateXmlDocumentation != null && compilerOptions.GenerateXmlDocumentation.Value); compilerOptions => compilerOptions.GenerateXmlDocumentation != null && compilerOptions.GenerateXmlDocumentation.Value);
// TODO: https://github.com/dotnet/sdk/issues/67
private AddPropertyTransform<CommonCompilerOptions> XmlDocTransformFilePath =>
new AddPropertyTransform<CommonCompilerOptions>("DocumentationFile",
@"$(OutputPath)\$(TargetFramework)\$(AssemblyName).xml",
compilerOptions => compilerOptions.GenerateXmlDocumentation != null && compilerOptions.GenerateXmlDocumentation.Value);
private AddPropertyTransform<CommonCompilerOptions> AssemblyNameTransform => private AddPropertyTransform<CommonCompilerOptions> AssemblyNameTransform =>
new AddPropertyTransform<CommonCompilerOptions>("AssemblyName", new AddPropertyTransform<CommonCompilerOptions>("AssemblyName",
@ -177,7 +171,6 @@ namespace Microsoft.DotNet.ProjectJsonMigration.Rules
PublicSignTransform, PublicSignTransform,
DebugTypeTransform, DebugTypeTransform,
XmlDocTransform, XmlDocTransform,
XmlDocTransformFilePath,
PreserveCompilationContextTransform, PreserveCompilationContextTransform,
AssemblyNameTransform AssemblyNameTransform
}; };