mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Merge pull request #2076 from enricosada/tell_fsc_about_portablepdb

Browse source 
compile-fsc, support debugType and fix
This commit is contained in:
Piotr Puszkiewicz 2016-03-25 19:19:24 -07:00
commit d4d49ae0e3
1 changed files with 18 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

24
src/dotnet/commands/dotnet-compile-fsc/Program.cs
View file

@ -104,20 +104,32 @@ namespace Microsoft.DotNet.Tools.Compiler.Fsc
allArgs.Add($"--out:{outputName}"); allArgs.Add($"--out:{outputName}");
} }
//debug info (only windows pdb supported, not portablepdb) //let's pass debugging type only if options.DebugType is specified, until
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) //portablepdb are confirmed to work.
//so it's possibile to test portable pdb without breaking existing build
if (string.IsNullOrEmpty(commonOptions.DebugType))
{ {
allArgs.Add("--debug"); //debug info (only windows pdb supported, not portablepdb)
//TODO check if full or pdbonly if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
allArgs.Add("--debug:pdbonly"); {
allArgs.Add("--debug");
//TODO check if full or pdbonly
allArgs.Add("--debug:pdbonly");
}
else
allArgs.Add("--debug-");
} }
else else
allArgs.Add("--debug-"); {
allArgs.Add("--debug");
allArgs.Add($"--debug:{commonOptions.DebugType}");
}
// Default options // Default options
allArgs.Add("--noframework"); allArgs.Add("--noframework");
allArgs.Add("--nologo"); allArgs.Add("--nologo");
allArgs.Add("--simpleresolution"); allArgs.Add("--simpleresolution");
allArgs.Add("--nocopyfsharpcore");
// project.json compilationOptions // project.json compilationOptions
if (commonOptions.Defines != null) if (commonOptions.Defines != null)