mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Changes to fix publish tests

Browse source
This commit is contained in:
Bryan Thornbury 2016-01-22 03:59:04 -08:00
parent 9c5e520285
commit d1d23944df
12 changed files with 124 additions and 140 deletions
Download patch file Download diff file Expand all files Collapse all files

126
src/Microsoft.DotNet.Cli.Utils/ArgumentEscaper.cs
View file

@ -20,30 +20,9 @@ namespace Microsoft.DotNet.Cli.Utils
/// </summary> /// </summary>
/// <param name="args"></param> /// <param name="args"></param>
/// <returns></returns> /// <returns></returns>
public static string EscapeAndConcatenateArgArray(IEnumerable<string> args, bool cmd=false) public static string EscapeAndConcatenateArgArray(IEnumerable<string> args)
{ {
var sb = new StringBuilder(); return string.Join(" ", EscapeArgArray(args));
var first = false;
foreach (var arg in args)
{
if (first)
{
first = false;
}
else
{
sb.Append(' ');
}
sb.Append(EscapeArg(arg, cmd));
}
return sb.ToString();
}
public static string EscapeAndConcatenateArgArrayForBash(IEnumerable<string> args)
{
return EscapeAndConcatenateArgArray(EscapeArgArrayForBash(args));
} }
/// <summary> /// <summary>
@ -57,7 +36,7 @@ namespace Microsoft.DotNet.Cli.Utils
/// <returns></returns> /// <returns></returns>
public static string EscapeAndConcatenateArgArrayForCmd(IEnumerable<string> args) public static string EscapeAndConcatenateArgArrayForCmd(IEnumerable<string> args)
{ {
return EscapeAndConcatenateArgArray(EscapeArgArrayForCmd(args), true); return string.Join(" ", EscapeArgArrayForCmd(args));
} }
/// <summary> /// <summary>
@ -81,18 +60,6 @@ namespace Microsoft.DotNet.Cli.Utils
return escapedArgs; return escapedArgs;
} }
public static IEnumerable<string> EscapeArgArrayForBash(IEnumerable<string> arguments)
{
var escapedArgs = new List<string>();
foreach (var arg in arguments)
{
escapedArgs.Add(EscapeArgForBash(arg));
}
return escapedArgs;
}
/// <summary> /// <summary>
/// This prefixes every character with the '^' character to force cmd to /// This prefixes every character with the '^' character to force cmd to
/// interpret the argument string literally. An alternative option would /// interpret the argument string literally. An alternative option would
@ -115,16 +82,13 @@ namespace Microsoft.DotNet.Cli.Utils
return escapedArgs; return escapedArgs;
} }
private static string EscapeArg(string arg, bool cmd=false) private static string EscapeArg(string arg)
{ {
var sb = new StringBuilder(); var sb = new StringBuilder();
// Always quote beginning and end to account for possible spaces var quoted = ShouldSurroundWithQuotes(arg);
if (cmd) sb.Append('^'); if (quoted) sb.Append("\"");
sb.Append('"');
if (!cmd)
{
for (int i = 0; i < arg.Length; ++i) for (int i = 0; i < arg.Length; ++i)
{ {
var backslashCount = 0; var backslashCount = 0;
@ -158,35 +122,12 @@ namespace Microsoft.DotNet.Cli.Utils
sb.Append(arg[i]); sb.Append(arg[i]);
} }
} }
}
else
{
for (int i = 0; i < arg.Length; ++i)
{
if (arg[i] == '"')
{
sb.Append('"');
sb.Append('^');
sb.Append(arg[i]);
}
else
{
sb.Append(arg[i]);
}
}
}
if (cmd) sb.Append('^'); if (quoted) sb.Append("\"");
sb.Append('"');
return sb.ToString(); return sb.ToString();
} }
private static string EscapeArgForBash(string arguments)
{
throw new NotImplementedException();
}
/// <summary> /// <summary>
/// Prepare as single argument to /// Prepare as single argument to
/// roundtrip properly through cmd. /// roundtrip properly through cmd.
@ -200,17 +141,66 @@ namespace Microsoft.DotNet.Cli.Utils
/// </summary> /// </summary>
/// <param name="args"></param> /// <param name="args"></param>
/// <returns></returns> /// <returns></returns>
private static string EscapeArgForCmd(string arguments) private static string EscapeArgForCmd(string argument)
{ {
var sb = new StringBuilder(); var sb = new StringBuilder();
foreach (var character in arguments) var quoted = ShouldSurroundWithQuotes(argument);
if (quoted) sb.Append("^\"");
foreach (var character in argument)
{ {
if (character == '"')
{
sb.Append('^');
sb.Append('"');
sb.Append('^'); sb.Append('^');
sb.Append(character); sb.Append(character);
} }
else
{
sb.Append("^");
sb.Append(character);
}
}
if (quoted) sb.Append("^\"");
return sb.ToString(); return sb.ToString();
} }
/// <summary>
/// Prepare as single argument to
/// roundtrip properly through cmd.
///
/// This prefixes every character with the '^' character to force cmd to
/// interpret the argument string literally. An alternative option would
/// be to do this only for cmd metacharacters.
///
/// See here for more info:
/// http://blogs.msdn.com/b/twistylittlepassagesallalike/archive/2011/04/23/everyone-quotes-arguments-the-wrong-way.aspx
/// </summary>
/// <param name="args"></param>
/// <returns></returns>
internal static bool ShouldSurroundWithQuotes(string argument)
{
// Don't quote already quoted strings
if (argument.StartsWith("\"", StringComparison.Ordinal) &&
argument.EndsWith("\"", StringComparison.Ordinal))
{
return false;
}
// Only quote if whitespace exists in the string
if (argument.Contains(" ") || argument.Contains("\t") || argument.Contains("\n"))
{
return true;
}
return true;
}
} }
} }

15
src/Microsoft.DotNet.Cli.Utils/CommandResolver.cs
View file

@ -24,7 +24,6 @@ namespace Microsoft.DotNet.Cli.Utils
private static CommandSpec ResolveFromPath(string commandName, IEnumerable<string> args, bool useComSpec = false) private static CommandSpec ResolveFromPath(string commandName, IEnumerable<string> args, bool useComSpec = false)
{ {
var commandPath = Env.GetCommandPath(commandName); var commandPath = Env.GetCommandPath(commandName);
if (commandPath != null) Console.WriteLine("path?");
return commandPath == null return commandPath == null
? null ? null
: CreateCommandSpecPreferringExe(commandName, args, commandPath, CommandResolutionStrategy.Path, useComSpec); : CreateCommandSpecPreferringExe(commandName, args, commandPath, CommandResolutionStrategy.Path, useComSpec);
@ -33,7 +32,6 @@ namespace Microsoft.DotNet.Cli.Utils
private static CommandSpec ResolveFromAppBase(string commandName, IEnumerable<string> args, bool useComSpec = false) private static CommandSpec ResolveFromAppBase(string commandName, IEnumerable<string> args, bool useComSpec = false)
{ {
var commandPath = Env.GetCommandPathFromAppBase(AppContext.BaseDirectory, commandName); var commandPath = Env.GetCommandPathFromAppBase(AppContext.BaseDirectory, commandName);
if (commandPath != null) Console.WriteLine("appbase?");
return commandPath == null return commandPath == null
? null ? null
: CreateCommandSpecPreferringExe(commandName, args, commandPath, CommandResolutionStrategy.BaseDirectory, useComSpec); : CreateCommandSpecPreferringExe(commandName, args, commandPath, CommandResolutionStrategy.BaseDirectory, useComSpec);
@ -43,8 +41,6 @@ namespace Microsoft.DotNet.Cli.Utils
{ {
if (Path.IsPathRooted(commandName)) if (Path.IsPathRooted(commandName))
{ {
Console.WriteLine("rooted?");
if (useComSpec) if (useComSpec)
{ {
return CreateComSpecCommandSpec(commandName, args, CommandResolutionStrategy.Path); return CreateComSpecCommandSpec(commandName, args, CommandResolutionStrategy.Path);
@ -196,8 +192,6 @@ namespace Microsoft.DotNet.Cli.Utils
fileName = Path.Combine(packageDir, commandPath); fileName = Path.Combine(packageDir, commandPath);
} }
if (useComSpec) if (useComSpec)
{ {
return CreateComSpecCommandSpec(fileName, args, CommandResolutionStrategy.NugetPackage); return CreateComSpecCommandSpec(fileName, args, CommandResolutionStrategy.NugetPackage);
@ -256,7 +250,6 @@ namespace Microsoft.DotNet.Cli.Utils
IEnumerable<string> args, IEnumerable<string> args,
CommandResolutionStrategy resolutionStrategy) CommandResolutionStrategy resolutionStrategy)
{ {
// To prevent Command Not Found, comspec gets passed in as // To prevent Command Not Found, comspec gets passed in as
// the command already in some cases // the command already in some cases
var comSpec = Environment.GetEnvironmentVariable("ComSpec"); var comSpec = Environment.GetEnvironmentVariable("ComSpec");
@ -266,7 +259,13 @@ namespace Microsoft.DotNet.Cli.Utils
args = args.Skip(1); args = args.Skip(1);
} }
var cmdEscapedArgs = ArgumentEscaper.EscapeAndConcatenateArgArrayForCmd(args); var cmdEscapedArgs = ArgumentEscaper.EscapeAndConcatenateArgArrayForCmd(args);
var escapedArgString = $"/s /c \"\"{command}\" {cmdEscapedArgs}\"";
if (ArgumentEscaper.ShouldSurroundWithQuotes(command))
{
command = $"\"{command}\"";
}
var escapedArgString = $"/s /c \"{command} {cmdEscapedArgs}\"";
return new CommandSpec(comSpec, escapedArgString, resolutionStrategy); return new CommandSpec(comSpec, escapedArgString, resolutionStrategy);
} }

22
src/Microsoft.DotNet.Cli.Utils/ScriptExecutor.cs
View file

@ -22,7 +22,7 @@ namespace Microsoft.DotNet.Cli.Utils
var scriptArguments = CommandGrammar.Process( var scriptArguments = CommandGrammar.Process(
scriptCommandLine, scriptCommandLine,
GetScriptVariable(project, getVariable), GetScriptVariable(project, getVariable),
preserveSurroundingQuotes: false); preserveSurroundingQuotes: true);
// Ensure the array won't be empty and the elements won't be null or empty strings. // Ensure the array won't be empty and the elements won't be null or empty strings.
scriptArguments = scriptArguments.Where(argument => !string.IsNullOrEmpty(argument)).ToArray(); scriptArguments = scriptArguments.Where(argument => !string.IsNullOrEmpty(argument)).ToArray();
@ -59,12 +59,14 @@ namespace Microsoft.DotNet.Cli.Utils
else else
{ {
// Special-case a script name that, perhaps with added .sh, matches an existing file. // Special-case a script name that, perhaps with added .sh, matches an existing file.
var surroundWithQuotes = false;
var scriptCandidate = scriptArguments[0]; var scriptCandidate = scriptArguments[0];
if (scriptCandidate.StartsWith("\"", StringComparison.Ordinal) && if (scriptCandidate.StartsWith("\"", StringComparison.Ordinal) &&
scriptCandidate.EndsWith("\"", StringComparison.Ordinal)) scriptCandidate.EndsWith("\"", StringComparison.Ordinal))
{ {
// Strip surrounding quotes; they were required in project.json to keep the script name // Strip surrounding quotes; they were required in project.json to keep the script name
// together but confuse File.Exists() e.g. "My Script", lacking ./ prefix and .sh suffix. // together but confuse File.Exists() e.g. "My Script", lacking ./ prefix and .sh suffix.
surroundWithQuotes = true;
scriptCandidate = scriptCandidate.Substring(1, scriptCandidate.Length - 2); scriptCandidate = scriptCandidate.Substring(1, scriptCandidate.Length - 2);
} }
@ -78,22 +80,16 @@ namespace Microsoft.DotNet.Cli.Utils
// scriptCandidate may be a path relative to the project root. If so, likely will not be found // scriptCandidate may be a path relative to the project root. If so, likely will not be found
// in the $PATH; add ./ to let bash know where to look. // in the $PATH; add ./ to let bash know where to look.
var prefix = Path.IsPathRooted(scriptCandidate) ? string.Empty : "./"; var prefix = Path.IsPathRooted(scriptCandidate) ? string.Empty : "./";
scriptArguments[0] = $"{prefix}{scriptCandidate}"; var quote = surroundWithQuotes ? "\"" : string.Empty;
scriptArguments[0] = $"{ quote }{ prefix }{ scriptCandidate }{ quote }";
} }
// Always use /usr/bin/env bash -c in order to support redirection and so on; similar to Windows case. // Always use /usr/bin/env bash -c in order to support redirection and so on; similar to Windows case.
// Unlike Windows, must escape quotation marks within the newly-quoted string. // Unlike Windows, must escape quotation marks within the newly-quoted string.
scriptArguments = new[] { "/usr/bin/env", "bash", "-c", "\"" }
// TODO change this back to original, not doing anything special for bash .Concat(scriptArguments.Select(argument => argument.Replace("\"", "\\\"")))
var bashArgs = ArgumentEscaper.EscapeArgArrayForBash(scriptArguments); .Concat(new[] { "\"" })
.ToArray();
List<string> concatenatedArgs = new List<string>();
concatenatedArgs.Add("/usr/bin/env");
concatenatedArgs.Add("bash");
concatenatedArgs.Add("-c");
concatenatedArgs.AddRange(bashArgs);
scriptArguments = concatenatedArgs.ToArray();
} }
return Command.Create(scriptArguments.FirstOrDefault(), scriptArguments.Skip(1), useComSpec: useComSpec) return Command.Create(scriptArguments.FirstOrDefault(), scriptArguments.Skip(1), useComSpec: useComSpec)

2
src/Microsoft.DotNet.Compiler.Common/AssemblyInfoFileGenerator.cs
View file

@ -22,7 +22,7 @@ namespace Microsoft.DotNet.Cli.Compiler.Common
var existingAttributes = new List<Type>(); var existingAttributes = new List<Type>();
foreach (var sourceFile in sourceFiles) foreach (var sourceFile in sourceFiles)
{ {
var tree = CSharpSyntaxTree.ParseText(File.ReadAllText(sourceFile)); var tree = CSharpSyntaxTree.ParseText(File.ReadAllText(sourceFile.Trim('"')));
var root = tree.GetRoot(); var root = tree.GetRoot();
// assembly attributes can be only on first level // assembly attributes can be only on first level

2
src/Microsoft.DotNet.Tools.Builder/CompileContext.cs
View file

@ -125,7 +125,7 @@ namespace Microsoft.DotNet.Tools.Build
if (!newInputs.Any()) if (!newInputs.Any())
{ {
Reporter.Output.WriteLine($"\nProject {project.ProjectName()} was previoulsy compiled. Skipping compilation."); Reporter.Output.WriteLine($"\nProject {project.ProjectName()} was previously compiled. Skipping compilation.");
return false; return false;
} }

12
src/Microsoft.DotNet.Tools.Compiler.Csc/Program.cs
View file

@ -79,26 +79,28 @@ namespace Microsoft.DotNet.Tools.Compiler.Csc
return returnCode; return returnCode;
} }
var translated = TranslateCommonOptions(commonOptions, outputName); var translated = TranslateCommonOptions(commonOptions, outputName.Trim('"'));
var allArgs = new List<string>(translated); var allArgs = new List<string>(translated);
allArgs.AddRange(GetDefaultOptions()); allArgs.AddRange(GetDefaultOptions());
// Generate assembly info // Generate assembly info
var assemblyInfo = Path.Combine(tempOutDir, $"dotnet-compile.assemblyinfo.cs"); var tempOutputStrippedSpaces = tempOutDir.Trim('"');
var assemblyInfo = Path.Combine(tempOutputStrippedSpaces, $"dotnet-compile.assemblyinfo.cs");
File.WriteAllText(assemblyInfo, AssemblyInfoFileGenerator.Generate(assemblyInfoOptions, sources)); File.WriteAllText(assemblyInfo, AssemblyInfoFileGenerator.Generate(assemblyInfoOptions, sources));
allArgs.Add($"\"{assemblyInfo}\""); allArgs.Add($"\"{assemblyInfo}\"");
if (outputName != null) if (outputName != null)
{ {
allArgs.Add($"-out:\"{outputName}\""); allArgs.Add($"-out:\"{outputName.Trim('"')}\"");
} }
allArgs.AddRange(references.Select(r => $"-r:\"{r.Trim('"')}\"")); allArgs.AddRange(references.Select(r => $"-r:\"{r.Trim('"')}\""));
allArgs.AddRange(resources.Select(resource => $"-resource:{resource.Trim('"')}")); allArgs.AddRange(resources.Select(resource => $"-resource:{resource.Trim('"')}"));
allArgs.AddRange(sources.Select(s => $"\"{s.Trim('"')}\"")); allArgs.AddRange(sources.Select(s => $"\"{s.Trim('"')}\""));
var rsp = Path.Combine(tempOutDir, "dotnet-compile-csc.rsp"); var rsp = Path.Combine(tempOutputStrippedSpaces, "dotnet-compile-csc.rsp");
File.WriteAllLines(rsp, allArgs, Encoding.UTF8); File.WriteAllLines(rsp, allArgs, Encoding.UTF8);
@ -192,7 +194,7 @@ namespace Microsoft.DotNet.Tools.Compiler.Csc
if (options.GenerateXmlDocumentation == true) if (options.GenerateXmlDocumentation == true)
{ {
commonArgs.Add($"-doc:{Path.ChangeExtension(outputName, "xml")}"); commonArgs.Add($"-doc:\"{Path.ChangeExtension(outputName.Trim('"'), "xml")}\"");
} }
if (options.EmitEntryPoint != true) if (options.EmitEntryPoint != true)

10
src/Microsoft.DotNet.Tools.Compiler/Program.cs
View file

@ -207,8 +207,8 @@ namespace Microsoft.DotNet.Tools.Compiler
// Assemble args // Assemble args
var compilerArgs = new List<string>() var compilerArgs = new List<string>()
{ {
$"--temp-output:{intermediateOutputPath}", $"--temp-output:\"{intermediateOutputPath}\"",
$"--out:{outputName}" $"--out:\"{outputName}\""
}; };
var compilationOptions = CompilerUtil.ResolveCompilationOptions(context, args.ConfigValue); var compilationOptions = CompilerUtil.ResolveCompilationOptions(context, args.ConfigValue);
@ -258,7 +258,7 @@ namespace Microsoft.DotNet.Tools.Compiler
writer.Write(dependencyContext, fileStream); writer.Write(dependencyContext, fileStream);
} }
compilerArgs.Add($"--resource:\"{depsJsonFile}\",{context.ProjectFile.Name}.deps.json"); compilerArgs.Add($"--resource:\"{depsJsonFile},{context.ProjectFile.Name}.deps.json\"");
var refsFolder = Path.Combine(outputPath, "refs"); var refsFolder = Path.Combine(outputPath, "refs");
if (Directory.Exists(refsFolder)) if (Directory.Exists(refsFolder))
@ -440,11 +440,11 @@ namespace Microsoft.DotNet.Tools.Compiler
return false; return false;
} }
compilerArgs.Add($"--resource:\"{resgenFile.OutputFile}\",{Path.GetFileName(resgenFile.MetadataName)}"); compilerArgs.Add($"--resource:\"{resgenFile.OutputFile},{Path.GetFileName(resgenFile.MetadataName)}\"");
} }
else else
{ {
compilerArgs.Add($"--resource:\"{resgenFile.InputFile}\",{Path.GetFileName(resgenFile.MetadataName)}"); compilerArgs.Add($"--resource:\"{resgenFile.InputFile},{Path.GetFileName(resgenFile.MetadataName)}\"");
} }
} }

2
src/Microsoft.Extensions.Testing.Abstractions/project.json
View file

@ -12,7 +12,7 @@
"dependencies": { "dependencies": {
"Newtonsoft.Json": "7.0.1", "Newtonsoft.Json": "7.0.1",
"Microsoft.DotNet.ProjectModel": "1.0.0-*", "Microsoft.DotNet.ProjectModel": "1.0.0-*",
"Microsoft.Extensions.Logging.Abstractions": "1.0.0-rc2-16023", "Microsoft.Extensions.Logging.Abstractions": "1.0.0-rc2-16011",
"NETStandard.Library": "1.0.0-rc2-23704", "NETStandard.Library": "1.0.0-rc2-23704",
"System.Resources.ResourceManager": "4.0.1-rc2-23704", "System.Resources.ResourceManager": "4.0.1-rc2-23704",
"System.Runtime.Serialization.Primitives": "4.1.0-rc2-23704" "System.Runtime.Serialization.Primitives": "4.1.0-rc2-23704"

6
test/FSharpTestProjects/CompileFail/project.json
View file

@ -9,9 +9,9 @@
], ],
"dependencies": { "dependencies": {
"Microsoft.FSharp.Core.netcore": "1.0.0-alpha-151221", "Microsoft.FSharp.Core.netcore": "1.0.0-alpha-151221",
"Microsoft.NETCore.ConsoleHost": "1.0.0-23428", "Microsoft.NETCore.ConsoleHost": "1.0.0-rc2-23704",
"Microsoft.NETCore.Runtime": "1.0.1-23428", "Microsoft.NETCore.Runtime": "1.0.1-rc2-23704",
"System.Console": "4.0.0-beta-23109" "System.Console": "4.0.0-rc2-23704"
}, },
"frameworks": { "frameworks": {

2
test/Microsoft.DotNet.Tools.Builder.Tests/IncrementalTestBase.cs
View file

@ -75,7 +75,7 @@ namespace Microsoft.DotNet.Tools.Builder.Tests
protected static void AssertProjectSkipped(string skippedProject, CommandResult buildResult) protected static void AssertProjectSkipped(string skippedProject, CommandResult buildResult)
{ {
Assert.Contains($"Project {skippedProject} was previoulsy compiled. Skipping compilation.", buildResult.StdOut, StringComparison.OrdinalIgnoreCase); Assert.Contains($"Project {skippedProject} was previously compiled. Skipping compilation.", buildResult.StdOut, StringComparison.OrdinalIgnoreCase);
} }
protected static void AssertProjectCompiled(string rebuiltProject, CommandResult buildResult) protected static void AssertProjectCompiled(string rebuiltProject, CommandResult buildResult)

3
test/Microsoft.DotNet.Tools.Tests.Utilities/Commands/TestCommand.cs
View file

@ -45,9 +45,6 @@ namespace Microsoft.DotNet.Tools.Test.Utilities
var commandPath = Env.GetCommandPath(_command, ".exe", ".cmd", "") ?? var commandPath = Env.GetCommandPath(_command, ".exe", ".cmd", "") ??
Env.GetCommandPathFromAppBase(AppContext.BaseDirectory, _command, ".exe", ".cmd", ""); Env.GetCommandPathFromAppBase(AppContext.BaseDirectory, _command, ".exe", ".cmd", "");
Console.Write("command");
Console.WriteLine(commandPath);
var stdOut = new StreamForwarder(); var stdOut = new StreamForwarder();
var stdErr = new StreamForwarder(); var stdErr = new StreamForwarder();

2
test/TestProjects/TestApp/project.json
View file

@ -5,7 +5,7 @@
}, },
"dependencies": { "dependencies": {
"TestLibrary": "1.0.0-*", "TestLibrary": { "target":"project"},
"NETStandard.Library": "1.0.0-rc2-23704", "NETStandard.Library": "1.0.0-rc2-23704",
"Microsoft.NETCore.Platforms": "1.0.1-rc2-23704" "Microsoft.NETCore.Platforms": "1.0.1-rc2-23704"