mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Use ProductMonikerRid instead of CoreSetupRid for SDK RID.

Browse source 
This commit changes `NETCoreSdkRuntimeIdentifier` to be based off of
`ProductMonikerRid` instead of `CoreSetupRid`.

`CoreSetupRid` is set to the host RID for the build, by default.  For most
architectures, this was fine.  However, for ARM/ARM64 builds, we cross-build,
so `CoreSetupRid` is actually x64 and not ARM/ARM64.

As a result, the default apphost being used isn't built for ARM so `dotnet run`
fails with an exec format error when trying to exec the apphost.

Instead, we should be using the RID of the product being built rather than the
host RID.

Fixes dotnet/cli#10291.
This commit is contained in:
Peter Huene 2018-11-07 16:35:27 -08:00
parent d273cdc5af
commit d07a78532c
No known key found for this signature in database
GPG key ID: E1D265D820213D6A
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
build/MSBuildExtensions.targets
View file

@ -135,7 +135,7 @@ Copyright (c) .NET Foundation. All rights reserved.
<BundledNETCorePlatformsPackageVersion>$(_NETCorePlatformsPackageVersion)</BundledNETCorePlatformsPackageVersion>
@(BundledVersionsVariable->'<%(Identity)>%(Value)</%(Identity)>', '%0A ')
<NETCoreSdkVersion>$(SdkVersion)</NETCoreSdkVersion>
<NETCoreSdkRuntimeIdentifier>$(CoreSetupRid)</NETCoreSdkRuntimeIdentifier>
<NETCoreSdkRuntimeIdentifier>$(ProductMonikerRid)</NETCoreSdkRuntimeIdentifier>
<_NETCoreSdkIsPreview>$(_NETCoreSdkIsPreview)</_NETCoreSdkIsPreview>
<AddDotnetfeedProjectSource Condition="'%24(AddDotnetfeedProjectSource)' == ''">%24(_NETCoreSdkIsPreview)</AddDotnetfeedProjectSource>