mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merged PR 128266: Change the implicit asp.net core version for FDD apps to be pinned as 2.1.1.

Browse source 
Change the implicit asp.net core version for FDD apps to be pinned as 2.1.1.
This commit is contained in:
Livar Cunha 2018-06-15 17:46:15 +00:00
commit cfc9d947b4
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
test/EndToEnd/GivenAspNetAppsResolveImplicitVersions.cs
View file

@ -16,8 +16,10 @@ namespace EndToEnd
{ {
private const string AspNetTestProject = "TestWebAppSimple"; private const string AspNetTestProject = "TestWebAppSimple";
private const string PinnedAspNetCoreImplicitVersion = "2.1.1";
[Fact] [Fact]
public void PortablePublishWithLatestTFMUsesBundledAspNetCoreAppVersion() public void PortablePublishWithLatestTFMUsesPinnedDownAspNetCoreAppVersion()
{ {
var _testInstance = TestAssets.Get(AspNetTestProject) var _testInstance = TestAssets.Get(AspNetTestProject)
.CreateInstance(identifier: LatestSupportedAspNetCoreAppVersion) .CreateInstance(identifier: LatestSupportedAspNetCoreAppVersion)
@ -48,10 +50,7 @@ namespace EndToEnd
var restoredVersion = GetAspNetCoreAppVersion(assetsFile, portable: true); var restoredVersion = GetAspNetCoreAppVersion(assetsFile, portable: true);
restoredVersion.Should().NotBeNull(); restoredVersion.Should().NotBeNull();
var bundledVersionPath = Path.Combine(projectDirectory, ".BundledAspNetCoreVersion"); restoredVersion.ToNormalizedString().Should().BeEquivalentTo(PinnedAspNetCoreImplicitVersion,
var bundledVersion = File.ReadAllText(bundledVersionPath).Trim();
restoredVersion.ToNormalizedString().Should().BeEquivalentTo(bundledVersion,
"The bundled aspnetcore versions set in Microsoft.NETCoreSdk.BundledVersions.props should be idenitical to the versions set in DependencyVersions.props." + "The bundled aspnetcore versions set in Microsoft.NETCoreSdk.BundledVersions.props should be idenitical to the versions set in DependencyVersions.props." +
"Please update MSBuildExtensions.targets in this repo so these versions match."); "Please update MSBuildExtensions.targets in this repo so these versions match.");
} }