mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

PR Feedback: match coding guidelines

Browse source
This commit is contained in:
Bryan 2015-12-16 14:10:39 -08:00
parent 3b848c0487
commit c7b14fcdc0
3 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tools/MultiProjectValidator/AnalysisResult.cs
View file

@ -10,8 +10,8 @@ namespace MultiProjectValidator
public AnalysisResult(List<string> messages, bool passed) public AnalysisResult(List<string> messages, bool passed)
{ {
this._messages = messages; _messages = messages;
this._passed = passed; _passed = passed;
} }
public List<string> Messages public List<string> Messages

3
tools/MultiProjectValidator/Program.cs
View file

@ -114,6 +114,9 @@ This tool recursively searches for project.json's from the given root path.
It then applies a set of analysis rules, determines whether they pass/fail It then applies a set of analysis rules, determines whether they pass/fail
and then sets exit code to reflect. and then sets exit code to reflect.
Note:
Ensure all analyzed project.json have been restored prior to running this tool.
Usage: Usage:
pjvalidate [root path of recursive search]"; pjvalidate [root path of recursive search]";

12
tools/MultiProjectValidator/ProjectAnalyzer.cs
View file

@ -18,22 +18,22 @@ namespace MultiProjectValidator
return new ProjectAnalyzer(rules, projectContexts); return new ProjectAnalyzer(rules, projectContexts);
} }
private List<ProjectContext> projectContexts; private List<ProjectContext> _projectContexts;
private List<IAnalysisRule> rules; private List<IAnalysisRule> _rules;
private ProjectAnalyzer(List<IAnalysisRule> rules, List<ProjectContext> projectContexts) private ProjectAnalyzer(List<IAnalysisRule> rules, List<ProjectContext> projectContexts)
{ {
this.rules = rules; _rules = rules;
this.projectContexts = projectContexts; _projectContexts = projectContexts;
} }
public List<AnalysisResult> DoAnalysis() public List<AnalysisResult> DoAnalysis()
{ {
var results = new List<AnalysisResult>(); var results = new List<AnalysisResult>();
foreach(var rule in rules) foreach(var rule in _rules)
{ {
results.Add(rule.Evaluate(projectContexts)); results.Add(rule.Evaluate(_projectContexts));
} }
return results; return results;