PR Feedback: match coding guidelines

This commit is contained in:
Bryan 2015-12-16 14:10:39 -08:00
parent 3b848c0487
commit c7b14fcdc0
3 changed files with 11 additions and 8 deletions

View file

@ -10,8 +10,8 @@ namespace MultiProjectValidator
public AnalysisResult(List<string> messages, bool passed)
{
this._messages = messages;
this._passed = passed;
_messages = messages;
_passed = passed;
}
public List<string> Messages

View file

@ -114,6 +114,9 @@ This tool recursively searches for project.json's from the given root path.
It then applies a set of analysis rules, determines whether they pass/fail
and then sets exit code to reflect.
Note:
Ensure all analyzed project.json have been restored prior to running this tool.
Usage:
pjvalidate [root path of recursive search]";

View file

@ -18,22 +18,22 @@ namespace MultiProjectValidator
return new ProjectAnalyzer(rules, projectContexts);
}
private List<ProjectContext> projectContexts;
private List<IAnalysisRule> rules;
private List<ProjectContext> _projectContexts;
private List<IAnalysisRule> _rules;
private ProjectAnalyzer(List<IAnalysisRule> rules, List<ProjectContext> projectContexts)
{
this.rules = rules;
this.projectContexts = projectContexts;
_rules = rules;
_projectContexts = projectContexts;
}
public List<AnalysisResult> DoAnalysis()
{
var results = new List<AnalysisResult>();
foreach(var rule in rules)
foreach(var rule in _rules)
{
results.Add(rule.Evaluate(projectContexts));
results.Add(rule.Evaluate(_projectContexts));
}
return results;