From 84ea85192bb26fefe33648e5aba912f6828f912c Mon Sep 17 00:00:00 2001 From: Marc Paine Date: Fri, 26 Jan 2024 11:46:10 -0800 Subject: [PATCH 1/4] Separate out the test exclusions that apply to stable SDKs when we're targeting the latest downlevel runtime. This should simplify things as we want to run these tests at least some of the time but codeflow ends up removing them. --- test/SdkTests/SdkTests.csproj | 6 +- test/SdkTests/TestConfig.xml | 200 -------------------------- test/SdkTests/TestConfigStableSDK.xml | 200 ++++++++++++++++++++++++++ 3 files changed, 205 insertions(+), 201 deletions(-) create mode 100644 test/SdkTests/TestConfigStableSDK.xml diff --git a/test/SdkTests/SdkTests.csproj b/test/SdkTests/SdkTests.csproj index 8902bb1a6..dd8620df0 100644 --- a/test/SdkTests/SdkTests.csproj +++ b/test/SdkTests/SdkTests.csproj @@ -1,4 +1,4 @@ - + false @@ -215,6 +215,10 @@ $(TestArgs) -testList SdkIntegrationTests + + + $(TestArgs) -testConfigFile "$(MSBuildThisFileDirectory)TestsToSkipStableSDK.xml" + diff --git a/test/SdkTests/TestConfig.xml b/test/SdkTests/TestConfig.xml index 245dd40e7..9b38840fd 100644 --- a/test/SdkTests/TestConfig.xml +++ b/test/SdkTests/TestConfig.xml @@ -45,10 +45,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/test/SdkTests/TestConfigStableSDK.xml b/test/SdkTests/TestConfigStableSDK.xml new file mode 100644 index 000000000..7140b5f76 --- /dev/null +++ b/test/SdkTests/TestConfigStableSDK.xml @@ -0,0 +1,200 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + From 8a35ac3fbb2bf53da560d2266a368fe2b6c2ee2c Mon Sep 17 00:00:00 2001 From: Marc Paine Date: Fri, 26 Jan 2024 15:00:03 -0800 Subject: [PATCH 2/4] Rename the XML file Add a specific test back to the exclusion list Move two tests to the linux-only exclusion list --- test/SdkTests/TestConfig.xml | 4 ++++ .../{TestConfigStableSDK.xml => TestToSkipStableSDK.xml} | 8 -------- test/SdkTests/TestsToSkipLinux.xml | 8 ++++++++ 3 files changed, 12 insertions(+), 8 deletions(-) rename test/SdkTests/{TestConfigStableSDK.xml => TestToSkipStableSDK.xml} (96%) diff --git a/test/SdkTests/TestConfig.xml b/test/SdkTests/TestConfig.xml index 9b38840fd..f5b3aa523 100644 --- a/test/SdkTests/TestConfig.xml +++ b/test/SdkTests/TestConfig.xml @@ -61,5 +61,9 @@ Skip="true" Issue="" Reason="Requires props file not in installer repo"/> + diff --git a/test/SdkTests/TestConfigStableSDK.xml b/test/SdkTests/TestToSkipStableSDK.xml similarity index 96% rename from test/SdkTests/TestConfigStableSDK.xml rename to test/SdkTests/TestToSkipStableSDK.xml index 7140b5f76..d1138b370 100644 --- a/test/SdkTests/TestConfigStableSDK.xml +++ b/test/SdkTests/TestToSkipStableSDK.xml @@ -4,10 +4,6 @@ Skip="true" Issue="" Reason="Cannot run with non-existent LastRuntimeFrameworkVersion"/> - - + + From 6409fc11b827f5cfb2ac6e058cfce8d252591b0f Mon Sep 17 00:00:00 2001 From: Marc Paine Date: Tue, 30 Jan 2024 17:11:10 -0800 Subject: [PATCH 3/4] Fix the file rename --- .../{TestToSkipStableSDK.xml => TestsToSkipStableSDK.xml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename test/SdkTests/{TestToSkipStableSDK.xml => TestsToSkipStableSDK.xml} (100%) diff --git a/test/SdkTests/TestToSkipStableSDK.xml b/test/SdkTests/TestsToSkipStableSDK.xml similarity index 100% rename from test/SdkTests/TestToSkipStableSDK.xml rename to test/SdkTests/TestsToSkipStableSDK.xml From 700b78e1fdf8f25eb72243942f98d33263a74ca2 Mon Sep 17 00:00:00 2001 From: Marc Paine Date: Wed, 31 Jan 2024 14:47:44 -0800 Subject: [PATCH 4/4] add an additional test to disable --- test/SdkTests/TestsToSkipStableSDK.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/SdkTests/TestsToSkipStableSDK.xml b/test/SdkTests/TestsToSkipStableSDK.xml index d1138b370..550025aa6 100644 --- a/test/SdkTests/TestsToSkipStableSDK.xml +++ b/test/SdkTests/TestsToSkipStableSDK.xml @@ -185,6 +185,10 @@ Issue="" Reason="Cannot run with non-existent LastRuntimeFrameworkVersion"/> +