Cleanup extra qualification. Cleanup redundant casting. Cleanup usings. Set var suggestion to none.

.editorconfig

@@ -41,7 +41,7 @@ dotnet_style_qualification_for_event = false:suggestion
 # only use var when it's obvious what the variable type is
 csharp_style_var_for_built_in_types = false:none
 csharp_style_var_when_type_is_apparent = false:none
-csharp_style_var_elsewhere = false:suggestion
+csharp_style_var_elsewhere = false:none
 
 # use language keywords instead of BCL types
 dotnet_style_predefined_type_for_locals_parameters_members = true:suggestion

src/core-sdk-tasks/BuildFPMToolPreReqs.cs

@@ -6,7 +6,6 @@ using System.Collections.Generic;
 using Microsoft.Build.Utilities;
 using Microsoft.Build.Framework;
 using System.IO;
-using System.Linq;
 using System.Text;
 using Newtonsoft.Json;
 

src/core-sdk-tasks/CollatePackageDownloads.cs

@@ -1,10 +1,7 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System;
-using System.Collections.Generic;
 using System.Linq;
-using System.Text;
 using Microsoft.Build.Framework;
 using Microsoft.Build.Utilities;
 

src/core-sdk-tasks/Crossgen.cs

@@ -3,7 +3,6 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
-using System.Diagnostics;
 using System.IO;
 using System.Runtime.InteropServices;
 using Microsoft.Build.Framework;
@@ -63,7 +62,7 @@ namespace Microsoft.DotNet.Build.Tasks
 
             if (toolResult)
             {
-                var files = System.IO.Directory.GetFiles(Path.GetDirectoryName(TempOutputPath));
+                var files = Directory.GetFiles(Path.GetDirectoryName(TempOutputPath));
                 var dest = Path.GetDirectoryName(DestinationPath);
                 // Copy both dll and pdb files to the destination folder
                 foreach(var file in files)
@@ -168,6 +167,6 @@ namespace Microsoft.DotNet.Build.Tasks
 
         private string GetMissingDependenciesOk() => "-MissingDependenciesOK";
 
-        protected override void LogToolCommand(string message) => base.LogToolCommand($"{base.GetWorkingDirectory()}> {message}");
+        protected override void LogToolCommand(string message) => base.LogToolCommand($"{GetWorkingDirectory()}> {message}");
     }
 }

src/core-sdk-tasks/EnvironmentVariableFilter.cs

@@ -36,7 +36,7 @@ namespace Microsoft.DotNet.Cli.Build
 
         public IEnumerable<string> GetEnvironmentVariableNamesToRemove()
         {
-            var allEnvironmentVariableNames = (IEnumerable<string>)Environment
+            var allEnvironmentVariableNames = Environment
                 .GetEnvironmentVariables()
                 .Keys
                 .Cast<string>();

src/core-sdk-tasks/GenerateGuidFromName.cs

@@ -3,8 +3,6 @@
 
 using System;
 using System.Security.Cryptography;
-using Microsoft.Build.Framework;
-using Microsoft.Build.Utilities;
 
 namespace Microsoft.DotNet.Cli.Build
 {

src/core-sdk-tasks/GenerateSdkRuntimeIdentifierChain.cs

@@ -1,11 +1,7 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System;
-using System.Collections.Generic;
 using System.IO;
-using System.Linq;
-using System.Text;
 using Microsoft.Build.Framework;
 using Microsoft.Build.Utilities;
 using NuGet.RuntimeModel;

src/core-sdk-tasks/GetDependencyInfo.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
-using System.IO;
 using System.Linq;
 using System.Xml.Linq;
 using Microsoft.Build.Framework;

src/core-sdk-tasks/GetLinuxNativeInstallerDependencyVersions.cs

@@ -1,14 +1,8 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System;
-using System.Collections.Generic;
-using System.IO;
-using System.Linq;
-using System.Text;
 using Microsoft.Build.Framework;
 using Microsoft.Build.Utilities;
-using Newtonsoft.Json.Linq;
 
 namespace Microsoft.DotNet.Cli.Build
 {

src/core-sdk-tasks/GetRuntimePackRids.cs

@@ -1,11 +1,8 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System;
-using System.Collections.Generic;
 using System.IO;
 using System.Linq;
-using System.Text;
 using Microsoft.Build.Framework;
 using Microsoft.Build.Utilities;
 using Newtonsoft.Json.Linq;

src/core-sdk-tasks/TarGzFileCreateFromDirectory.cs

@@ -131,6 +131,6 @@ namespace Microsoft.DotNet.Build.Tasks
             return excludes;
         }
 
-        protected override void LogToolCommand(string message) => base.LogToolCommand($"{base.GetWorkingDirectory()}> {message}");
+        protected override void LogToolCommand(string message) => base.LogToolCommand($"{GetWorkingDirectory()}> {message}");
     }
 }

src/core-sdk-tasks/UpdateRuntimeConfig.cs

@@ -1,10 +1,7 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System;
-using System.Collections.Generic;
 using System.IO;
-using System.Linq;
 using Microsoft.Build.Framework;
 using Microsoft.Build.Utilities;
 using Newtonsoft.Json.Linq;

src/redist/redist.csproj

@@ -10,10 +10,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <FrameworkReference Update="Microsoft.NETCore.App" 
+    <FrameworkReference Update="Microsoft.NETCore.App" TargetingPackVersion="$(MicrosoftNETCoreAppRefPackageVersion)" RuntimeFrameworkVersion="$(MicrosoftNETCoreAppRuntimePackageVersion)" />
-                        TargetingPackVersion="$(MicrosoftNETCoreAppRefPackageVersion)"
-                        RuntimeFrameworkVersion="$(MicrosoftNETCoreAppRuntimePackageVersion)"
-                        />
 
     <ProjectReference Include="..\SdkResolver\SdkResolver.csproj" ReferenceOutputAssembly="false" Condition="'$(DotNetBuildFromSource)' != 'true'" />
     <ProjectReference Include="..\VSTemplateLocator\VSTemplateLocator.csproj" ReferenceOutputAssembly="false" Condition="'$(DotNetBuildFromSource)' != 'true'" />

test/EndToEnd/GivenDotnetUsesDotnetTools.cs

@@ -1,6 +1,5 @@
 using FluentAssertions;
 using Microsoft.DotNet.Tools.Test.Utilities;
-using Xunit;
 
 namespace EndToEnd
 {

test/EndToEnd/GivenNetFrameworkSupportsNetStandard2.cs

@@ -1,10 +1,7 @@
 using FluentAssertions;
 using Microsoft.DotNet.TestFramework;
 using Microsoft.DotNet.Tools.Test.Utilities;
-using System;
-using System.Collections.Generic;
 using System.IO;
-using System.Text;
 
 namespace EndToEnd
 {

test/EndToEnd/GivenUnixPlatform.cs

@@ -1,7 +1,3 @@
-using System;
-using System.IO;
-using System.Linq;
-using System.Xml.Linq;
 using Microsoft.DotNet.TestFramework;
 using Microsoft.DotNet.Tools.Test.Utilities;
 using Xunit;

test/EndToEnd/GivenWeWantToRequireWindowsForDesktopApps.cs

@@ -1,7 +1,6 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System;
 using System.IO;
 using System.Xml.Linq;
 using EndToEnd;

test/EndToEnd/TestProjectCreator.cs

@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Runtime.CompilerServices;
-using System.Text;
 using System.Xml.Linq;
 using Microsoft.DotNet.TestFramework;
 using Microsoft.DotNet.Tools.Test.Utilities;

test/EndToEnd/VersionTests.cs

@@ -1,9 +1,6 @@
-using System;
+using System.IO;
-using System.IO;
 using System.Linq;
-using System.Xml.Linq;
 using FluentAssertions;
-using Microsoft.DotNet.TestFramework;
 using Microsoft.DotNet.Tools.Test.Utilities;
 using Xunit;
 

test/Microsoft.DotNet.Tools.Tests.Utilities/Assertions/DirectoryInfoAssertions.cs

@@ -3,12 +3,10 @@
 
 using FluentAssertions;
 using FluentAssertions.Execution;
-using Microsoft.DotNet.Cli.Utils;
 using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
-using System.Threading.Tasks;
 
 namespace Microsoft.DotNet.Tools.Test.Utilities
 {

test/Microsoft.DotNet.Tools.Tests.Utilities/Assertions/DirectoryInfoExtensions.cs

@@ -1,11 +1,7 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System;
-using System.Collections.Generic;
 using System.IO;
-using System.Linq;
-using System.Threading.Tasks;
 
 namespace Microsoft.DotNet.Tools.Test.Utilities
 {

test/Microsoft.DotNet.Tools.Tests.Utilities/Assertions/FileInfoAssertions.cs

@@ -3,12 +3,7 @@
 
 using FluentAssertions;
 using FluentAssertions.Execution;
-using Microsoft.DotNet.Cli.Utils;
-using System;
-using System.Collections.Generic;
 using System.IO;
-using System.Linq;
-using System.Threading.Tasks;
 
 namespace Microsoft.DotNet.Tools.Test.Utilities
 {

test/Microsoft.DotNet.Tools.Tests.Utilities/Assertions/FileInfoExtensions.FileInfoLock.cs

@@ -2,10 +2,7 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
-using System.Collections.Generic;
 using System.IO;
-using System.Linq;
-using System.Threading.Tasks;
 
 namespace Microsoft.DotNet.Tools.Test.Utilities
 {

test/Microsoft.DotNet.Tools.Tests.Utilities/Assertions/FileInfoExtensions.FileInfoNuGetLock.cs

@@ -2,9 +2,7 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
-using System.Collections.Generic;
 using System.IO;
-using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
 using NuGet.Common;

test/Microsoft.DotNet.Tools.Tests.Utilities/Assertions/FileInfoExtensions.cs

@@ -2,10 +2,7 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
-using System.Collections.Generic;
 using System.IO;
-using System.Linq;
-using System.Threading.Tasks;
 
 namespace Microsoft.DotNet.Tools.Test.Utilities
 {

test/Microsoft.DotNet.Tools.Tests.Utilities/Assertions/StringAssertionsExtensions.cs

@@ -1,7 +1,6 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System;
 using FluentAssertions;
 using FluentAssertions.Execution;
 using FluentAssertions.Primitives;

test/Microsoft.DotNet.Tools.Tests.Utilities/Commands/AddReferenceCommand.cs

@@ -12,7 +12,7 @@ namespace Microsoft.DotNet.Tools.Test.Utilities
         public override CommandResult Execute(string args = "")
         {
             args = $"add {_projectName} reference {args}";
-            return base.ExecuteWithCapturedOutput(args);
+            return ExecuteWithCapturedOutput(args);
         }
 
         public AddReferenceCommand WithProject(string projectName)

test/Microsoft.DotNet.Tools.Tests.Utilities/Commands/CleanCommand.cs

@@ -1,9 +1,7 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System;
 using Microsoft.DotNet.Cli.Utils;
-using System.Runtime.InteropServices;
 
 namespace Microsoft.DotNet.Tools.Test.Utilities
 {

test/Microsoft.DotNet.Tools.Tests.Utilities/Commands/DependencyToolInvokerCommand.cs

@@ -1,9 +1,7 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System;
 using Microsoft.DotNet.Cli.Utils;
-using System.Runtime.InteropServices;
 
 namespace Microsoft.DotNet.Tools.Test.Utilities
 {

test/Microsoft.DotNet.Tools.Tests.Utilities/Commands/DotnetCommand.cs

@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using Microsoft.DotNet.Cli.Utils;
-
 namespace Microsoft.DotNet.Tools.Test.Utilities
 {
     public class DotnetCommand : TestCommand

test/Microsoft.DotNet.Tools.Tests.Utilities/Commands/ListPackageCommand.cs

@@ -12,7 +12,7 @@ namespace Microsoft.DotNet.Tools.Test.Utilities
         public override CommandResult Execute(string args = "")
         {
             args = $"list {_path} package {args}";
-            return base.ExecuteWithCapturedOutput(args);
+            return ExecuteWithCapturedOutput(args);
         }
 
         public ListPackageCommand WithPath(string path)

test/Microsoft.DotNet.Tools.Tests.Utilities/Commands/ListReferenceCommand.cs

@@ -12,7 +12,7 @@ namespace Microsoft.DotNet.Tools.Test.Utilities
         public override CommandResult Execute(string args = "")
         {
             args = $"list {_projectName} reference {args}";
-            return base.ExecuteWithCapturedOutput(args);
+            return ExecuteWithCapturedOutput(args);
         }
 
         public ListReferenceCommand WithProject(string projectName)

test/Microsoft.DotNet.Tools.Tests.Utilities/Commands/NewCommandShim.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using Microsoft.DotNet.Cli.Utils;
-using Xunit;
 
 namespace Microsoft.DotNet.Tools.Test.Utilities
 {

test/Microsoft.DotNet.Tools.Tests.Utilities/Commands/PackCommand.cs

@@ -1,7 +1,6 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System;
 using Microsoft.DotNet.Cli.Utils;
 
 namespace Microsoft.DotNet.Tools.Test.Utilities

test/Microsoft.DotNet.Tools.Tests.Utilities/Commands/RemoveReferenceCommand.cs

@@ -12,7 +12,7 @@ namespace Microsoft.DotNet.Tools.Test.Utilities
         public override CommandResult Execute(string args = "")
         {
             args = $"remove {_projectName} reference {args}";
-            return base.ExecuteWithCapturedOutput(args);
+            return ExecuteWithCapturedOutput(args);
         }
 
         public RemoveReferenceCommand WithProject(string projectName)

test/Microsoft.DotNet.Tools.Tests.Utilities/Commands/RunCommand.cs

@@ -1,9 +1,7 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System;
 using Microsoft.DotNet.Cli.Utils;
-using System.Runtime.InteropServices;
 
 namespace Microsoft.DotNet.Tools.Test.Utilities
 {

test/Microsoft.DotNet.Tools.Tests.Utilities/Commands/TestCommand.cs

@@ -6,9 +6,6 @@ using System;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.IO;
-using System.Linq;
-using System.Runtime.InteropServices;
-using System.Threading;
 using System.Threading.Tasks;
 
 namespace Microsoft.DotNet.Tools.Test.Utilities

test/Microsoft.DotNet.Tools.Tests.Utilities/Extensions/TestCommandExtensions.cs

@@ -1,13 +1,8 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using Microsoft.DotNet.Cli.Utils;
 using System;
-using System.Diagnostics;
 using System.IO;
-using System.Collections.Generic;
-using System.Runtime.InteropServices;
-using System.Threading.Tasks;
 
 namespace Microsoft.DotNet.Tools.Test.Utilities
 {

test/Microsoft.DotNet.Tools.Tests.Utilities/NuGetFrameworks.cs

@@ -1,7 +1,5 @@
 using NuGet.Frameworks;
 using System;
-using System.Collections.Generic;
-using System.Text;
 
 namespace Microsoft.DotNet.Tools.Tests.Utilities
 {

test/Microsoft.DotNet.Tools.Tests.Utilities/RuntimeConfig.cs

@@ -4,7 +4,6 @@
 using System;
 using System.Text.Json;
 using System.IO;
-using Microsoft.DotNet.Cli.Utils;
 
 namespace Microsoft.DotNet.TestFramework
 {

test/Microsoft.DotNet.Tools.Tests.Utilities/TempFileSystem/ImmutableArrayTestExtensions.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
-using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Diagnostics;
 using System.IO;

test/Microsoft.DotNet.Tools.Tests.Utilities/TestAssetInstance.cs

@@ -4,11 +4,8 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
-using System.Linq;
 using System.Reflection;
-using System.Runtime.CompilerServices;
 using System.Text;
-using System.Threading.Tasks;
 using System.Xml.Linq;
 using Microsoft.DotNet.Cli.Utils;
 using Microsoft.DotNet.Tools.Common;

test/Microsoft.DotNet.Tools.Tests.Utilities/TestAssetInventoryFiles.cs

@@ -1,13 +1,8 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System;
 using System.Collections.Generic;
 using System.IO;
-using System.Linq;
-using System.Runtime.CompilerServices;
-using System.Threading.Tasks;
-using Microsoft.DotNet.Cli.Utils;
 
 namespace Microsoft.DotNet.TestFramework
 {

test/Microsoft.DotNet.Tools.Tests.Utilities/TestAssetKinds.cs

@@ -1,14 +1,6 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System;
-using System.Collections.Generic;
-using System.IO;
-using System.Linq;
-using System.Runtime.CompilerServices;
-using System.Threading.Tasks;
-using Microsoft.DotNet.Cli.Utils;
-
 namespace Microsoft.DotNet.TestFramework
 {
     public class TestAssetKinds

test/Microsoft.DotNet.Tools.Tests.Utilities/TestAssets.cs

@@ -2,12 +2,8 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
-using System.Collections.Generic;
 using System.IO;
-using System.Linq;
 using System.Runtime.CompilerServices;
-using System.Threading.Tasks;
-using Microsoft.DotNet.Cli.Utils;
 
 namespace Microsoft.DotNet.TestFramework
 {

test/Microsoft.DotNet.Tools.Tests.Utilities/TestBase.cs

@@ -6,7 +6,6 @@ using System.Collections.Generic;
 using System.Globalization;
 using System.IO;
 using System.Linq;
-using System.Threading.Tasks;
 using Microsoft.DotNet.Cli.Utils;
 using Microsoft.DotNet.TestFramework;