mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Better error messages when makerunnable fails

Browse source
This commit is contained in:
Mihai Codoban 2016-04-28 17:49:04 -07:00
parent 2e963a6aef
commit b480eb9072
3 changed files with 48 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
src/Microsoft.DotNet.Compiler.Common/BindingRedirectGenerator.cs
View file

@ -179,33 +179,40 @@ namespace Microsoft.DotNet.Cli.Compiler.Common
private static AssemblyReferenceInfo GetAssemblyInfo(LibraryAsset arg) private static AssemblyReferenceInfo GetAssemblyInfo(LibraryAsset arg)
{ {
using (var peReader = new PEReader(File.OpenRead(arg.ResolvedPath))) try
{ {
var metadataReader = peReader.GetMetadataReader(); using (var peReader = new PEReader(File.OpenRead(arg.ResolvedPath)))
var definition = metadataReader.GetAssemblyDefinition();
var identity = new AssemblyIdentity(
metadataReader.GetString(definition.Name),
definition.Version,
metadataReader.GetString(definition.Culture),
GetPublicKeyToken(metadataReader.GetBlobBytes(definition.PublicKey))
);
var references = new List<AssemblyIdentity>(metadataReader.AssemblyReferences.Count);
foreach (var assemblyReferenceHandle in metadataReader.AssemblyReferences)
{ {
var assemblyReference = metadataReader.GetAssemblyReference(assemblyReferenceHandle); var metadataReader = peReader.GetMetadataReader();
references.Add(new AssemblyIdentity(
metadataReader.GetString(assemblyReference.Name),
assemblyReference.Version,
metadataReader.GetString(assemblyReference.Culture),
GetPublicKeyToken(metadataReader.GetBlobBytes(assemblyReference.PublicKeyOrToken))
));
}
return new AssemblyReferenceInfo(identity, references.ToArray()); var definition = metadataReader.GetAssemblyDefinition();
var identity = new AssemblyIdentity(
metadataReader.GetString(definition.Name),
definition.Version,
metadataReader.GetString(definition.Culture),
GetPublicKeyToken(metadataReader.GetBlobBytes(definition.PublicKey))
);
var references = new List<AssemblyIdentity>(metadataReader.AssemblyReferences.Count);
foreach (var assemblyReferenceHandle in metadataReader.AssemblyReferences)
{
var assemblyReference = metadataReader.GetAssemblyReference(assemblyReferenceHandle);
references.Add(new AssemblyIdentity(
metadataReader.GetString(assemblyReference.Name),
assemblyReference.Version,
metadataReader.GetString(assemblyReference.Culture),
GetPublicKeyToken(metadataReader.GetBlobBytes(assemblyReference.PublicKeyOrToken))
));
}
return new AssemblyReferenceInfo(identity, references.ToArray());
}
}
catch (Exception e)
{
throw new InvalidDataException($"Could not read assembly info for {arg.ResolvedPath}", e);
} }
} }

3
src/dotnet/Program.cs
View file

@ -50,7 +50,8 @@ namespace Microsoft.DotNet.Cli
} }
catch (GracefulException e) catch (GracefulException e)
{ {
Console.WriteLine(e.Message.Red().Bold()); Console.WriteLine(CommandContext.IsVerbose() ? e.ToString().Red().Bold() : e.Message.Red().Bold());
return 1; return 1;
} }
} }

23
src/dotnet/commands/dotnet-build/DotnetProjectBuilder.cs
View file

@ -116,17 +116,24 @@ namespace Microsoft.DotNet.Tools.Build
private void MakeRunnable(ProjectGraphNode graphNode) private void MakeRunnable(ProjectGraphNode graphNode)
{ {
var runtimeContext = graphNode.ProjectContext.ProjectFile.HasRuntimeOutput(_args.ConfigValue) ? try
_args.Workspace.GetRuntimeContext(graphNode.ProjectContext, _args.GetRuntimes()) : {
graphNode.ProjectContext; var runtimeContext = graphNode.ProjectContext.ProjectFile.HasRuntimeOutput(_args.ConfigValue) ?
_args.Workspace.GetRuntimeContext(graphNode.ProjectContext, _args.GetRuntimes()) :
graphNode.ProjectContext;
var outputPaths = runtimeContext.GetOutputPaths(_args.ConfigValue, _args.BuildBasePathValue, _args.OutputValue); var outputPaths = runtimeContext.GetOutputPaths(_args.ConfigValue, _args.BuildBasePathValue, _args.OutputValue);
var libraryExporter = runtimeContext.CreateExporter(_args.ConfigValue, _args.BuildBasePathValue); var libraryExporter = runtimeContext.CreateExporter(_args.ConfigValue, _args.BuildBasePathValue);
CopyCompilationOutput(outputPaths); CopyCompilationOutput(outputPaths);
var executable = new Executable(runtimeContext, outputPaths, libraryExporter, _args.ConfigValue); var executable = new Executable(runtimeContext, outputPaths, libraryExporter, _args.ConfigValue);
executable.MakeCompilationOutputRunnable(); executable.MakeCompilationOutputRunnable();
}
catch (Exception e)
{
throw new Exception($"Failed to make the following project runnable: {graphNode.ProjectContext.GetDisplayName()}", e);
}
} }
protected override CompilationResult RunCompile(ProjectGraphNode projectNode) protected override CompilationResult RunCompile(ProjectGraphNode projectNode)