diff --git a/packaging/windows/clisdk/dotnet.wxs b/packaging/windows/clisdk/dotnet.wxs index 3872a645f..4624a144b 100644 --- a/packaging/windows/clisdk/dotnet.wxs +++ b/packaging/windows/clisdk/dotnet.wxs @@ -13,7 +13,7 @@ - + diff --git a/packaging/windows/clisdk/provider.wxs b/packaging/windows/clisdk/provider.wxs index 2f8e8d698..35d397eca 100644 --- a/packaging/windows/clisdk/provider.wxs +++ b/packaging/windows/clisdk/provider.wxs @@ -2,8 +2,8 @@ - - + + diff --git a/packaging/windows/clisdk/variables.wxi b/packaging/windows/clisdk/variables.wxi index 320984930..a11f06d36 100644 --- a/packaging/windows/clisdk/variables.wxi +++ b/packaging/windows/clisdk/variables.wxi @@ -25,4 +25,7 @@ + + + diff --git a/packaging/windows/host/generatemsi.ps1 b/packaging/windows/host/generatemsi.ps1 index 84c9654c4..c0ab6f30d 100644 --- a/packaging/windows/host/generatemsi.ps1 +++ b/packaging/windows/host/generatemsi.ps1 @@ -7,7 +7,6 @@ param( [Parameter(Mandatory=$true)][string]$WixRoot, [Parameter(Mandatory=$true)][string]$ProductMoniker, [Parameter(Mandatory=$true)][string]$DotnetMSIVersion, - [Parameter(Mandatory=$true)][string]$DotnetCLIDisplayVersion, [Parameter(Mandatory=$true)][string]$DotnetCLINugetVersion, [Parameter(Mandatory=$true)][string]$Architecture, [Parameter(Mandatory=$true)][string]$WixObjRoot @@ -31,7 +30,6 @@ function RunCandle -dMicrosoftEula="$RepoRoot\packaging\osx\clisdk\resources\en.lproj\eula.rtf" ` -dProductMoniker="$ProductMoniker" ` -dBuildVersion="$DotnetMSIVersion" ` - -dDisplayVersion="$DotnetCLIDisplayVersion" ` -dNugetVersion="$DotnetCLINugetVersion" ` -arch $Architecture ` "$AuthWsxRoot\host.wxs" ` diff --git a/packaging/windows/host/host.wxs b/packaging/windows/host/host.wxs index a2bc03f95..a1bff66ca 100644 --- a/packaging/windows/host/host.wxs +++ b/packaging/windows/host/host.wxs @@ -13,7 +13,7 @@ - + diff --git a/packaging/windows/host/provider.wxs b/packaging/windows/host/provider.wxs index be191eb7e..dab1a27e7 100644 --- a/packaging/windows/host/provider.wxs +++ b/packaging/windows/host/provider.wxs @@ -2,8 +2,8 @@ - - + + \ No newline at end of file diff --git a/packaging/windows/host/variables.wxi b/packaging/windows/host/variables.wxi index 95fddd387..f470a8c5e 100644 --- a/packaging/windows/host/variables.wxi +++ b/packaging/windows/host/variables.wxi @@ -5,7 +5,6 @@ - @@ -26,4 +25,7 @@ + + + \ No newline at end of file diff --git a/packaging/windows/sharedframework/generatebundle.ps1 b/packaging/windows/sharedframework/generatebundle.ps1 index 23c564ac4..49f161095 100644 --- a/packaging/windows/sharedframework/generatebundle.ps1 +++ b/packaging/windows/sharedframework/generatebundle.ps1 @@ -25,6 +25,7 @@ function RunCandleForBundle Write-Host Running candle for bundle.. $AuthWsxRoot = Join-Path $RepoRoot "packaging\windows\sharedframework" + $SharedFrameworkComponentVersion = $SharedFrameworkNugetVersion.Replace('-', '_'); .\candle.exe -nologo ` -dMicrosoftEula="$RepoRoot\packaging\osx\sharedframework\resources\en.lproj\eula.rtf" ` @@ -35,6 +36,7 @@ function RunCandleForBundle -dSharedHostMsiSourcePath="$SharedHostMSIFile" ` -dFrameworkName="$SharedFrameworkNugetName" ` -dFrameworkDisplayVersion="$SharedFrameworkNugetVersion" ` + -dFrameworkComponentVersion="$SharedFrameworkComponentVersion" ` -dFrameworkUpgradeCode="$SharedFrameworkUpgradeCode" ` -arch "$Architecture" ` -ext WixBalExtension.dll ` diff --git a/packaging/windows/sharedframework/provider.wxs b/packaging/windows/sharedframework/provider.wxs index 665d58c4a..02932a815 100644 --- a/packaging/windows/sharedframework/provider.wxs +++ b/packaging/windows/sharedframework/provider.wxs @@ -2,8 +2,8 @@ - - + + diff --git a/packaging/windows/sharedframework/sharedframework.wxs b/packaging/windows/sharedframework/sharedframework.wxs index 31801c268..ee0a53bdb 100644 --- a/packaging/windows/sharedframework/sharedframework.wxs +++ b/packaging/windows/sharedframework/sharedframework.wxs @@ -34,7 +34,7 @@ - + diff --git a/packaging/windows/sharedframework/variables.wxi b/packaging/windows/sharedframework/variables.wxi index 465033b92..4d67cd253 100644 --- a/packaging/windows/sharedframework/variables.wxi +++ b/packaging/windows/sharedframework/variables.wxi @@ -28,4 +28,7 @@ + + + diff --git a/scripts/dotnet-cli-build/MsiTargets.cs b/scripts/dotnet-cli-build/MsiTargets.cs index dfb6ee39f..cac997a5f 100644 --- a/scripts/dotnet-cli-build/MsiTargets.cs +++ b/scripts/dotnet-cli-build/MsiTargets.cs @@ -150,7 +150,7 @@ namespace Microsoft.DotNet.Cli.Build Cmd("powershell", "-NoProfile", "-NoLogo", Path.Combine(Dirs.RepoRoot, "packaging", "windows", "host", "generatemsi.ps1"), - inputDir, SharedHostMsi, WixRoot, sharedHostBrandName, MsiVersion, CliDisplayVersion, CliNugetVersion, Arch, wixObjRoot) + inputDir, SharedHostMsi, WixRoot, sharedHostBrandName, MsiVersion, CliNugetVersion, Arch, wixObjRoot) .Execute() .EnsureSuccessful(); return c.Success();