Address some PR feedback.

- Make the MSI scripts to use parameters instead of environment variables.
2016-03-07 14:52:41 -08:00 · 2016-03-07 14:52:41 -08:00 · ae041c8f61
commit ae041c8f61
parent 0f679e68bf
8 changed files with 58 additions and 44 deletions
--- a/scripts/dotnet-cli-build/PackageTargets.cs
+++ b/scripts/dotnet-cli-build/PackageTargets.cs
@ -25,7 +25,7 @@ namespace Microsoft.DotNet.Cli.Build
        nameof(PackageTargets.GenerateCompressedFile),
        nameof(InstallerTargets.GenerateInstaller),
        nameof(PackageTargets.GenerateNugetPackages))]
-        [Environment("DOTNET_BUILD_SKIP_PACKAGING", null)]
+        [Environment("DOTNET_BUILD_SKIP_PACKAGING", null, "0", "false")]
        public static BuildTargetResult Package(BuildTargetContext c)
        {
            return c.Success();