mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Instantiate HttpClient once

Browse source
This commit is contained in:
Ella Hathaway 2023-08-07 21:26:29 +00:00
parent 383cb48f5a
commit ab660eaf09
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/SourceBuild/content/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/UsageReport/WriteUsageBurndownData.cs
View file

@ -44,6 +44,11 @@ namespace Microsoft.DotNet.SourceBuild.Tasks.UsageReport
[Required] [Required]
public string OutputFilePath { get; set; } public string OutputFilePath { get; set; }
/// <summary>
/// Sends HTTP requests and receives HTTP responses.
/// </summary>
public HttpClient client = new HttpClient;
public override bool Execute() public override bool Execute()
{ {
string baselineRelativeFileName = PrebuiltBaselineFile.Replace(RootDirectory, ""); string baselineRelativeFileName = PrebuiltBaselineFile.Replace(RootDirectory, "");
@ -88,7 +93,6 @@ namespace Microsoft.DotNet.SourceBuild.Tasks.UsageReport
/// <returns>The contents of the specified file.</returns> /// <returns>The contents of the specified file.</returns>
private string GetFileContents(string relativeFilePath, string commitSha) private string GetFileContents(string relativeFilePath, string commitSha)
{ {
HttpClient client = new HttpClient();
string xmlString = client.GetStringAsync($"https://raw.githubusercontent.com/dotnet/source-build/{commitSha}/{relativeFilePath.Replace('\\', '/')}").Result; string xmlString = client.GetStringAsync($"https://raw.githubusercontent.com/dotnet/source-build/{commitSha}/{relativeFilePath.Replace('\\', '/')}").Result;
return xmlString; return xmlString;
} }