mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Disable format tests on Alpine (#17247)

Browse source
This commit is contained in:
Nikola Milosavljevic 2023-08-24 07:56:32 -07:00 • committed by GitHub
parent 96fc9a05f0
commit a37bcd19b5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 18 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
eng/pipelines/templates/jobs/vmr-build.yml
View file

@ -40,6 +40,9 @@ parameters:
- name: excludeOmniSharpTests - name: excludeOmniSharpTests
type: boolean type: boolean
- name: excludeDotnetFormatTests
type: boolean
- name: enablePoison - name: enablePoison
type: boolean type: boolean
@ -218,7 +221,7 @@ jobs:
set -x set -x
dockerVolumeArgs="-v $(sourcesPath):/vmr" dockerVolumeArgs="-v $(sourcesPath):/vmr"
dockerEnvArgs="-e SMOKE_TESTS_EXCLUDE_OMNISHARP=${{ parameters.excludeOmniSharpTests }} -e SMOKE_TESTS_WARN_SDK_CONTENT_DIFFS=true -e SMOKE_TESTS_RUNNING_IN_CI=true" dockerEnvArgs="-e SMOKE_TESTS_EXCLUDE_OMNISHARP=${{ parameters.excludeOmniSharpTests }} -e SMOKE_TESTS_EXCLUDE_DOTNETFORMAT=${{ parameters.excludeDotnetFormatTests }} -e SMOKE_TESTS_WARN_SDK_CONTENT_DIFFS=true -e SMOKE_TESTS_RUNNING_IN_CI=true"
poisonArg='' poisonArg=''
if [[ '${{ parameters.enablePoison }}' == 'True' ]]; then if [[ '${{ parameters.enablePoison }}' == 'True' ]]; then

12
eng/pipelines/templates/stages/vmr-build.yml
View file

@ -83,6 +83,7 @@ stages:
buildFromArchive: false # 🚫 buildFromArchive: false # 🚫
enablePoison: false # 🚫 enablePoison: false # 🚫
excludeOmniSharpTests: true # ✅ excludeOmniSharpTests: true # ✅
excludeDotnetFormatTests: false # 🚫
runOnline: true # ✅ runOnline: true # ✅
useMonoRuntime: false # 🚫 useMonoRuntime: false # 🚫
withPreviousSDK: false # 🚫 withPreviousSDK: false # 🚫
@ -101,6 +102,7 @@ stages:
buildFromArchive: true # ✅ buildFromArchive: true # ✅
enablePoison: false # 🚫 enablePoison: false # 🚫
excludeOmniSharpTests: true # ✅ excludeOmniSharpTests: true # ✅
excludeDotnetFormatTests: false # 🚫
runOnline: false # 🚫 runOnline: false # 🚫
useMonoRuntime: false # 🚫 useMonoRuntime: false # 🚫
withPreviousSDK: false # 🚫 withPreviousSDK: false # 🚫
@ -123,6 +125,7 @@ stages:
buildFromArchive: false # ✅ buildFromArchive: false # ✅
enablePoison: false # 🚫 enablePoison: false # 🚫
excludeOmniSharpTests: true # ✅ excludeOmniSharpTests: true # ✅
excludeDotnetFormatTests: true # ✅ - https://github.com/dotnet/format/issues/1945
runOnline: false # 🚫 runOnline: false # 🚫
useMonoRuntime: false # 🚫 useMonoRuntime: false # 🚫
withPreviousSDK: false # 🚫 withPreviousSDK: false # 🚫
@ -141,6 +144,7 @@ stages:
buildFromArchive: false # 🚫 buildFromArchive: false # 🚫
enablePoison: false # 🚫 enablePoison: false # 🚫
excludeOmniSharpTests: true # ✅ excludeOmniSharpTests: true # ✅
excludeDotnetFormatTests: false # 🚫
runOnline: true # ✅ runOnline: true # ✅
useMonoRuntime: false # 🚫 useMonoRuntime: false # 🚫
withPreviousSDK: true # ✅ withPreviousSDK: true # ✅
@ -159,6 +163,7 @@ stages:
buildFromArchive: false # 🚫 buildFromArchive: false # 🚫
enablePoison: false # 🚫 enablePoison: false # 🚫
excludeOmniSharpTests: true # ✅ excludeOmniSharpTests: true # ✅
excludeDotnetFormatTests: false # 🚫
runOnline: false # 🚫 runOnline: false # 🚫
useMonoRuntime: false # 🚫 useMonoRuntime: false # 🚫
withPreviousSDK: true # ✅ withPreviousSDK: true # ✅
@ -177,6 +182,7 @@ stages:
buildFromArchive: true # ✅ buildFromArchive: true # ✅
enablePoison: false # 🚫 enablePoison: false # 🚫
excludeOmniSharpTests: true # ✅ excludeOmniSharpTests: true # ✅
excludeDotnetFormatTests: false # 🚫
runOnline: false # 🚫 runOnline: false # 🚫
useMonoRuntime: true # ✅ useMonoRuntime: true # ✅
withPreviousSDK: false # 🚫 withPreviousSDK: false # 🚫
@ -195,6 +201,7 @@ stages:
buildFromArchive: true # ✅ buildFromArchive: true # ✅
enablePoison: false # 🚫 enablePoison: false # 🚫
excludeOmniSharpTests: false # 🚫 excludeOmniSharpTests: false # 🚫
excludeDotnetFormatTests: false # 🚫
runOnline: false # 🚫 runOnline: false # 🚫
useMonoRuntime: false # 🚫 useMonoRuntime: false # 🚫
withPreviousSDK: false # 🚫 withPreviousSDK: false # 🚫
@ -213,6 +220,7 @@ stages:
buildFromArchive: true # ✅ buildFromArchive: true # ✅
enablePoison: true # ✅ enablePoison: true # ✅
excludeOmniSharpTests: false # 🚫 excludeOmniSharpTests: false # 🚫
excludeDotnetFormatTests: false # 🚫
runOnline: false # 🚫 runOnline: false # 🚫
useMonoRuntime: false # 🚫 useMonoRuntime: false # 🚫
withPreviousSDK: false # 🚫 withPreviousSDK: false # 🚫
@ -231,6 +239,7 @@ stages:
buildFromArchive: false # 🚫 buildFromArchive: false # 🚫
enablePoison: false # 🚫 enablePoison: false # 🚫
excludeOmniSharpTests: false # 🚫 excludeOmniSharpTests: false # 🚫
excludeDotnetFormatTests: false # 🚫
runOnline: false # 🚫 runOnline: false # 🚫
useMonoRuntime: false # 🚫 useMonoRuntime: false # 🚫
withPreviousSDK: false # 🚫 withPreviousSDK: false # 🚫
@ -249,6 +258,7 @@ stages:
buildFromArchive: false # 🚫 buildFromArchive: false # 🚫
enablePoison: false # 🚫 enablePoison: false # 🚫
excludeOmniSharpTests: false # 🚫 excludeOmniSharpTests: false # 🚫
excludeDotnetFormatTests: false # 🚫
runOnline: false # 🚫 runOnline: false # 🚫
useMonoRuntime: false # 🚫 useMonoRuntime: false # 🚫
withPreviousSDK: false # 🚫 withPreviousSDK: false # 🚫
@ -269,6 +279,7 @@ stages:
buildFromArchive: false # 🚫 buildFromArchive: false # 🚫
enablePoison: false # 🚫 enablePoison: false # 🚫
excludeOmniSharpTests: true # ✅ excludeOmniSharpTests: true # ✅
excludeDotnetFormatTests: false # 🚫
runOnline: false # 🚫 runOnline: false # 🚫
useMonoRuntime: false # 🚫 useMonoRuntime: false # 🚫
withPreviousSDK: false # 🚫 withPreviousSDK: false # 🚫
@ -288,6 +299,7 @@ stages:
buildFromArchive: false # 🚫 buildFromArchive: false # 🚫
enablePoison: false # 🚫 enablePoison: false # 🚫
excludeOmniSharpTests: false # 🚫 excludeOmniSharpTests: false # 🚫
excludeDotnetFormatTests: false # 🚫
runOnline: false # 🚫 runOnline: false # 🚫
useMonoRuntime: false # 🚫 useMonoRuntime: false # 🚫
withPreviousSDK: false # 🚫 withPreviousSDK: false # 🚫

1
src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/Config.cs
View file

@ -10,6 +10,7 @@ namespace Microsoft.DotNet.SourceBuild.SmokeTests;
internal static class Config internal static class Config
{ {
public const string DotNetDirectoryEnv = "SMOKE_TESTS_DOTNET_DIR"; public const string DotNetDirectoryEnv = "SMOKE_TESTS_DOTNET_DIR";
public const string ExcludeDotnetFormatEnv = "SMOKE_TESTS_EXCLUDE_DOTNETFORMAT";
public const string ExcludeOmniSharpEnv = "SMOKE_TESTS_EXCLUDE_OMNISHARP"; public const string ExcludeOmniSharpEnv = "SMOKE_TESTS_EXCLUDE_OMNISHARP";
public const string MsftSdkTarballPathEnv = "SMOKE_TESTS_MSFT_SDK_TARBALL_PATH"; public const string MsftSdkTarballPathEnv = "SMOKE_TESTS_MSFT_SDK_TARBALL_PATH";
public const string PoisonReportPathEnv = "SMOKE_TESTS_POISON_REPORT_PATH"; public const string PoisonReportPathEnv = "SMOKE_TESTS_POISON_REPORT_PATH";

2
src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/DotNetFormatTests.cs
View file

@ -19,7 +19,7 @@ public class DotNetFormatTests : SmokeTests
/// <Summary> /// <Summary>
/// Format an unformatted project and verify that the output matches the pre-computed solution. /// Format an unformatted project and verify that the output matches the pre-computed solution.
/// </Summary> /// </Summary>
[Fact] [SkippableFact(Config.ExcludeDotnetFormatEnv, skipOnTrue: true)]
public void FormatProject() public void FormatProject()
{ {
string unformattedCsFilePath = Path.Combine(BaselineHelper.GetAssetsDirectory(), UnformattedFileName); string unformattedCsFilePath = Path.Combine(BaselineHelper.GetAssetsDirectory(), UnformattedFileName);