From a2d44ace0be6e2a41f4a4955a99741a7343efe53 Mon Sep 17 00:00:00 2001 From: jbeisner <jbeisner@microsoft.com> Date: Fri, 27 Jul 2018 20:05:58 +0000 Subject: [PATCH] Create binlogs by default. --- .gitignore | 3 +++ run-build.ps1 | 4 ++-- run-build.sh | 4 ++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index 847693d1d..397d2babe 100644 --- a/.gitignore +++ b/.gitignore @@ -127,6 +127,9 @@ bin/ *.svclog *.scc +# BinLog artifacts +msbuild.*.ProjectImports.zip + # Chutzpah Test files _Chutzpah* diff --git a/run-build.ps1 b/run-build.ps1 index 344cf4374..50daef678 100644 --- a/run-build.ps1 +++ b/run-build.ps1 @@ -108,7 +108,7 @@ if ($NoBuild) } else { - dotnet msbuild build.proj /p:Architecture=$Architecture /p:GeneratePropsFile=true /t:WriteDynamicPropsToStaticPropsFiles $ExtraParametersNoTargets - dotnet msbuild build.proj /m /v:normal /fl /flp:v=diag /p:Architecture=$Architecture $ExtraParameters + dotnet msbuild build.proj /bl:msbuild.generatepropsfile.binlog /p:Architecture=$Architecture /p:GeneratePropsFile=true /t:WriteDynamicPropsToStaticPropsFiles $ExtraParametersNoTargets + dotnet msbuild build.proj /bl:msbuild.mainbuild.binlog /m /v:normal /fl /flp:v=diag /p:Architecture=$Architecture $ExtraParameters if($LASTEXITCODE -ne 0) { throw "Failed to build" } } diff --git a/run-build.sh b/run-build.sh index 1f2ed25a9..426604aee 100755 --- a/run-build.sh +++ b/run-build.sh @@ -189,8 +189,8 @@ fi export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1 if [ $BUILD -eq 1 ]; then - dotnet msbuild build.proj /p:Architecture=$ARCHITECTURE $CUSTOM_BUILD_ARGS /p:GeneratePropsFile=true /t:WriteDynamicPropsToStaticPropsFiles ${argsnotargets[@]} - dotnet msbuild build.proj /m /v:normal /fl /flp:v=diag /p:Architecture=$ARCHITECTURE $CUSTOM_BUILD_ARGS $args + dotnet msbuild build.proj /bl:msbuild.generatepropsfile.binlog /p:Architecture=$ARCHITECTURE $CUSTOM_BUILD_ARGS /p:GeneratePropsFile=true /t:WriteDynamicPropsToStaticPropsFiles ${argsnotargets[@]} + dotnet msbuild build.proj /bl:msbuild.mainbuild.binlog /m /v:normal /fl /flp:v=diag /p:Architecture=$ARCHITECTURE $CUSTOM_BUILD_ARGS $args else echo "Not building due to --nobuild" echo "Command that would be run is: 'dotnet msbuild build.proj /m /p:Architecture=$ARCHITECTURE $CUSTOM_BUILD_ARGS $args'"