From 9f0dab1a087dddcb00df3bf157eaa5447dd02f4f Mon Sep 17 00:00:00 2001 From: Piotr Puszkiewicz Date: Tue, 3 May 2016 11:38:55 -0700 Subject: [PATCH] PR Feedback --- src/dotnet/MulticoreJitActivator.cs | 2 +- test/dotnet.Tests/GivenThatIWantToManageMulticoreJIT.cs | 2 -- test/dotnet.Tests/project.json | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/dotnet/MulticoreJitActivator.cs b/src/dotnet/MulticoreJitActivator.cs index d09974ed1..aeda45db5 100644 --- a/src/dotnet/MulticoreJitActivator.cs +++ b/src/dotnet/MulticoreJitActivator.cs @@ -29,7 +29,7 @@ namespace Microsoft.DotNet.Cli private bool IsMulticoreJitDisabled() { - return Environment.GetEnvironmentVariable("DOTNET_DISABLE_MULTICOREJIT") == "1"; + return Env.GetEnvironmentVariableAsBool("DOTNET_DISABLE_MULTICOREJIT"); } private void StartCliProfileOptimization() diff --git a/test/dotnet.Tests/GivenThatIWantToManageMulticoreJIT.cs b/test/dotnet.Tests/GivenThatIWantToManageMulticoreJIT.cs index d3dcc3e3b..a9d398bd3 100644 --- a/test/dotnet.Tests/GivenThatIWantToManageMulticoreJIT.cs +++ b/test/dotnet.Tests/GivenThatIWantToManageMulticoreJIT.cs @@ -33,7 +33,6 @@ namespace Microsoft.DotNet.Tests new TestCommand("dotnet") .WithUserProfileRoot(testDirectory.Path) .ExecuteWithCapturedOutput("--help"); - var optimizationProfileFilePath = GetOptimizationProfileFilePath(testDirectory.Path); @@ -54,7 +53,6 @@ namespace Microsoft.DotNet.Tests .WithUserProfileRoot(testDirectory.Path) .WithEnvironmentVariable("DOTNET_DISABLE_MULTICOREJIT", "1") .ExecuteWithCapturedOutput("--help"); - var optimizationProfileFilePath = GetOptimizationProfileFilePath(testDirectory.Path); diff --git a/test/dotnet.Tests/project.json b/test/dotnet.Tests/project.json index 899d5e4d2..f5205ee3d 100644 --- a/test/dotnet.Tests/project.json +++ b/test/dotnet.Tests/project.json @@ -16,7 +16,7 @@ "target": "project", "type": "build" }, - "Microsoft.Extensions.PlatformAbstractions": "1.0.0-rc2-20100", + "Microsoft.Extensions.PlatformAbstractions": "1.0.0-rc2-20581", "xunit": "2.1.0", "dotnet-test-xunit": "1.0.0-rc2-173361-36" },