mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Addressing code review comments.

Browse source
This commit is contained in:
Livar Cunha 2016-12-08 20:06:55 -08:00
parent bb1bceb8bb
commit 9bddb5bac7
2 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
TestAssets/TestProjects/TestLibraryWithProjectFileWithoutFrameworks/project.json → TestAssets/NonRestoredTestProjects/TestLibraryWithProjectFileWithoutFrameworks/project.json
View file

@ -5,4 +5,4 @@
"type": "build" "type": "build"
} }
} }
} }

13
test/Microsoft.DotNet.ProjectJsonMigration.Tests/GivenAProjectMigrator.cs
View file

@ -80,9 +80,10 @@ namespace Microsoft.DotNet.ProjectJsonMigration.Tests
[Fact] [Fact]
public void ItHasErrorWhenMigratingAProjectJsonWithoutAFrameworks() public void ItHasErrorWhenMigratingAProjectJsonWithoutAFrameworks()
{ {
var testAppName = "TestLibraryWithProjectFileWithoutFrameworks"; var testInstance = TestAssets.Get(
var testInstance = TestAssets.Get(testAppName) "NonRestoredTestProjects",
.CreateInstance(testAppName) "TestLibraryWithProjectFileWithoutFrameworks")
.CreateInstance()
.WithSourceFiles(); .WithSourceFiles();
var testProjectDirectory = testInstance.Root.FullName; var testProjectDirectory = testInstance.Root.FullName;
@ -98,9 +99,9 @@ namespace Microsoft.DotNet.ProjectJsonMigration.Tests
var projectReport = report.ProjectMigrationReports.First(); var projectReport = report.ProjectMigrationReports.First();
var errorMessage = projectReport.Errors.First().GetFormattedErrorMessage(); projectReport.Errors.First().GetFormattedErrorMessage()
errorMessage.Should().Contain("MIGRATE1013::No Project:"); .Should().Contain("MIGRATE1013::No Project:")
errorMessage.Should().Contain($"The project.json specifies no target frameworks in {testProjectDirectory}"); .And.Contain($"The project.json specifies no target frameworks in {testProjectDirectory}");
} }
private IEnumerable<string> EnumerateFilesWithRelativePath(string testProjectDirectory) private IEnumerable<string> EnumerateFilesWithRelativePath(string testProjectDirectory)