mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

When a failed command is executed in "silent" mode, it is not easy to figure out why it failed in the build logs.

Browse source 
Fix: Add Standard Output and Error to the BuildFailureException message thrown by CommandResult.EnsureSuccessful.
This commit is contained in:
Eric Erhardt 2016-03-14 15:20:35 -05:00
parent fd4e3b8cfe
commit 9a4936ae0d
1 changed files with 14 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

15
scripts/Microsoft.DotNet.Cli.Build.Framework/CommandResult.cs
View file

@ -2,6 +2,7 @@
// Licensed under the MIT license. See LICENSE file in the project root for full license information. // Licensed under the MIT license. See LICENSE file in the project root for full license information.
using System; using System;
using System.Text;
using System.Diagnostics; using System.Diagnostics;
namespace Microsoft.DotNet.Cli.Build.Framework namespace Microsoft.DotNet.Cli.Build.Framework
@ -27,7 +28,19 @@ namespace Microsoft.DotNet.Cli.Build.Framework
{ {
if(ExitCode != 0) if(ExitCode != 0)
{ {
throw new BuildFailureException($"Command failed with exit code {ExitCode}: {StartInfo.FileName} {StartInfo.Arguments}"); StringBuilder message = new StringBuilder($"Command failed with exit code {ExitCode}: {StartInfo.FileName} {StartInfo.Arguments}");
if (!string.IsNullOrEmpty(StdOut))
{
message.AppendLine($"{Environment.NewLine}Standard Output:{Environment.NewLine}{StdOut}");
}
if (!string.IsNullOrEmpty(StdErr))
{
message.AppendLine($"{Environment.NewLine}Standard Error:{Environment.NewLine}{StdErr}");
}
throw new BuildFailureException(message.ToString());
} }
} }
} }