From 98313ce3016f5af9e4cd3379ce24d3a84b43d2a3 Mon Sep 17 00:00:00 2001 From: Nikola Milosavljevic Date: Fri, 21 Apr 2023 10:35:43 -0700 Subject: [PATCH] Fix TFM path for Test CLI package (#16186) --- .../BasicScenarioTests.cs | 7 ++--- ...03-Fix-TFM-path-for-Test-CLI-package.patch | 31 +++++++++++++++++++ 2 files changed, 34 insertions(+), 4 deletions(-) create mode 100644 src/SourceBuild/patches/sdk/0003-Fix-TFM-path-for-Test-CLI-package.patch diff --git a/src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/BasicScenarioTests.cs b/src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/BasicScenarioTests.cs index e4d8094d0..af435cfdc 100644 --- a/src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/BasicScenarioTests.cs +++ b/src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/BasicScenarioTests.cs @@ -31,10 +31,9 @@ public class BasicScenarioTests : SmokeTests { yield return new(nameof(BasicScenarioTests), language, DotNetTemplate.Console, DotNetActions.Build | DotNetActions.Run | DotNetActions.PublishComplex | DotNetActions.PublishR2R); yield return new(nameof(BasicScenarioTests), language, DotNetTemplate.ClassLib, DotNetActions.Build | DotNetActions.Publish); - // TODO: Investigate and re-enable - dotnet test fails to find application - // yield return new(nameof(BasicScenarioTests), language, DotNetTemplate.XUnit, DotNetActions.Test); - // yield return new(nameof(BasicScenarioTests), language, DotNetTemplate.NUnit, DotNetActions.Test); - // yield return new(nameof(BasicScenarioTests), language, DotNetTemplate.MSTest, DotNetActions.Test); + yield return new(nameof(BasicScenarioTests), language, DotNetTemplate.XUnit, DotNetActions.Test); + yield return new(nameof(BasicScenarioTests), language, DotNetTemplate.NUnit, DotNetActions.Test); + yield return new(nameof(BasicScenarioTests), language, DotNetTemplate.MSTest, DotNetActions.Test); } } } diff --git a/src/SourceBuild/patches/sdk/0003-Fix-TFM-path-for-Test-CLI-package.patch b/src/SourceBuild/patches/sdk/0003-Fix-TFM-path-for-Test-CLI-package.patch new file mode 100644 index 000000000..cdc6b3332 --- /dev/null +++ b/src/SourceBuild/patches/sdk/0003-Fix-TFM-path-for-Test-CLI-package.patch @@ -0,0 +1,31 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Nikola Milosavljevic +Date: Fri, 21 Apr 2023 15:32:28 +0000 +Subject: [PATCH] Fix TFM path for Test CLI package + +Backport: https://github.com/dotnet/source-build/issues/3406 +--- + src/Layout/redist/targets/GenerateLayout.targets | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/src/Layout/redist/targets/GenerateLayout.targets b/src/Layout/redist/targets/GenerateLayout.targets +index 1bc37d90eb..f83c0b39f1 100644 +--- a/src/Layout/redist/targets/GenerateLayout.targets ++++ b/src/Layout/redist/targets/GenerateLayout.targets +@@ -195,7 +195,7 @@ + BeforeTargets="Build"> + + netcoreapp3.1 +- net7.0 ++ net8.0 + $(NuGetPackageRoot)/microsoft.testplatform.cli/$(MicrosoftTestPlatformCLIPackageVersion)/contentFiles/any/$(TestCliNuGetDirectoryTargetFramework)/ + + +@@ -210,6 +210,7 @@ + + ++ + + +