mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #6938 from sfoslund/DefaultVersionTests

Browse source 
Adding test coverage for DefaultRuntimeFrameworkVersions
This commit is contained in:
Sarah Oslund 2020-03-30 11:26:19 -07:00 committed by GitHub
commit 9722ea1895
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 86 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

86
test/EndToEnd/GivenUsingDefaultRuntimeFrameworkVersions.cs Normal file
View file

@ -0,0 +1,86 @@
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Xml.Linq;
using FluentAssertions;
using Microsoft.DotNet.Tools.Test.Utilities;
using NuGet.Versioning;
using Xunit;
namespace EndToEnd
{
public partial class GivenUsingDefaultRuntimeFrameworkVersions : TestBase
{
private static readonly IEnumerable<string> frameworks = new string[] {"Microsoft.NETCore.App", "Microsoft.WindowsDesktop.App",
"Microsoft.WindowsDesktop.App.WPF", "Microsoft.WindowsDesktop.App.WindowsForms", "Microsoft.AspNetCore.App" };
private static readonly IEnumerable<string> versions = SupportedNetCoreAppVersions.Versions.Where(version => NuGetVersion.Parse(version).Major >= 3);
[Fact]
public void DefaultRuntimeVersionsAreUpToDate()
{
var outputFile = "resolvedVersions.txt";
var testProjectCreator = new TestProjectCreator()
{
PackageName = "DefaultRuntimeVersionsAreUpToDate",
MinorVersion = "3.0"
};
var testProject = testProjectCreator.Create();
var projectFile = new DirectoryInfo(testProject.Root.FullName).GetFiles("*.csproj").First().FullName;
var project = XDocument.Load(projectFile);
string writeResolvedVersionsTarget = @$"
<Target Name=`WriteResolvedVersions` AfterTargets=`PrepareForBuild;ProcessFrameworkReferences`>
<ItemGroup>
<LinesToWrite Include=`%(KnownFrameworkReference.Identity) %(KnownFrameworkReference.DefaultRuntimeFrameworkVersion) %(KnownFrameworkReference.LatestRuntimeFrameworkVersion)`/>
</ItemGroup>
<WriteLinesToFile File=`$(OutputPath){ outputFile }`
Lines=`@(LinesToWrite)`
Overwrite=`true`
Encoding=`Unicode`/>
</Target>";
writeResolvedVersionsTarget = writeResolvedVersionsTarget.Replace('`', '"');
var targetElement = XElement.Parse(writeResolvedVersionsTarget);
var ns = project.Root.Name.Namespace;
foreach (var elem in targetElement.Descendants())
elem.Name = ns + elem.Name.LocalName;
targetElement.Name = ns + targetElement.Name.LocalName;
project.Root.Add(targetElement);
using (var file = File.CreateText(projectFile))
{
project.Save(file);
}
new RestoreCommand()
.WithWorkingDirectory(testProject.Root.FullName)
.Execute()
.Should().Pass();
var binDirectory = new DirectoryInfo(testProject.Root.FullName).Sub("bin").Sub("Debug").GetDirectories().FirstOrDefault();
binDirectory.Should().HaveFilesMatching(outputFile, SearchOption.TopDirectoryOnly);
var resolvedVersionsFile = File.ReadAllLines(Path.Combine(binDirectory.FullName, outputFile));
foreach (var framework in frameworks)
{
foreach (var version in versions)
{
var frameworkVersionLine = resolvedVersionsFile.Where(line => line.Contains(framework) && line.Contains(version)).FirstOrDefault();
frameworkVersionLine.Should().NotBeNullOrEmpty();
var defaultVersion = NuGetVersion.Parse(frameworkVersionLine.Split(" ")[1]);
var latestVersion = NuGetVersion.Parse(frameworkVersionLine.Split(" ")[2]);
if (latestVersion.Patch == 0 && latestVersion.IsPrerelease)
{
defaultVersion.Should().Be(latestVersion,
$"the DefaultRuntimeFrameworkVersion for { framework } { version } in Microsoft.NETCoreSdk.BundledVersions.props does not match latest prerelease version { latestVersion }");
}
else
{
defaultVersion.Should().Be(new NuGetVersion(latestVersion.Major, latestVersion.Minor, 0),
$"the DefaultRuntimeFrameworkVersion for { framework } { version } in Microsoft.NETCoreSdk.BundledVersions.props needs to be updated to { version }.0");
}
}
}
}
}
}