From 44d888dfc4ba1ea07bbc7be10302b8f652a2d3c7 Mon Sep 17 00:00:00 2001 From: Livar Cunha Date: Wed, 21 Jun 2017 08:48:12 -0700 Subject: [PATCH 1/3] Exclude satellite assemblies from archive. --- build/package/Archive.targets | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/build/package/Archive.targets b/build/package/Archive.targets index 54352ae27..4913a2374 100644 --- a/build/package/Archive.targets +++ b/build/package/Archive.targets @@ -14,19 +14,22 @@ $(ArchiveOutputDirectory)/%(GenerateArchivesInputsOutputs.OutFileName)$(ArchiveExtension) + *.resources.dll + OverwriteDestination="true" + ExcludePatterns="$(SatelliteAssemblies)" /> + OverwriteDestination="true" + ExcludePatterns="$(SatelliteAssemblies)" /> From 126ec29fe244e8e3702824d6647cda20c377668b Mon Sep 17 00:00:00 2001 From: Livar Cunha Date: Wed, 21 Jun 2017 22:27:28 -0700 Subject: [PATCH 2/3] Generating a layout folder with the satellite assemblies only which we use to generate a language pack tarball/zip. Initially, I wanted a IncludeOnlyFilter, but couldn't quite get that to work on tar, just passing the filter in the command line didn't work because the shell does not do recursive globbing. So, I opted for the layout folder. --- build/Branding.props | 2 ++ build/package/Archive.targets | 6 +++--- build/package/Layout.targets | 18 ++++++++++++++++++ 3 files changed, 23 insertions(+), 3 deletions(-) diff --git a/build/Branding.props b/build/Branding.props index 913041dac..209a12c1d 100644 --- a/build/Branding.props +++ b/build/Branding.props @@ -22,12 +22,14 @@ dotnet-sdk-internal dotnet-sdk-debug dotnet-sdk + $(ArtifactNameCombinedHostHostFxrFrameworkSdk)-langpack $(ArtifactNameSdk)-$(SdkVersion)-$(ProductMonikerRid) $(ArtifactNameSdkDebug)-$(SdkVersion)-$(ProductMonikerRid) $(ArtifactNameCombinedHostHostFxrFrameworkSdk)-$(SdkVersion)-$(ProductMonikerRid) + $(ArtifactNameSdkLanguagePack)-$(SdkVersion)-$(ProductMonikerRid) $(ArtifactNameCombinedHostHostFxrFrameworkSdk)-$(SdkVersion)-$(HostMonikerRid) diff --git a/build/package/Archive.targets b/build/package/Archive.targets index 4913a2374..d0cd63ae1 100644 --- a/build/package/Archive.targets +++ b/build/package/Archive.targets @@ -14,7 +14,6 @@ $(ArchiveOutputDirectory)/%(GenerateArchivesInputsOutputs.OutFileName)$(ArchiveExtension) - *.resources.dll + ExcludePatterns="%(GenerateArchivesInputsOutputs.ExcludePatterns)" /> + ExcludePatterns="%(GenerateArchivesInputsOutputs.ExcludePatterns)" /> @@ -45,6 +44,7 @@ $(ArchiveOutputDirectory)/%(LayoutDefinition.NameWithVersion)$(ArchiveExtension) $(LayoutDirectory)/%(LayoutDefinition.Name) %(LayoutDefinition.NameWithVersion) + %(LayoutDefinition.ExcludePatterns) diff --git a/build/package/Layout.targets b/build/package/Layout.targets index b9361c55d..6edb15076 100644 --- a/build/package/Layout.targets +++ b/build/package/Layout.targets @@ -3,6 +3,9 @@ $(LayoutDirectory)/$(ArtifactNameSdkDebug) $(LayoutDirectory)/$(ArtifactNameCombinedHostHostFxrFrameworkSdk) + $(LayoutDirectory)/$(ArtifactNameSdkLanguagePack) + *.resources.dll + .*.resources.dll @@ -11,6 +14,7 @@ + @@ -30,6 +34,11 @@ Path2="%(CombinedHostHostFxrFrameworkSdkInput.Identity)" > + + + @@ -52,6 +61,15 @@ @(CombinedHostHostFxrFrameworkSdkRelativeOutputFiles -> '$(CombinedHostHostFxrFrameworkSdkOutputDirectory)/%(Identity)') $(ArtifactNameWithVersionCombinedHostHostFxrFrameworkSdk) $(ArtifactNameCombinedHostHostFxrFrameworkSdk) + $(WindowsSatelliteAssembliesRegEx) + $(SatelliteAssemblies) + + + + @(SdkLanguagePackInput) + @(SdkLanguagePackRelativeOutputFiles -> '$(SdkLanguagePackOutputDirectory)/%(Identity)') + $(ArtifactNameWithVersionSdkLanguagePack) + $(ArtifactNameSdkLanguagePack) From 6fc24fca4fe5a0c8cfcdddc7ea17f0a1da229321 Mon Sep 17 00:00:00 2001 From: Livar Date: Mon, 26 Jun 2017 17:00:35 -0700 Subject: [PATCH 3/3] Updating the runtime to pick up the satellite assembly host fix. --- build/DependencyVersions.props | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/build/DependencyVersions.props b/build/DependencyVersions.props index 71abf62a5..80a2bb7f4 100644 --- a/build/DependencyVersions.props +++ b/build/DependencyVersions.props @@ -1,7 +1,7 @@ - 2.0.0-preview3-25419-01 + 2.0.0-preview3-25426-01 15.3.0-preview-000388-01 2.3.0-beta3-61816-04 1.6.0-beta2-25304 @@ -23,8 +23,8 @@ 1.0.0-beta2-20170608-254 1.0.0-beta2-20170612-258 1.0.0-beta2-20170612-258 - 2.0.0-preview3-25419-01 - 2.0.0-preview3-25419-01 + 2.0.0-preview3-25426-01 + 2.0.0-preview3-25426-01 0.1.0-alpha-142 1.2.1-alpha-002133 0.2.0