mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Address code review feedback

Browse source
This commit is contained in:
Daniel Plaisted 2018-07-09 14:12:11 -07:00
parent 75e0dbb45d
commit 905d4d442d
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
build/TargetFramework.props
View file

@ -1,7 +1,9 @@
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> <Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup> <PropertyGroup>
<CliTargetFramework>netcoreapp3.0</CliTargetFramework> <CliTargetFramework>netcoreapp3.0</CliTargetFramework>
<!-- We only need this until we get a stage0 with a 3.0 SDK. -->
<!-- Workaround until the stage0 SDK supports .NET Core 3.0.
It won't hurt anything to leave this in though. -->
<NETCoreAppMaximumVersion>3.0</NETCoreAppMaximumVersion> <NETCoreAppMaximumVersion>3.0</NETCoreAppMaximumVersion>
</PropertyGroup> </PropertyGroup>
</Project> </Project>

1
test/EndToEnd/GivenDotNetUsesMSBuild.cs
View file

@ -30,6 +30,7 @@ namespace Microsoft.DotNet.Tests.EndToEnd
string projectPath = Directory.GetFiles(projectDirectory, "*.csproj").Single(); string projectPath = Directory.GetFiles(projectDirectory, "*.csproj").Single();
// Override TargetFramework since there aren't .NET Core 3 templates yet // Override TargetFramework since there aren't .NET Core 3 templates yet
// https://github.com/dotnet/core-sdk/issues/24 tracks removing this workaround
XDocument project = XDocument.Load(projectPath); XDocument project = XDocument.Load(projectPath);
var ns = project.Root.Name.Namespace; var ns = project.Root.Name.Namespace;
project.Root.Element(ns + "PropertyGroup") project.Root.Element(ns + "PropertyGroup")