PR Feedback
This commit is contained in:
parent
568eb3aae7
commit
8fa642d424
5 changed files with 12 additions and 9 deletions
|
@ -55,11 +55,12 @@ Make sure to use the System.CommandLine parser so behavior is consistant across
|
||||||
Each command's project root should contain a manpage-style Readme.md that describes the usage of the command. See other commands for reference.
|
Each command's project root should contain a manpage-style Readme.md that describes the usage of the command. See other commands for reference.
|
||||||
|
|
||||||
#### Add project to build scripts
|
#### Add project to build scripts
|
||||||
1. Add the project to /scripts/build/build-stage.ps1
|
1. Add the project to `/scripts/build/build-stage.ps1`
|
||||||
- Add the project name to the `$Projects` list
|
- Add the project name to the `$Projects` list
|
||||||
2. Add the project to /scripts/build/build-stage.sh
|
2. Add the project to `/scripts/build/build-stage.sh`
|
||||||
- Add the project name to the `PROJECTS` list
|
- Add the project name to the `PROJECTS` list
|
||||||
3. run *build* from the root directory and make sure your project is producing binaries in /artifacts/
|
3. run *build* from the root directory and make sure your project is producing binaries in /artifacts/
|
||||||
|
|
||||||
#### Add command to packages
|
#### Add command to packages
|
||||||
- Update the symlinks property of debian_config.json to include the new command
|
- Update the `symlinks` property of `packaging/debian/debian_config.json` to include the new command
|
||||||
|
- Update the `$Projects` property in `packaging/osx/scripts/postinstall`
|
|
@ -1,3 +1,3 @@
|
||||||
{
|
{
|
||||||
"projects": ["src", "test"]
|
"projects": [ "src", "test" ],
|
||||||
}
|
}
|
|
@ -7,11 +7,14 @@
|
||||||
ln -s $2/bin/dotnet /usr/local/bin/
|
ln -s $2/bin/dotnet /usr/local/bin/
|
||||||
ln -s $2/bin/dotnet-compile /usr/local/bin/
|
ln -s $2/bin/dotnet-compile /usr/local/bin/
|
||||||
ln -s $2/bin/dotnet-compile-csc /usr/local/bin/
|
ln -s $2/bin/dotnet-compile-csc /usr/local/bin/
|
||||||
|
ln -s $2/bin/dotnet-new /usr/local/bin/
|
||||||
|
ln -s $2/bin/dotnet-pack /usr/local/bin/
|
||||||
ln -s $2/bin/dotnet-publish /usr/local/bin/
|
ln -s $2/bin/dotnet-publish /usr/local/bin/
|
||||||
|
ln -s $2/bin/dotnet-repl /usr/local/bin/
|
||||||
ln -s $2/bin/dotnet-restore /usr/local/bin/
|
ln -s $2/bin/dotnet-restore /usr/local/bin/
|
||||||
ln -s $2/bin/dotnet-restore /usr/local/bin/
|
|
||||||
ln -s $2/bin/dotnet-init /usr/local/bin/
|
|
||||||
ln -s $2/bin/dotnet-resgen /usr/local/bin/
|
ln -s $2/bin/dotnet-resgen /usr/local/bin/
|
||||||
|
ln -s $2/bin/dotnet-run /usr/local/bin/
|
||||||
|
ln -s $2/bin/dotnet-test /usr/local/bin/
|
||||||
|
|
||||||
# A temporary solution to unblock dotnet compile
|
# A temporary solution to unblock dotnet compile
|
||||||
cp $2/bin/corehost /usr/local/bin/
|
cp $2/bin/corehost /usr/local/bin/
|
||||||
|
|
|
@ -7,11 +7,10 @@
|
||||||
<Import Project="$(VSToolsPath)\DNX\Microsoft.DNX.Props" Condition="'$(VSToolsPath)' != ''" />
|
<Import Project="$(VSToolsPath)\DNX\Microsoft.DNX.Props" Condition="'$(VSToolsPath)' != ''" />
|
||||||
<PropertyGroup Label="Globals">
|
<PropertyGroup Label="Globals">
|
||||||
<ProjectGuid>bc765fbf-ad7a-4a99-9902-5540c5a74181</ProjectGuid>
|
<ProjectGuid>bc765fbf-ad7a-4a99-9902-5540c5a74181</ProjectGuid>
|
||||||
<RootNamespace>Microsoft.DotNet.Tools.Init</RootNamespace>
|
<RootNamespace>Microsoft.DotNet.Tools.New</RootNamespace>
|
||||||
<BaseIntermediateOutputPath Condition="'$(BaseIntermediateOutputPath)'=='' ">..\..\artifacts\obj\$(MSBuildProjectName)</BaseIntermediateOutputPath>
|
<BaseIntermediateOutputPath Condition="'$(BaseIntermediateOutputPath)'=='' ">..\..\artifacts\obj\$(MSBuildProjectName)</BaseIntermediateOutputPath>
|
||||||
<OutputPath Condition="'$(OutputPath)'=='' ">..\..\artifacts\bin\$(MSBuildProjectName)\</OutputPath>
|
<OutputPath Condition="'$(OutputPath)'=='' ">..\..\artifacts\bin\$(MSBuildProjectName)\</OutputPath>
|
||||||
</PropertyGroup>
|
</PropertyGroup>
|
||||||
|
|
||||||
<PropertyGroup>
|
<PropertyGroup>
|
||||||
<SchemaVersion>2.0</SchemaVersion>
|
<SchemaVersion>2.0</SchemaVersion>
|
||||||
</PropertyGroup>
|
</PropertyGroup>
|
||||||
|
|
|
@ -78,7 +78,7 @@ namespace Microsoft.DotNet.Tools.New
|
||||||
app.HelpOption("-h|--help");
|
app.HelpOption("-h|--help");
|
||||||
|
|
||||||
var dotnetNew = new Program();
|
var dotnetNew = new Program();
|
||||||
app.OnExecute((Func<int>)dotnetNew.CreateEmptyProject);
|
app.OnExecute(() => dotnetNew.CreateEmptyProject());
|
||||||
|
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
|
|
Loading…
Add table
Reference in a new issue