Stop publishing of additional packages in fsharp (#19404)

This commit is contained in:
Nikola Milosavljevic 2024-04-10 15:25:11 -07:00 committed by GitHub
parent a72af0f407
commit 8f9999e885
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 42 additions and 1 deletions

View file

@ -598,7 +598,18 @@
<Copy SourceFiles="@(PackageVersionPropsSnapshotFiles)" DestinationFolder="$(PackageReportDir)snapshots/" />
<ItemGroup>
<RestoredPackageFile Include="$(NuGetPackageRoot)**/*.nupkg"
<!--
Note the usage of */*/*.nupkg and not **/*.nupkg. The latter would include nupkgs
carried as content, i.e. in Microsoft.FSharp.Compiler nupkg, and cause false positives.
Content nupkgs were not restored and should not be used in prebuit detection.
Example of a restored package:
$(NuGetPackageRoot)microsoft.fsharp.compiler/12.8.300-beta.24203.1/microsoft.fsharp.compiler.12.8.300-beta.24203.1.nupkg
Example of a content package:
$(NuGetPackageRoot)microsoft.fsharp.compiler/12.8.300-beta.24203.1/contentFiles/Release/FSharp.Core.8.0.300.nupkg
-->
<RestoredPackageFile Include="$(NuGetPackageRoot)*/*/*.nupkg"
Exclude="$(NuGetPackageRoot)tests/**/*.nupkg" />
<!-- Only contains packages when building. -->

View file

@ -0,0 +1,30 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Nikola Milosavljevic <nikolam@microsoft.com>
Date: Wed, 10 Apr 2024 15:26:09 +0000
Subject: [PATCH] Stop publishing of additional packages
Backport: https://github.com/dotnet/fsharp/pull/17016
---
eng/Publishing.props | 13 -------------
1 file changed, 13 deletions(-)
delete mode 100644 eng/Publishing.props
diff --git a/eng/Publishing.props b/eng/Publishing.props
deleted file mode 100644
index 6a0673b5a..000000000
--- a/eng/Publishing.props
+++ /dev/null
@@ -1,13 +0,0 @@
-<Project>
-
- <ItemGroup>
- <!--
- Additional packages needed to avoid prebuilts in VMR - https://github.com/dotnet/source-build/issues/4203
- -->
- <ItemsToPushToBlobFeed Include="$(ArtifactsPackagesDir)Dependency\**\*.nupkg"
- IsShipping="true"
- UploadPathSegment="Runtime"
- Condition="'$(DotNetBuildSourceOnly)' == 'true'" />
- </ItemGroup>
-
-</Project>