mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Don't autoredirect and check for correct aka.ms redirect code

Browse source
This commit is contained in:
Jackson Schuster 2024-02-22 15:32:02 -08:00
parent a3256e2d70
commit 8c32f67bad
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/SourceBuild/content/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.SdkArchiveDiff/GetClosestOfficialSdk.cs
View file

@ -29,8 +29,19 @@ public class GetClosestOfficialSdk : Microsoft.Build.Utilities.Task
string downloadUrl = GetLatestOfficialSdkUrl(versionString, rid, extension); string downloadUrl = GetLatestOfficialSdkUrl(versionString, rid, extension);
Log.LogMessage($"Downloading {downloadUrl}"); Log.LogMessage($"Downloading {downloadUrl}");
var packageResponse = await new HttpClient().GetAsync(downloadUrl); var handler = new HttpClientHandler()
packageResponse.EnsureSuccessStatusCode(); {
AllowAutoRedirect = false
};
var client = new HttpClient(handler);
var redirectResponse = await client.GetAsync(downloadUrl);
// aka.ms returns a 301 for valid redirects and a 302 to Bing for invalid URLs
if (redirectResponse.StatusCode != HttpStatusCode.Moved)
{
Log.LogMessage(MessageImportance.High, $"Failed to download '{downloadUrl}': invalid aka.ms URL");
return true;
}
var packageResponse = await client.GetAsync(redirectResponse.Headers.Location!);
var packageUriPath = packageResponse.RequestMessage!.RequestUri!.LocalPath; var packageUriPath = packageResponse.RequestMessage!.RequestUri!.LocalPath;
string downloadedVersion = PathWithVersions.GetVersionInPath(packageUriPath).ToString(); string downloadedVersion = PathWithVersions.GetVersionInPath(packageUriPath).ToString();