Merge pull request #5757 from dotnet/dev/jgoshi/enableSolutionBuildTestsRel100
Re-enable solution building tests
This commit is contained in:
commit
899fde25bd
11 changed files with 13 additions and 16 deletions
|
@ -95,7 +95,7 @@ namespace Microsoft.DotNet.Migration.Tests
|
|||
{
|
||||
MigrateAndBuild(
|
||||
"NonRestoredTestProjects",
|
||||
"PJAppWithSlnAndXprojRefThatRefsCsprojWhereSlnDoesNotRefCsproj");
|
||||
"PJAppWithSlnThatDoesNotRefCsproj");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
|
@ -229,11 +229,10 @@ namespace Microsoft.DotNet.Migration.Tests
|
|||
.Execute($"restore \"{solutionRelPath}\"")
|
||||
.Should().Pass();
|
||||
|
||||
//ISSUE: https://github.com/dotnet/cli/issues/5205
|
||||
//new DotnetCommand()
|
||||
// .WithWorkingDirectory(projectDirectory)
|
||||
// .Execute($"build \"{solutionRelPath}\"")
|
||||
// .Should().Pass();
|
||||
new DotnetCommand()
|
||||
.WithWorkingDirectory(projectDirectory)
|
||||
.Execute($"build \"{solutionRelPath}\"")
|
||||
.Should().Pass();
|
||||
}
|
||||
|
||||
private void MigrateAndBuild(string groupName, string projectName, [CallerMemberName] string callingMethod = "", string identifier = "")
|
||||
|
@ -257,11 +256,10 @@ namespace Microsoft.DotNet.Migration.Tests
|
|||
.Execute($"restore \"{solutionRelPath}\"")
|
||||
.Should().Pass();
|
||||
|
||||
//ISSUE: https://github.com/dotnet/cli/issues/5205
|
||||
//new DotnetCommand()
|
||||
// .WithWorkingDirectory(projectDirectory)
|
||||
// .Execute($"build \"{solutionRelPath}\"")
|
||||
// .Should().Pass();
|
||||
new DotnetCommand()
|
||||
.WithWorkingDirectory(projectDirectory)
|
||||
.Execute($"build \"{solutionRelPath}\"")
|
||||
.Should().Pass();
|
||||
|
||||
SlnFile slnFile = SlnFile.Read(Path.Combine(projectDirectory.FullName, solutionRelPath));
|
||||
|
||||
|
|
|
@ -452,11 +452,10 @@ EndGlobal
|
|||
cmd.StdErr.Should().BeEmpty();
|
||||
}
|
||||
|
||||
//ISSUE: https://github.com/dotnet/cli/issues/5205
|
||||
//[Theory]
|
||||
//[InlineData("TestAppWithSlnAndCsprojFiles")]
|
||||
//[InlineData("TestAppWithSlnAndCsprojProjectGuidFiles")]
|
||||
//[InlineData("TestAppWithEmptySln")]
|
||||
[Theory]
|
||||
[InlineData("TestAppWithSlnAndCsprojFiles")]
|
||||
[InlineData("TestAppWithSlnAndCsprojProjectGuidFiles")]
|
||||
[InlineData("TestAppWithEmptySln")]
|
||||
public void WhenValidProjectIsPassedTheSlnBuilds(string testAsset)
|
||||
{
|
||||
var projectDirectory = TestAssets
|
||||
|
|
Loading…
Reference in a new issue