From dad4407de35fcfe946ae019c541a0538efd629df Mon Sep 17 00:00:00 2001 From: Eric StJohn Date: Tue, 5 Oct 2021 22:35:57 -0700 Subject: [PATCH 1/3] Use WIX_NATIVE_MACHINE to detect native architecture of target machine --- .../packaging/windows/clisdk/bundle.wxs | 19 +++++----------- .../windows/clisdk/dotnethome_x64.wxs | 22 +++++++++++-------- .../packaging/windows/clisdk/variables.wxi | 7 ++++++ 3 files changed, 25 insertions(+), 23 deletions(-) diff --git a/src/redist/targets/packaging/windows/clisdk/bundle.wxs b/src/redist/targets/packaging/windows/clisdk/bundle.wxs index 40b118b73..926929aa6 100644 --- a/src/redist/targets/packaging/windows/clisdk/bundle.wxs +++ b/src/redist/targets/packaging/windows/clisdk/bundle.wxs @@ -20,7 +20,7 @@ - WixBundleInstalled OR (NOT DOTNETHOME_ARM64 ~= DOTNETHOME_X64) OR (NOT NativeProcessorArchitecture="ARM64") OR DOTNETHOMESIMILARITYCHECKOVERRIDE + WixBundleInstalled OR (NOT DOTNETHOME_ARM64 ~= DOTNETHOME_X64) OR (NOT NativeMachine="$(var.NativeMachine_arm64)") OR DOTNETHOMESIMILARITYCHECKOVERRIDE @@ -76,21 +76,12 @@ Root="HKLM" Key="SOFTWARE\dotnet\Setup\InstalledVersions\x64" Value="InstallLocation" /> - - - - + - + - + - + - ? + - + - NOT %PROCESSOR_ARCHITECTURE="$(var.InstallerArchitecture)" + + VersionNT64 OR + + WIX_NATIVE_MACHINE AND NOT WIX_NATIVE_MACHINE="$(var.InstallerNativeMachine)" diff --git a/src/redist/targets/packaging/windows/clisdk/variables.wxi b/src/redist/targets/packaging/windows/clisdk/variables.wxi index bad1ff7ef..aa574750b 100644 --- a/src/redist/targets/packaging/windows/clisdk/variables.wxi +++ b/src/redist/targets/packaging/windows/clisdk/variables.wxi @@ -15,7 +15,14 @@ + + + + + + From 95a827266872e2e58b0b5741d162f02a438fbab9 Mon Sep 17 00:00:00 2001 From: Jacques Eloff Date: Tue, 5 Oct 2021 15:50:59 -0700 Subject: [PATCH 2/3] Update WiX to 3.14.0.5722 (#12252) --- eng/Versions.props | 2 +- src/redist/targets/GenerateMSIs.targets | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/Versions.props b/eng/Versions.props index 6d9de8dd3..8af72c3c0 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -108,7 +108,7 @@ $(MicrosoftNETCoreAppRuntimePackageVersion) - 1.0.0-v3.14.0.4118 + 1.0.0-v3.14.0.5722 diff --git a/src/redist/targets/GenerateMSIs.targets b/src/redist/targets/GenerateMSIs.targets index c4d4b28ba..3014fcfbd 100644 --- a/src/redist/targets/GenerateMSIs.targets +++ b/src/redist/targets/GenerateMSIs.targets @@ -13,7 +13,7 @@ - 1.0.0-v3.14.0.4118 + $(WixPackageVersion) https://netcorenativeassets.blob.core.windows.net/resource-packages/external/windows/wix/Microsoft.Signed.Wix-$(WixVersion).zip $(ArtifactsDir)Tools/WixTools/$(WixVersion) $(WixRoot)/WixTools.$(WixVersion).zip From 9230a610cc47e1e11c0b429a6e9a0583de030361 Mon Sep 17 00:00:00 2001 From: Eric StJohn Date: Wed, 6 Oct 2021 07:06:48 -0700 Subject: [PATCH 3/3] Ensure we reference WIX_NATIVE_MACHINE property --- .../targets/packaging/windows/clisdk/dotnethome_x64.wxs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/redist/targets/packaging/windows/clisdk/dotnethome_x64.wxs b/src/redist/targets/packaging/windows/clisdk/dotnethome_x64.wxs index a2e9aab9c..d62c71b0e 100644 --- a/src/redist/targets/packaging/windows/clisdk/dotnethome_x64.wxs +++ b/src/redist/targets/packaging/windows/clisdk/dotnethome_x64.wxs @@ -18,9 +18,10 @@ - + VersionNT64 OR