mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

case insensitive msbuild metadata findng

Browse source
This commit is contained in:
Bryan Thornbury 2016-09-21 11:31:30 -07:00
parent 362f71a94a
commit 875d91629e
2 changed files with 12 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/Microsoft.DotNet.ProjectJsonMigration/MSBuildExtensions.cs
View file

@ -171,20 +171,7 @@ namespace Microsoft.DotNet.ProjectJsonMigration
public static ProjectMetadataElement GetMetadataWithName(this ProjectItemElement item, string name)
{
return item.Metadata.FirstOrDefault(m => m.Name.Equals(name, StringComparison.Ordinal));
}
public static bool HasConflictingMetadata(this ProjectItemElement item, ProjectItemElement otherItem)
{
foreach (var metadata in item.Metadata)
{
if (otherItem.Metadata.Any(m => m.Name == metadata.Name && m.Value != metadata.Value))
{
return true;
}
}
return false;
return item.Metadata.FirstOrDefault(m => m.Name.Equals(name, StringComparison.OrdinalIgnoreCase));
}
public static void AddMetadata(this ProjectItemElement item, ProjectMetadataElement metadata)

11
test/Microsoft.DotNet.ProjectJsonMigration.Tests/GivenMSBuildExtensions.cs
View file

@ -129,6 +129,17 @@ namespace Microsoft.DotNet.ProjectJsonMigration.Tests
item1.ConditionChainsAreEquivalent(item2).Should().BeFalse();
}
[Fact]
public void GetMetadataWithName_is_case_insensitive()
{
var project = ProjectRootElement.Create();
var item1 = project.AddItem("test", "include1");
item1.AddMetadata("name", "value");
item1.GetMetadataWithName("Name").Should().NotBeNull();
item1.GetMetadataWithName("Name").Value.Should().Be("value");
}
[Fact]
public void HasConflictingMetadata_returns_true_when_items_have_metadata_with_same_name_but_different_value()
{