Apply suggestions from code review

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
This commit is contained in:
Daniel Plaisted 2020-11-20 10:06:32 -08:00 committed by GitHub
parent 096e69de3a
commit 833bfd10b5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -170,7 +170,7 @@
</ItemGroup> </ItemGroup>
<PropertyGroup> <PropertyGroup>
<PortableProduktMonikerRid Condition="'$(PortableProduktMonikerRid)' == ''">$(ProductMonikerRid)</PortableProduktMonikerRid> <PortableProductMonikerRid Condition="'$(PortableProductMonikerRid)' == ''">$(ProductMonikerRid)</PortableProductMonikerRid>
</PropertyGroup> </PropertyGroup>
@ -202,7 +202,7 @@ Copyright (c) .NET Foundation. All rights reserved.
<BundledRuntimeIdentifierGraphFile>%24(MSBuildThisFileDirectory)RuntimeIdentifierGraph.json</BundledRuntimeIdentifierGraphFile> <BundledRuntimeIdentifierGraphFile>%24(MSBuildThisFileDirectory)RuntimeIdentifierGraph.json</BundledRuntimeIdentifierGraphFile>
<NETCoreSdkVersion>$(Version)</NETCoreSdkVersion> <NETCoreSdkVersion>$(Version)</NETCoreSdkVersion>
<NETCoreSdkRuntimeIdentifier>$(ProductMonikerRid)</NETCoreSdkRuntimeIdentifier> <NETCoreSdkRuntimeIdentifier>$(ProductMonikerRid)</NETCoreSdkRuntimeIdentifier>
<NETCoreSdkPortableRuntimeIdentifier>$(PortableProduktMonikerRid)</NETCoreSdkPortableRuntimeIdentifier> <NETCoreSdkPortableRuntimeIdentifier>$(PortableProductMonikerRid)</NETCoreSdkPortableRuntimeIdentifier>
<_NETCoreSdkIsPreview>$(_NETCoreSdkBeingBuiltIsPreview)</_NETCoreSdkIsPreview> <_NETCoreSdkIsPreview>$(_NETCoreSdkBeingBuiltIsPreview)</_NETCoreSdkIsPreview>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>
@ -523,7 +523,7 @@ Copyright (c) .NET Foundation. All rights reserved.
SkipUnchangedFiles="true"/> SkipUnchangedFiles="true"/>
<GenerateSdkRuntimeIdentifierChain <GenerateSdkRuntimeIdentifierChain
RuntimeIdentifier="$(PortableProduktMonikerRid)" RuntimeIdentifier="$(PortableProductMonikerRid)"
RuntimeIdentifierGraphPath="$(SdkOutputDirectory)RuntimeIdentifierGraph.json" RuntimeIdentifierGraphPath="$(SdkOutputDirectory)RuntimeIdentifierGraph.json"
RuntimeIdentifierChainOutputPath="$(SdkOutputDirectory)NETCoreSdkRuntimeIdentifierChain.txt"/> RuntimeIdentifierChainOutputPath="$(SdkOutputDirectory)NETCoreSdkRuntimeIdentifierChain.txt"/>