From 61c1e3e1047d4f2fb7906397603d2678c31f0d07 Mon Sep 17 00:00:00 2001 From: Justin Goshi Date: Mon, 27 Feb 2017 11:06:44 -0800 Subject: [PATCH] Remove duplicate properties --- build/Compile.targets | 14 ++++---- build/OutputDirectories.props | 16 ++++----- build/Signing.proj | 34 +++++++++---------- build/Test.targets | 14 ++++---- build/compile/LzmaArchive.targets | 12 +++---- build/package/Installer.DEB.targets | 17 ++++------ build/package/Layout.targets | 10 +++--- build/package/Nupkg.targets | 2 +- .../InvokeWithStage0.proj | 4 +-- src/redist/redist.csproj | 4 +-- src/tool_roslyn/tool_roslyn.csproj | 2 +- 11 files changed, 60 insertions(+), 69 deletions(-) diff --git a/build/Compile.targets b/build/Compile.targets index 221c49624..a4b23c597 100644 --- a/build/Compile.targets +++ b/build/Compile.targets @@ -8,7 +8,7 @@ $(NuGetPackagesDir)/$(RuntimeNETCoreAppPackageName)/$(CLI_SharedFrameworkVersion)/runtimes/$(CoreCLRRid)/native/$(DynamicLibPrefix)clrjit$(DynamicLibExtension) $(RepoRoot)/resources/MSBuildImports $(SdkOutputDirectory)/runtimes/any/native - $(StageDirectory)/shared/$(SharedFrameworkName)/$(SharedFrameworkVersion) + $(OutputDirectory)/shared/$(SharedFrameworkName)/$(SharedFrameworkVersion) @@ -24,8 +24,8 @@ GetNuGetPackagesArchive;" /> - - + + - + - - + + + DestinationFiles="@(FilesToCopy->'$(SymbolsDirectory)\%(RecursiveDir)%(Filename)%(Extension)')" /> diff --git a/build/OutputDirectories.props b/build/OutputDirectories.props index 07f70c2af..467b64964 100644 --- a/build/OutputDirectories.props +++ b/build/OutputDirectories.props @@ -1,19 +1,15 @@ $(RepoRoot)/artifacts/$(Rid) - $(BaseOutputDirectory)/stage2 - $(BaseOutputDirectory)/stage2symbols - $(Stage2Directory)/sdk/$(SdkVersion) - $(Stage2SdkDirectory)/Roslyn - $(Stage2Directory)/dotnet$(ExeExtension) - $(Stage2Directory)/ - $(BaseOutputDirectory)/stage2compilation - $(Stage2Directory) - $(Stage2SymbolsDirectory) - $(Stage2SdkDirectory) + $(BaseOutputDirectory)/stage2 + $(OutputDirectory)/sdk/$(SdkVersion) + $(BaseOutputDirectory)/stage2symbols + $(SdkOutputDirectory)/Roslyn + $(BaseOutputDirectory)/stage2compilation $(BaseOutputDirectory)/intermediate $(BaseOutputDirectory)/packages $(IntermediateDirectory)/sharedFrameworkPublish $(RepoRoot)/artifacts/testpackages/ + $(OutputDirectory)/dotnet$(ExeExtension) diff --git a/build/Signing.proj b/build/Signing.proj index 06581504a..267f0c975 100644 --- a/build/Signing.proj +++ b/build/Signing.proj @@ -15,8 +15,8 @@ $(RepoRoot)/artifacts/$(Rid) - $(BaseOutputDirectory)/stage2 - $(BaseOutputDirectory)/stage2compilation + $(BaseOutputDirectory)/stage2 + $(BaseOutputDirectory)/stage2compilation $(BaseOutputDirectory)/packages - + $(ExternalCertificateId) - + $(InternalCertificateId) - + $(InternalCertificateId) diff --git a/build/Test.targets b/build/Test.targets index 5f49cd97a..f7346d9d7 100644 --- a/build/Test.targets +++ b/build/Test.targets @@ -5,8 +5,8 @@ : %3b - $(Stage2Directory)$(PathListSeparator)$(PATH) - $(Stage2Directory) + $(OutputDirectory)$(PathListSeparator)$(PATH) + $(OutputDirectory) $(TestOutputDir)/packages/ $(TestOutputDir)/artifacts/ $(TestOutputDir)/results/ @@ -28,13 +28,13 @@ - CLIBuildDll=$(CLIBuildDll); + CLIBuildDll=$(CLIBuildDll); Configuration=$(Configuration); EnvironmentVariables=$(RunTestEnvironmentVariables); TestProject=%(TestProjects.Identity); TestResultXmlDir=$(TestResultXmlDir); - ToolPath=$(Stage2Directory); - WorkingDirectory=$([System.IO.Directory]::GetParent(%(TestProjects.Identity))) + ToolPath=$(OutputDirectory); + WorkingDirectory=$([System.IO.Directory]::GetParent(%(TestProjects.Identity))) @@ -73,7 +73,7 @@ DependsOnTargets="SetupTestPackageProjectData;" Outputs="%(TestPackageProject.Identity)"> - @@ -87,7 +87,7 @@ - diff --git a/build/compile/LzmaArchive.targets b/build/compile/LzmaArchive.targets index ad985a06c..61c22c8b5 100644 --- a/build/compile/LzmaArchive.targets +++ b/build/compile/LzmaArchive.targets @@ -16,7 +16,7 @@ $(NuGetPackagesArchiveProject)/Nuget.config $(BaseOutputDirectory)/tools $(ToolsOutputDirectory)/Archiver.dll - $(Stage2Directory)/sdk/$(SdkVersion)/nuGetPackagesArchive.lzma + $(SdkOutputDirectory)/nuGetPackagesArchive.lzma - - @@ -103,17 +103,17 @@ - - + - + diff --git a/build/package/Installer.DEB.targets b/build/package/Installer.DEB.targets index 1c116f00f..5a3443c9d 100644 --- a/build/package/Installer.DEB.targets +++ b/build/package/Installer.DEB.targets @@ -1,8 +1,7 @@ - $(SdkVersion) - dotnet-dev-$(SdkDebianPackageVersion) + dotnet-dev-$(SdkVersion) @@ -27,19 +26,15 @@ - $(SharedFrameworkVersion) - dotnet-sharedframework-$(SharedFrameworkName)-$(SharedFxDebianPackageVersion) + dotnet-sharedframework-$(SharedFrameworkName)-$(SharedFrameworkVersion) $(SharedFxDebianPackageName.ToLower()) - $(HostFxrVersion) - dotnet-hostfxr-$(HostFxrDebianPackageVersion) + dotnet-hostfxr-$(HostFxrVersion) $(HostFxrDebianPackageName.ToLower()) dotnet-host - $(AdditionalSharedFrameworkVersion) - dotnet-sharedframework-$(SharedFrameworkName)-$(AdditionalSharedFxDebianPackageVersion) + dotnet-sharedframework-$(SharedFrameworkName)-$(AdditionalSharedFrameworkVersion) $(AdditionalSharedFxDebianPackageName.ToLower()) - $(AdditionalHostFxrVersion) - dotnet-hostfxr-$(AdditionalHostFxrDebianPackageVersion) + dotnet-hostfxr-$(AdditionalHostFxrVersion) $(AdditionalHostFxrDebianPackageName.ToLower()) @@ -47,7 +42,7 @@ $(RepoRoot)/Documentation/manpages $(RepoRoot)/test/EndToEnd/EndToEnd.csproj - $(Stage2Directory)/sdk + $(OutputDirectory)/sdk diff --git a/build/package/Layout.targets b/build/package/Layout.targets index ff65dfade..cdbb5b13d 100644 --- a/build/package/Layout.targets +++ b/build/package/Layout.targets @@ -10,29 +10,29 @@ - + diff --git a/build/package/Nupkg.targets b/build/package/Nupkg.targets index 86ffdcecb..b1570c596 100644 --- a/build/package/Nupkg.targets +++ b/build/package/Nupkg.targets @@ -1,7 +1,7 @@ - $(Stage2CompilationDirectory)/forPackaging + $(CompilationDirectory)/forPackaging $(PackagesDirectory) diff --git a/build_projects/Microsoft.DotNet.Cli.Build.SelfTest/InvokeWithStage0.proj b/build_projects/Microsoft.DotNet.Cli.Build.SelfTest/InvokeWithStage0.proj index 4175b21fc..6a85183ca 100644 --- a/build_projects/Microsoft.DotNet.Cli.Build.SelfTest/InvokeWithStage0.proj +++ b/build_projects/Microsoft.DotNet.Cli.Build.SelfTest/InvokeWithStage0.proj @@ -3,7 +3,7 @@ - + \ No newline at end of file diff --git a/src/redist/redist.csproj b/src/redist/redist.csproj index fcd5c6848..f51c1fea4 100644 --- a/src/redist/redist.csproj +++ b/src/redist/redist.csproj @@ -9,7 +9,7 @@ true false $(PackageTargetFallback);dotnet5.4 - $(Stage2SdkDirectory) + $(SdkOutputDirectory) $(CommitCount) @@ -42,7 +42,7 @@ + DestinationFiles="@(SharedFramework->'$(OutputDirectory)/%(RecursiveDir)%(Filename)%(Extension)')" /> netcoreapp2.0 $(CLI_SharedFrameworkVersion) true - $(Stage2RoslynDirectory) + $(RoslynDirectory) $(CommitCount)