mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Changing the /m /v:m default parameters to msbuild to -m and -v:m to avoid confusing that with files on unix machines.

Browse source
This commit is contained in:
Livar Cunha 2018-04-02 12:41:21 -07:00
parent 6b240926a3
commit 7c37c9a069
7 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/Microsoft.DotNet.Cli.Utils/MSBuildForwardingAppWithoutLogging.cs
View file

@ -28,7 +28,7 @@ namespace Microsoft.DotNet.Cli.Utils
}; };
private readonly IEnumerable<string> _msbuildRequiredParameters = private readonly IEnumerable<string> _msbuildRequiredParameters =
new List<string> { "/m", "/v:m" }; new List<string> { "-m", "-v:m" };
public MSBuildForwardingAppWithoutLogging(IEnumerable<string> argsToForward, string msbuildPath = null) public MSBuildForwardingAppWithoutLogging(IEnumerable<string> argsToForward, string msbuildPath = null)
{ {

2
test/dotnet-msbuild.Tests/GivenDotnetBuildInvocation.cs
View file

@ -9,7 +9,7 @@ namespace Microsoft.DotNet.Cli.MSBuild.Tests
{ {
public class GivenDotnetBuildInvocation public class GivenDotnetBuildInvocation
{ {
const string ExpectedPrefix = "exec <msbuildpath> /m /v:m"; const string ExpectedPrefix = "exec <msbuildpath> -m -v:m";
[Theory] [Theory]
[InlineData(new string[] { }, "/t:Build")] [InlineData(new string[] { }, "/t:Build")]

4
test/dotnet-msbuild.Tests/GivenDotnetCleanInvocation.cs
View file

@ -10,14 +10,14 @@ namespace Microsoft.DotNet.Cli.MSBuild.Tests
{ {
public class GivenDotnetCleanInvocation public class GivenDotnetCleanInvocation
{ {
const string ExpectedPrefix = "exec <msbuildpath> /m /v:m /v:normal /t:Clean"; const string ExpectedPrefix = "exec <msbuildpath> -m -v:m /v:normal /t:Clean";
[Fact] [Fact]
public void ItAddsProjectToMsbuildInvocation() public void ItAddsProjectToMsbuildInvocation()
{ {
var msbuildPath = "<msbuildpath>"; var msbuildPath = "<msbuildpath>";
CleanCommand.FromArgs(new string[] { "<project>" }, msbuildPath) CleanCommand.FromArgs(new string[] { "<project>" }, msbuildPath)
.GetProcessStartInfo().Arguments.Should().Be("exec <msbuildpath> /m /v:m /v:normal <project> /t:Clean"); .GetProcessStartInfo().Arguments.Should().Be("exec <msbuildpath> -m -v:m /v:normal <project> /t:Clean");
} }
[Theory] [Theory]

4
test/dotnet-msbuild.Tests/GivenDotnetPackInvocation.cs
View file

@ -11,8 +11,8 @@ namespace Microsoft.DotNet.Cli.MSBuild.Tests
{ {
public class GivenDotnetPackInvocation public class GivenDotnetPackInvocation
{ {
const string ExpectedPrefix = "exec <msbuildpath> /m /v:m /restore /t:pack"; const string ExpectedPrefix = "exec <msbuildpath> -m -v:m /restore /t:pack";
const string ExpectedNoBuildPrefix = "exec <msbuildpath> /m /v:m /t:pack"; const string ExpectedNoBuildPrefix = "exec <msbuildpath> -m -v:m /t:pack";
[Theory] [Theory]
[InlineData(new string[] { }, "")] [InlineData(new string[] { }, "")]

2
test/dotnet-msbuild.Tests/GivenDotnetPublishInvocation.cs
View file

@ -20,7 +20,7 @@ namespace Microsoft.DotNet.Cli.MSBuild.Tests
this.output = output; this.output = output;
} }
const string ExpectedPrefix = "exec <msbuildpath> /m /v:m"; const string ExpectedPrefix = "exec <msbuildpath> -m -v:m";
[Theory] [Theory]
[InlineData(new string[] { }, "")] [InlineData(new string[] { }, "")]

2
test/dotnet-msbuild.Tests/GivenDotnetRestoreInvocation.cs
View file

@ -11,7 +11,7 @@ namespace Microsoft.DotNet.Cli.MSBuild.Tests
public class GivenDotnetRestoreInvocation public class GivenDotnetRestoreInvocation
{ {
private const string ExpectedPrefix = private const string ExpectedPrefix =
"exec <msbuildpath> /m /v:m /nologo /t:Restore"; "exec <msbuildpath> -m -v:m /nologo /t:Restore";
[Theory] [Theory]
[InlineData(new string[] { }, "")] [InlineData(new string[] { }, "")]

2
test/dotnet-msbuild.Tests/GivenDotnetStoreInvocation.cs
View file

@ -11,7 +11,7 @@ namespace Microsoft.DotNet.Cli.MSBuild.Tests
{ {
public class GivenDotnetStoreInvocation public class GivenDotnetStoreInvocation
{ {
const string ExpectedPrefix = "exec <msbuildpath> /m /v:m /t:ComposeStore <project>"; const string ExpectedPrefix = "exec <msbuildpath> -m -v:m /t:ComposeStore <project>";
static readonly string[] ArgsPrefix = { "-m", "<project>" }; static readonly string[] ArgsPrefix = { "-m", "<project>" };
[Theory] [Theory]