From 6242db9b142c34fa256e24d8f643028f4374dfab Mon Sep 17 00:00:00 2001 From: Livar Cunha Date: Fri, 30 Sep 2016 20:26:07 -0700 Subject: [PATCH 1/3] Moving msbuild dependencies to msbuild 15. --- build/Microsoft.DotNet.Cli.Compile.targets | 18 +----------------- src/dotnet/project.json | 2 +- src/redist/project.json | 7 +------ src/tool_msbuild/project.json | 4 +--- 4 files changed, 4 insertions(+), 27 deletions(-) diff --git a/build/Microsoft.DotNet.Cli.Compile.targets b/build/Microsoft.DotNet.Cli.Compile.targets index 6433c2687..037253813 100644 --- a/build/Microsoft.DotNet.Cli.Compile.targets +++ b/build/Microsoft.DotNet.Cli.Compile.targets @@ -10,7 +10,7 @@ - + @@ -216,12 +216,6 @@ - - @@ -239,15 +233,5 @@ DestinationFiles="@(FilesToCopy->'$(StageSymbolsDirectory)\%(RecursiveDir)%(Filename)%(Extension)')" /> - - - - - - - \ No newline at end of file diff --git a/src/dotnet/project.json b/src/dotnet/project.json index 94106b469..e2064f277 100644 --- a/src/dotnet/project.json +++ b/src/dotnet/project.json @@ -69,7 +69,7 @@ "exclude": "compile" }, - "Microsoft.Build": "0.1.0-preview-00043-160929", + "Microsoft.Build": "15.1.298-preview5", "Microsoft.DotNet.PlatformAbstractions": "1.0.1-beta-000933" }, diff --git a/src/redist/project.json b/src/redist/project.json index 3d3800bb7..721eb5544 100644 --- a/src/redist/project.json +++ b/src/redist/project.json @@ -19,12 +19,7 @@ "tool_nuget": "1.0.0-preview3-*", "tool_msbuild": "1.0.0-preview3-*", - "MSBuild": "0.1.0-preview-00043-160929", - "Microsoft.Build.Framework": "0.1.0-preview-00043-160929", - "Microsoft.Build.Tasks.Core": "0.1.0-preview-00043-160929", - "Microsoft.Build.Utilities.Core": "0.1.0-preview-00043-160929", - "Microsoft.Build.Targets": "0.1.0-preview-00043-160929", - "Microsoft.Build": "0.1.0-preview-00043-160929", + "Microsoft.Build.Runtime": "15.1.298-preview5", "Microsoft.CodeAnalysis.Build.Tasks": "2.0.0-beta6-60922-08", "System.Runtime.Serialization.Xml": "4.1.1", "NuGet.Build.Tasks": "3.6.0-rc-1954", diff --git a/src/tool_msbuild/project.json b/src/tool_msbuild/project.json index f59dbe70f..7d9b432db 100644 --- a/src/tool_msbuild/project.json +++ b/src/tool_msbuild/project.json @@ -8,12 +8,10 @@ "type": "platform", "version": "1.0.1" }, - "MSBuild": "0.1.0-preview-00043-160929", - "Microsoft.Build.Targets": "0.1.0-preview-00043-160929", + "Microsoft.Build.Runtime": "15.1.298-preview5", "Microsoft.Net.Compilers.netcore": "2.0.0-beta6-60922-08", "Microsoft.CodeAnalysis.Build.Tasks": "2.0.0-beta6-60922-08", "Microsoft.Cci": "4.0.0-rc3-24128-00", - "Microsoft.NuGet.Build.Tasks": "1.0.0-alpha-000004", "Microsoft.Composition": "1.0.30" }, "frameworks": { From 167470b1c99b1235aba11de0868166828615fc71 Mon Sep 17 00:00:00 2001 From: Livar Cunha Date: Thu, 6 Oct 2016 17:05:55 -0700 Subject: [PATCH 2/3] Updating the SDK version, which we need to pick up the NuGetTargetMoniker fix. --- .../MSBuildTestApp/MSBuildTestApp.csproj | 2 +- .../VSTestDotNetCoreProject.csproj | 20 +++++++++++++++--- .../VSTestDotNetCoreProject/project.json | 21 ------------------- .../CSharp_MSBuild/$projectName$.csproj | 2 +- test/dotnet-vstest.Tests/VSTestTests.cs | 6 ++++++ 5 files changed, 25 insertions(+), 26 deletions(-) delete mode 100644 TestAssets/TestProjects/VSTestDotNetCoreProject/project.json diff --git a/TestAssets/TestProjects/MSBuildTestApp/MSBuildTestApp.csproj b/TestAssets/TestProjects/MSBuildTestApp/MSBuildTestApp.csproj index 9103295f3..75d5c89f0 100644 --- a/TestAssets/TestProjects/MSBuildTestApp/MSBuildTestApp.csproj +++ b/TestAssets/TestProjects/MSBuildTestApp/MSBuildTestApp.csproj @@ -17,7 +17,7 @@ 1.0.1 - 1.0.0-alpha-20161006-3 + 1.0.0-alpha-20161007-1 diff --git a/TestAssets/TestProjects/VSTestDotNetCoreProject/VSTestDotNetCoreProject.csproj b/TestAssets/TestProjects/VSTestDotNetCoreProject/VSTestDotNetCoreProject.csproj index f4fa033eb..22c3f3a0e 100644 --- a/TestAssets/TestProjects/VSTestDotNetCoreProject/VSTestDotNetCoreProject.csproj +++ b/TestAssets/TestProjects/VSTestDotNetCoreProject/VSTestDotNetCoreProject.csproj @@ -4,9 +4,8 @@ Library - .NETCoreApp - v1.0 - bin\$(Configuration)\netcoreapp1.0 + netcoreapp1.0 + bin\$(Configuration) @@ -14,6 +13,21 @@ + + + 1.0.1 + + + 1.0.0-alpha-20161007-1 + + + 1.0.3-preview + + + 1.0.4-preview + + + diff --git a/TestAssets/TestProjects/VSTestDotNetCoreProject/project.json b/TestAssets/TestProjects/VSTestDotNetCoreProject/project.json deleted file mode 100644 index ce2590081..000000000 --- a/TestAssets/TestProjects/VSTestDotNetCoreProject/project.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "dependencies": { - "MSTest.TestAdapter": "1.0.3-preview", - "MSTest.TestFramework": "1.0.1-preview" - }, - "frameworks": { - "netcoreapp1.0": { - "dependencies": { - "Microsoft.NETCore.Sdk": "1.0.0-alpha-20161006-3", - "Microsoft.NETCore.App": { - "version": "1.0.1", - "type": "platform" - } - }, - "imports": [ - "dnxcore50", - "portable-net45+win8" - ] - } - } -} diff --git a/src/dotnet/commands/dotnet-new/CSharp_MSBuild/$projectName$.csproj b/src/dotnet/commands/dotnet-new/CSharp_MSBuild/$projectName$.csproj index 41144d9bd..aadb3946a 100644 --- a/src/dotnet/commands/dotnet-new/CSharp_MSBuild/$projectName$.csproj +++ b/src/dotnet/commands/dotnet-new/CSharp_MSBuild/$projectName$.csproj @@ -17,7 +17,7 @@ 1.0.1 - 1.0.0-alpha-20161006-3 + 1.0.0-alpha-20161007-1 diff --git a/test/dotnet-vstest.Tests/VSTestTests.cs b/test/dotnet-vstest.Tests/VSTestTests.cs index 4a3a9b61a..09fd80827 100644 --- a/test/dotnet-vstest.Tests/VSTestTests.cs +++ b/test/dotnet-vstest.Tests/VSTestTests.cs @@ -22,6 +22,12 @@ namespace Microsoft.DotNet.Cli.VSTest.Tests string testProjectDirectory = testInstance.TestRoot; + new Restore3Command() + .WithWorkingDirectory(testProjectDirectory) + .Execute() + .Should() + .Pass(); + // Build project DotNetCoreTestProject new Build3Command() .WithWorkingDirectory(testProjectDirectory) From 06aa54d16c093963395386b6e5a20ebafdc80045 Mon Sep 17 00:00:00 2001 From: Livar Cunha Date: Thu, 6 Oct 2016 19:29:20 -0700 Subject: [PATCH 3/3] Fixing a test. --- .../VSTestDotNetCoreProject/VSTestDotNetCoreProject.csproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/TestAssets/TestProjects/VSTestDotNetCoreProject/VSTestDotNetCoreProject.csproj b/TestAssets/TestProjects/VSTestDotNetCoreProject/VSTestDotNetCoreProject.csproj index 22c3f3a0e..e3dba2cf4 100644 --- a/TestAssets/TestProjects/VSTestDotNetCoreProject/VSTestDotNetCoreProject.csproj +++ b/TestAssets/TestProjects/VSTestDotNetCoreProject/VSTestDotNetCoreProject.csproj @@ -33,7 +33,7 @@ - - + + \ No newline at end of file