diff --git a/eng/Versions.props b/eng/Versions.props index c2129a5e8..01a4b751b 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -159,7 +159,7 @@ 15.7.179 15.7.179 0.1.0-6.0.100-bootstrap.11 - 0.1.0-6.0.100-6 + 0.1.0-6.0.100-10 diff --git a/src/SourceBuild/Arcade/eng/common/templates/job/source-build-run-tarball-build.yml b/src/SourceBuild/Arcade/eng/common/templates/job/source-build-run-tarball-build.yml index 525fbc0c9..bfec92214 100644 --- a/src/SourceBuild/Arcade/eng/common/templates/job/source-build-run-tarball-build.yml +++ b/src/SourceBuild/Arcade/eng/common/templates/job/source-build-run-tarball-build.yml @@ -25,7 +25,7 @@ jobs: Fedora33-Offline: _runOnline: false _Container: mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-33-20210222183538-031e7d2 - timeoutInMinutes: 120 + timeoutInMinutes: 180 variables: _TarballDir: $(Build.StagingDirectory)/tarball workspace: diff --git a/src/SourceBuild/Arcade/tools/SourceBuildArcadeTarball.targets b/src/SourceBuild/Arcade/tools/SourceBuildArcadeTarball.targets index c19d3416e..33718c551 100644 --- a/src/SourceBuild/Arcade/tools/SourceBuildArcadeTarball.targets +++ b/src/SourceBuild/Arcade/tools/SourceBuildArcadeTarball.targets @@ -177,6 +177,10 @@ + + diff --git a/src/SourceBuild/tarball/content/eng/Versions.props b/src/SourceBuild/tarball/content/eng/Versions.props index b47c3db3a..1d2c157cf 100644 --- a/src/SourceBuild/tarball/content/eng/Versions.props +++ b/src/SourceBuild/tarball/content/eng/Versions.props @@ -23,6 +23,6 @@ 0.1.0-6.0.100-bootstrap.11 0.1.0-6.0.100- - 6 + 10 diff --git a/src/SourceBuild/tarball/content/patches/runtime/0001-Conditionally-build-allconfigurations.patch b/src/SourceBuild/tarball/content/patches/runtime/0001-Conditionally-build-allconfigurations.patch new file mode 100644 index 000000000..e9efdd2fd --- /dev/null +++ b/src/SourceBuild/tarball/content/patches/runtime/0001-Conditionally-build-allconfigurations.patch @@ -0,0 +1,27 @@ +From c1eaa569a1ebe3aa688ca251fcbcb42ee086cf27 Mon Sep 17 00:00:00 2001 +From: dseefeld +Date: Wed, 18 Aug 2021 12:20:24 +0000 +Subject: [PATCH] Conditionally build allconfigurations + +When building portable, only a subset of runtime needs to be +built. allconfigurations is only needed in a non-portable build. +--- + eng/SourceBuild.props | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/eng/SourceBuild.props b/eng/SourceBuild.props +index 7dfc80d41fd..1e3bd504931 100644 +--- a/eng/SourceBuild.props ++++ b/eng/SourceBuild.props +@@ -37,7 +37,7 @@ + $(InnerBuildArgs) --arch $(TargetRidPlatform) + $(InnerBuildArgs) --configuration $(Configuration) + $(InnerBuildArgs) --ci +- $(InnerBuildArgs) --allconfigurations ++ $(InnerBuildArgs) --allconfigurations + $(InnerBuildArgs) --verbosity $(LogVerbosity) + $(InnerBuildArgs) --nodereuse false + $(InnerBuildArgs) --warnAsError false +-- +2.31.1 + diff --git a/src/SourceBuild/tarball/content/patches/sdk/0004-Disable-CA1416-for-ProcessExtensions.patch b/src/SourceBuild/tarball/content/patches/sdk/0004-Disable-CA1416-for-ProcessExtensions.patch new file mode 100644 index 000000000..e2e847cbe --- /dev/null +++ b/src/SourceBuild/tarball/content/patches/sdk/0004-Disable-CA1416-for-ProcessExtensions.patch @@ -0,0 +1,42 @@ +From 3e0c6887921670b5d9e312b121791307516a4ce2 Mon Sep 17 00:00:00 2001 +From: dseefeld +Date: Wed, 18 Aug 2021 11:41:59 +0000 +Subject: [PATCH] Disable CA1416 for ProcessExtensions + +Since source-build loads an updated version of code analysis, this +warning is showing up here. Disable warning, since code is meant +to be windows only. + +Eliminates errors like: + /src/tb-installer/src/sdk.5fab7585de482237f470634489b969a1bd03e063/artifacts/source-build/self/src/src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/ProcessExtensions.cs(38,20): error CA1416: This call site is reachable on all platforms. 'ManagementObjectCollection.ManagementObjectEnumerator.MoveNext()' is only supported on: 'windows'. [/src/tb-installer/src/sdk.5fab7585de482237f470634489b969a1bd03e063/artifacts/source-build/self/src/src/Cli/Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj] + /src/tb-installer/src/sdk.5fab7585de482237f470634489b969a1bd03e063/artifacts/source-build/self/src/src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/ProcessExtensions.cs(35,55): error CA1416: This call site is reachable on all platforms. 'ManagementObjectSearcher.Get()' is only supported on: 'windows'. [/src/tb-installer/src/sdk.5fab7585de482237f470634489b969a1bd03e063/artifacts/source-build/self/src/src/Cli/Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj] + /src/tb-installer/src/sdk.5fab7585de482237f470634489b969a1bd03e063/artifacts/source-build/self/src/src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/ProcessExtensions.cs(36,80): error CA1416: This call site is reachable on all platforms. 'ManagementObjectCollection.GetEnumerator()' is only supported on: 'windows'. [/src/tb-installer/src/sdk.5fab7585de482237f470634489b969a1bd03e063/artifacts/source-build/self/src/src/Cli/Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj] + /src/tb-installer/src/sdk.5fab7585de482237f470634489b969a1bd03e063/artifacts/source-build/self/src/src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/ProcessExtensions.cs(38,60): error CA1416: This call site is reachable on all platforms. 'ManagementObjectCollection.ManagementObjectEnumerator.Current' is only supported on: 'windows'. [/src/tb-installer/src/sdk.5fab7585de482237f470634489b969a1bd03e063/artifacts/source-build/self/src/src/Cli/Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj] + /src/tb-installer/src/sdk.5fab7585de482237f470634489b969a1bd03e063/artifacts/source-build/self/src/src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/ProcessExtensions.cs(34,49): error CA1416: This call site is reachable on all platforms. 'ManagementObjectSearcher' is only supported on: 'windows'. [/src/tb-installer/src/sdk.5fab7585de482237f470634489b969a1bd03e063/artifacts/source-build/self/src/src/Cli/Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj] + /src/tb-installer/src/sdk.5fab7585de482237f470634489b969a1bd03e063/artifacts/source-build/self/src/src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/ProcessExtensions.cs(38,60): error CA1416: This call site is reachable on all platforms. 'ManagementBaseObject.GetPropertyValue(string)' is only supported on: 'windows'. [/src/tb-installer/src/sdk.5fab7585de482237f470634489b969a1bd03e063/artifacts/source-build/self/src/src/Cli/Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj] +--- + .../Microsoft.DotNet.Cli.Utils/Extensions/ProcessExtensions.cs | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/ProcessExtensions.cs b/src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/ProcessExtensions.cs +index a9e9880c7..82519dc63 100644 +--- a/src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/ProcessExtensions.cs ++++ b/src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/ProcessExtensions.cs +@@ -12,6 +12,7 @@ namespace Microsoft.DotNet.Cli.Utils + /// + public static class ProcessExtensions + { ++#pragma warning disable CA1416 + /// + /// Returns the parent process of this process by querying the Win32_Process class. + /// +@@ -37,5 +38,6 @@ public static int GetParentProcessId(this Process process) + + return enumerator.MoveNext() ? Convert.ToInt32(enumerator.Current.GetPropertyValue("ParentProcessId")) : -1; + } ++#pragma warning restore CA1416 + } + } +-- +2.31.1 + diff --git a/src/SourceBuild/tarball/content/repos/Directory.Build.targets b/src/SourceBuild/tarball/content/repos/Directory.Build.targets index cc38a4c0a..19015d671 100644 --- a/src/SourceBuild/tarball/content/repos/Directory.Build.targets +++ b/src/SourceBuild/tarball/content/repos/Directory.Build.targets @@ -496,17 +496,11 @@ - - - - - - - + - + diff --git a/src/SourceBuild/tarball/content/repos/msbuild.proj b/src/SourceBuild/tarball/content/repos/msbuild.proj index 3ed6a9eaf..4069d7d3d 100644 --- a/src/SourceBuild/tarball/content/repos/msbuild.proj +++ b/src/SourceBuild/tarball/content/repos/msbuild.proj @@ -30,10 +30,8 @@ - - + + @@ -19,8 +23,9 @@ $(ProjectDirectory)artifacts/portableObj - - + + + diff --git a/src/SourceBuild/tarball/content/repos/runtime.common.props b/src/SourceBuild/tarball/content/repos/runtime.common.props index 4ce8f8e1d..0f83bfc44 100644 --- a/src/SourceBuild/tarball/content/repos/runtime.common.props +++ b/src/SourceBuild/tarball/content/repos/runtime.common.props @@ -1,6 +1,5 @@ - runtime runtime diff --git a/src/SourceBuild/tarball/content/repos/runtime.proj b/src/SourceBuild/tarball/content/repos/runtime.proj index 1a8456874..f3ed143f8 100644 --- a/src/SourceBuild/tarball/content/repos/runtime.proj +++ b/src/SourceBuild/tarball/content/repos/runtime.proj @@ -1,22 +1,27 @@ + + $(TargetRid) + osx-x64 + freebsd-x64 + win-x64 + + $(StandardSourceBuildArgs) + $(BuildCommandArgs) /p:TargetRid=$(OverrideTargetRid) + $(BuildCommandArgs) /p:SourceBuildNonPortable=true + $(StandardSourceBuildCommand) $(BuildCommandArgs) + + - - + - + - - - - - - diff --git a/src/SourceBuild/tarball/content/repos/sdk.proj b/src/SourceBuild/tarball/content/repos/sdk.proj index 31cab5aa7..8a55e87c1 100644 --- a/src/SourceBuild/tarball/content/repos/sdk.proj +++ b/src/SourceBuild/tarball/content/repos/sdk.proj @@ -35,8 +35,7 @@ - + +