From 69f1c5855affa88821a7092bbaf3add2a8e73e77 Mon Sep 17 00:00:00 2001
From: Jo Shields <directhex@apebox.org>
Date: Fri, 2 Feb 2024 13:35:24 -0500
Subject: [PATCH] Refreshed for the glourious TargetOS/TargetArchitecture
 future

---
 src/SourceBuild/content/Directory.Build.props | 24 +++++++++----------
 .../content/repo-projects/runtime.proj        |  6 ++---
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/src/SourceBuild/content/Directory.Build.props b/src/SourceBuild/content/Directory.Build.props
index 7e508644e..144e4a2bf 100644
--- a/src/SourceBuild/content/Directory.Build.props
+++ b/src/SourceBuild/content/Directory.Build.props
@@ -6,18 +6,6 @@
     <DotNetBuildOrchestrator>true</DotNetBuildOrchestrator>
   </PropertyGroup>
 
-  <PropertyGroup Label="ShortStacks">
-    <_OverrideTargetOS>$(OverrideTargetRid.Substring(0, $(OverrideTargetRid.LastIndexOf('-'))))</_OverrideTargetOS>
-    <ShortStack Condition="'$(_OverrideTargetOS)' == 'wasi'">true</ShortStack>
-    <ShortStack Condition="'$(_OverrideTargetOS)' == 'browser'">true</ShortStack>
-    <ShortStack Condition="'$(_OverrideTargetOS)' == 'ios'">true</ShortStack>
-    <ShortStack Condition="'$(_OverrideTargetOS)' == 'iossimulator'">true</ShortStack>
-    <ShortStack Condition="'$(_OverrideTargetOS)' == 'tvos'">true</ShortStack>
-    <ShortStack Condition="'$(_OverrideTargetOS)' == 'tvossimulator'">true</ShortStack>
-    <ShortStack Condition="'$(_OverrideTargetOS)' == 'maccatalyst'">true</ShortStack>
-    <ShortStack Condition="'$(_OverrideTargetOS)' == 'android'">true</ShortStack>
-  </PropertyGroup>
-
   <PropertyGroup Label="CalculateTargetOS">
     <BuildOS>linux</BuildOS>
     <BuildOS Condition="$([MSBuild]::IsOSPlatform('OSX'))">osx</BuildOS>
@@ -31,6 +19,18 @@
     <TargetOS Condition="'$(TargetOS)' == ''">$(BuildOS)</TargetOS>
   </PropertyGroup>
 
+  <!-- This is a list of cases where we aren't producing a whole SDK, just a runtime. This list should be kept in sync with https://github.com/dotnet/runtime/blob/main/eng/SourceBuild.props#L26 -->
+  <PropertyGroup Label="ShortStacks">
+    <ShortStack Condition="'$(TargetOS)' == 'wasi'">true</ShortStack>
+    <ShortStack Condition="'$(TargetOS)' == 'browser'">true</ShortStack>
+    <ShortStack Condition="'$(TargetOS)' == 'ios'">true</ShortStack>
+    <ShortStack Condition="'$(TargetOS)' == 'iossimulator'">true</ShortStack>
+    <ShortStack Condition="'$(TargetOS)' == 'tvos'">true</ShortStack>
+    <ShortStack Condition="'$(TargetOS)' == 'tvossimulator'">true</ShortStack>
+    <ShortStack Condition="'$(TargetOS)' == 'maccatalyst'">true</ShortStack>
+    <ShortStack Condition="'$(TargetOS)' == 'android'">true</ShortStack>
+  </PropertyGroup>
+
   <PropertyGroup Label="CalculateArch">
     <BuildArchitecture>$([System.Runtime.InteropServices.RuntimeInformation]::ProcessArchitecture.ToString().ToLowerInvariant)</BuildArchitecture>
     <HostArchitecture Condition="'$(HostArchitecture)' == ''">$(BuildArchitecture)</HostArchitecture>
diff --git a/src/SourceBuild/content/repo-projects/runtime.proj b/src/SourceBuild/content/repo-projects/runtime.proj
index 8f2c8d9c8..2f9e3c503 100644
--- a/src/SourceBuild/content/repo-projects/runtime.proj
+++ b/src/SourceBuild/content/repo-projects/runtime.proj
@@ -14,9 +14,9 @@
 
     <BuildArgs>$(BuildArgs) $(FlagParameterPrefix)arch $(TargetArchitecture)</BuildArgs>
     <BuildArgs>$(BuildArgs) $(FlagParameterPrefix)os $(TargetOS)</BuildArgs>
-    <BuildArgs>$(BuildArgs) /p:TargetRid=$(TargetRid)</BuildArgs>
-    <BuildArgs Condition="'$(ShortStack)' != 'true'>$(BuildArgs) /p:RuntimeOS=$(RuntimeOS)</BuildArgs>
-    <BuildArgs Condition="'$(ShortStack)' != 'true'>$(BuildArgs) /p:BaseOS=$(BaseOS)</BuildArgs>
+    <BuildArgs Condition="'$(ShortStack)' != 'true'">$(BuildArgs) /p:TargetRid=$(TargetRid)</BuildArgs>
+    <BuildArgs Condition="'$(ShortStack)' != 'true'">$(BuildArgs) /p:RuntimeOS=$(RuntimeOS)</BuildArgs>
+    <BuildArgs Condition="'$(ShortStack)' != 'true'">$(BuildArgs) /p:BaseOS=$(BaseOS)</BuildArgs>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(DotNetBuildSourceOnly)' == 'true'">