From 0f0f70ce48939945baec78cba0bbcff848b4a188 Mon Sep 17 00:00:00 2001 From: Peter Huene Date: Mon, 7 May 2018 16:35:29 -0700 Subject: [PATCH 1/9] Fix adding tools directory to PATH for native installers. This commit fixes adding the tools directory to the user's PATH for the native installers. The issue was a regression caused by #8886. The change used a "no-op" sentinel file that reported it existed. This "no-op" sentinel was used for the native installers. Unlike the other "no-op" sentinels used by the native installer, we do want PATH to be modified by the native installer. The fix is to change the "no-op" sentinel to report the file doesn't exist, but also to not to attempt to create the file. This fixes #9208. --- .../NoOpFileSentinel.cs | 9 +++- src/dotnet/Program.cs | 2 +- ...atTheUserIsRunningDotNetForTheFirstTime.cs | 44 +++++++++++++++++++ 3 files changed, 53 insertions(+), 2 deletions(-) diff --git a/src/Microsoft.DotNet.Configurer/NoOpFileSentinel.cs b/src/Microsoft.DotNet.Configurer/NoOpFileSentinel.cs index e77097011..80e3d0831 100644 --- a/src/Microsoft.DotNet.Configurer/NoOpFileSentinel.cs +++ b/src/Microsoft.DotNet.Configurer/NoOpFileSentinel.cs @@ -7,9 +7,16 @@ namespace Microsoft.DotNet.Configurer { public class NoOpFileSentinel : IFileSentinel { + private bool _exists; + + public NoOpFileSentinel(bool exists) + { + _exists = exists; + } + public bool Exists() { - return true; + return _exists; } public void Create() diff --git a/src/dotnet/Program.cs b/src/dotnet/Program.cs index 6ae1409ce..ce08bcb56 100644 --- a/src/dotnet/Program.cs +++ b/src/dotnet/Program.cs @@ -147,7 +147,7 @@ namespace Microsoft.DotNet.Cli { aspNetCertificateSentinel = new NoOpAspNetCertificateSentinel(); firstTimeUseNoticeSentinel = new NoOpFirstTimeUseNoticeSentinel(); - toolPathSentinel = new NoOpFileSentinel(); + toolPathSentinel = new NoOpFileSentinel(exists: false); hasSuperUserAccess = true; } diff --git a/test/dotnet.Tests/GivenThatTheUserIsRunningDotNetForTheFirstTime.cs b/test/dotnet.Tests/GivenThatTheUserIsRunningDotNetForTheFirstTime.cs index bccc3c053..b554d528e 100644 --- a/test/dotnet.Tests/GivenThatTheUserIsRunningDotNetForTheFirstTime.cs +++ b/test/dotnet.Tests/GivenThatTheUserIsRunningDotNetForTheFirstTime.cs @@ -6,6 +6,7 @@ using System.IO; using System.Collections.Generic; using Microsoft.DotNet.Cli.Utils; using Microsoft.DotNet.Cli; +using Microsoft.DotNet.Configurer; using Microsoft.DotNet.TestFramework; using Microsoft.DotNet.Tools.Test.Utilities; using Xunit; @@ -193,6 +194,49 @@ namespace Microsoft.DotNet.Tests .ContainVisuallySameFragment(Configurer.LocalizableStrings.AspNetCertificateInstalled); } + [LinuxOnlyFact] + public void ItCreatesTheProfileFileOnLinuxWhenInvokedFromNativeInstaller() + { + var emptyHome = Path.Combine(_testDirectory, "empty_home"); + var profiled = Path.Combine(_testDirectory, "profile.d"); + + var command = new DotnetCommand().WithWorkingDirectory(_testDirectory); + command.Environment["HOME"] = emptyHome; + command.Environment["USERPROFILE"] = emptyHome; + command.Environment["APPDATA"] = emptyHome; + command.Environment["DOTNET_CLI_TEST_FALLBACKFOLDER"] = _nugetFallbackFolder.FullName; + command.Environment["DOTNET_SKIP_FIRST_TIME_EXPERIENCE"] = ""; + command.Environment["DOTNET_CLI_TEST_LINUX_PROFILED_PATH"] = profiled; + command.Environment["DOTNET_DISABLE_MULTICOREJIT"] = "true"; + command.Environment["SkipInvalidConfigurations"] = "true"; + command.ExecuteWithCapturedOutput("internal-reportinstallsuccess test").Should().Pass(); + + File.Exists(profiled).Should().BeTrue(); + File.ReadAllText(profiled).Should().Be( + $"export PATH=\"$PATH:{new CliFolderPathCalculator().ToolsShimPathInUnix.PathWithDollar}\""); + } + + [MacOsOnlyFact] + public void ItCreatesThePathDFileOnMacOSWhenInvokedFromNativeInstaller() + { + var emptyHome = Path.Combine(_testDirectory, "empty_home"); + var pathsd = Path.Combine(_testDirectory, "paths.d"); + + var command = new DotnetCommand().WithWorkingDirectory(_testDirectory); + command.Environment["HOME"] = emptyHome; + command.Environment["USERPROFILE"] = emptyHome; + command.Environment["APPDATA"] = emptyHome; + command.Environment["DOTNET_CLI_TEST_FALLBACKFOLDER"] = _nugetFallbackFolder.FullName; + command.Environment["DOTNET_SKIP_FIRST_TIME_EXPERIENCE"] = ""; + command.Environment["DOTNET_CLI_TEST_OSX_PATHSD_PATH"] = pathsd; + command.Environment["DOTNET_DISABLE_MULTICOREJIT"] = "true"; + command.Environment["SkipInvalidConfigurations"] = "true"; + command.ExecuteWithCapturedOutput("internal-reportinstallsuccess test").Should().Pass(); + + File.Exists(pathsd).Should().BeTrue(); + File.ReadAllText(pathsd).Should().Be(new CliFolderPathCalculator().ToolsShimPathInUnix.PathWithTilde); + } + [Fact] public void ItRestoresTheNuGetPackagesToTheNuGetCacheFolder() { From e60d0a79e51477f76f16001a2c056878ab39f32d Mon Sep 17 00:00:00 2001 From: Livar Cunha Date: Wed, 2 May 2018 15:34:04 -0700 Subject: [PATCH 2/9] Making the CLI package name be only major.minor version and updating the version of the runtime packages that we depend on. --- build/Package.targets | 1 + build/Version.props | 1 + build/package/Installer.DEB.proj | 12 ++++----- build/package/Installer.DEB.targets | 22 ++++++++-------- build/package/Installer.RPM.targets | 25 +++++++++++-------- ...xNativeInstallerDependencyVersions.targets | 14 +++++++++++ 6 files changed, 49 insertions(+), 26 deletions(-) create mode 100644 build/package/LinuxNativeInstallerDependencyVersions.targets diff --git a/build/Package.targets b/build/Package.targets index 77ea2aa33..cbb5d7152 100644 --- a/build/Package.targets +++ b/build/Package.targets @@ -4,6 +4,7 @@ + diff --git a/build/Version.props b/build/Version.props index a93a8486c..c0ef71eeb 100644 --- a/build/Version.props +++ b/build/Version.props @@ -5,6 +5,7 @@ 300 rtm + $(VersionMajor).$(VersionMinor) $(VersionMajor).$(VersionMinor).$(VersionPatch) $(CliVersionNoSuffix)-$(ReleaseSuffix) $(CliVersionNoSuffix) - $(ReleaseSuffix) diff --git a/build/package/Installer.DEB.proj b/build/package/Installer.DEB.proj index 0e516f440..3b1ad6e6e 100644 --- a/build/package/Installer.DEB.proj +++ b/build/package/Installer.DEB.proj @@ -95,11 +95,11 @@ - - + + - + - - + + - + diff --git a/build/package/Installer.DEB.targets b/build/package/Installer.DEB.targets index a3800edce..bf4cde6f3 100644 --- a/build/package/Installer.DEB.targets +++ b/build/package/Installer.DEB.targets @@ -1,11 +1,8 @@ - - dotnet-sdk-$(SdkVersion) - - + DependsOnTargets="Init; + CalculateLinuxNativeInstallerDependencyVersions"> $(MSBuildThisFileDirectory)/dotnet-deb-tool-consumer @@ -26,17 +23,22 @@ $(MicrosoftNETCoreAppPackageVersion) - dotnet-runtime-deps-$(RuntimeDepsPackageVersion) - $(SdkVersion) + dotnet-runtime-deps-$(RuntimeDepsPackageVersion) + $(MajorMinorVersion) dotnet-sdk-$(SdkDebianPackageVersion) - $(MicrosoftNETCoreAppPackageVersion) + $(MicrosoftNETCoreAppPackageVersion) + $(MicrosoftNETCoreAppMajorMinorVersion) + dotnet-runtime-$(SharedFxDebianPackageFileVersion) + $(SharedFxDebianPackageFileName.ToLower()) dotnet-runtime-$(SharedFxDebianPackageVersion) $(SharedFxDebianPackageName.ToLower()) $(HostFxrVersion) dotnet-hostfxr-$(HostFxrDebianPackageVersion) $(HostFxrDebianPackageName.ToLower()) dotnet-host - aspnetcore-runtime-$(AspNetCoreVersion) + aspnetcore-runtime-$(AspNetCoreVersion) + $(AspNetCoreSharedFxDebianPackageFileName.ToLower()) + aspnetcore-runtime-$(AspNetCoreMajorMinorVersion) $(AspNetCoreSharedFxDebianPackageName.ToLower()) @@ -99,7 +101,7 @@ - $(SdkVersion) + $(MajorMinorVersion) $(SdkBrandName) diff --git a/build/package/Installer.RPM.targets b/build/package/Installer.RPM.targets index 4fbc87067..820d1f2cd 100644 --- a/build/package/Installer.RPM.targets +++ b/build/package/Installer.RPM.targets @@ -68,13 +68,13 @@ - $(MicrosoftNETCoreAppPackageVersion) + $(MicrosoftNETCoreAppMajorMinorVersion) $(AspNetCoreSharedFxRpmPackageName) - $(AspNetCoreVersion) + $(AspNetCoreMajorMinorVersion) $(SharedFxRpmPackageName) @@ -143,10 +143,10 @@ - + $(MicrosoftNETCoreAppPackageVersion) - dotnet-runtime-deps-$(RuntimeDepsPackageVersion) + dotnet-runtime-deps-$(RuntimeDepsPackageVersion) $(SdkVersion) $(OutputDirectory)/sdk $(InstallerOutputDirectory)/$(DistroSpecificArtifactNameWithVersionCombinedHostHostFxrFrameworkSdk)$(InstallerExtension) @@ -168,17 +168,22 @@ - $(SdkVersion) + $(MajorMinorVersion) $(ArtifactNameCombinedHostHostFxrFrameworkSdk)-$(SdkRpmPackageVersion) - $(MicrosoftNETCoreAppPackageVersion) + $(MicrosoftNETCoreAppMajorMinorVersion) + $(MicrosoftNETCoreAppPackageVersion) dotnet-runtime-$(SharedFxRpmPackageVersion) $(SharedFxRpmPackageName.ToLower()) + dotnet-runtime-$(SharedFxRpmPackageFileVersion) + $(SharedFxRpmPackageFileName.ToLower()) $(HostFxrVersion) dotnet-hostfxr-$(HostFxrRpmPackageVersion) $(HostFxrRpmPackageName.ToLower()) dotnet-host - aspnetcore-runtime-$(AspNetCoreVersion) + aspnetcore-runtime-$(AspNetCoreMajorMinorVersion) $(AspNetCoreSharedFxRpmPackageName.ToLower()) + aspnetcore-runtime-$(AspNetCoreVersion) + $(AspNetCoreSharedFxRpmPackageFileName.ToLower()) $(ScriptsDir)/$(AfterInstallHostScriptName) $(RpmLayoutScripts)/$(AfterInstallHostScriptName) @@ -238,10 +243,10 @@ - - + + - + diff --git a/build/package/LinuxNativeInstallerDependencyVersions.targets b/build/package/LinuxNativeInstallerDependencyVersions.targets new file mode 100644 index 000000000..a2be36efb --- /dev/null +++ b/build/package/LinuxNativeInstallerDependencyVersions.targets @@ -0,0 +1,14 @@ + + + + + $([MSBuild]::Add($(MicrosoftNETCoreAppPackageVersion.IndexOf('.')), 1)) + $(MicrosoftNETCoreAppPackageVersion.IndexOf('.', $(MicrosoftNETCoreAppPatchSeparatorIndex))) + $(MicrosoftNETCoreAppPackageVersion.Substring(0, $(MicrosoftNETCoreAppPatchSeparatorIndex))) + + $([MSBuild]::Add($(AspNetCoreVersion.IndexOf('.')), 1)) + $(AspNetCoreVersion.IndexOf('.', $(AspNetCoreVersionPatchSeparatorIndex))) + $(AspNetCoreVersion.Substring(0, $(AspNetCoreVersionPatchSeparatorIndex))) + + + From 4de0043f90e4d6b9f01d7a18259492bebc68668b Mon Sep 17 00:00:00 2001 From: Parallels Date: Tue, 8 May 2018 11:25:14 -0700 Subject: [PATCH 3/9] Updating the RPM dependency version of asp.net core to the full version, when it gets written to the metadata file. --- build/package/Installer.RPM.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/package/Installer.RPM.targets b/build/package/Installer.RPM.targets index 820d1f2cd..7b797e732 100644 --- a/build/package/Installer.RPM.targets +++ b/build/package/Installer.RPM.targets @@ -74,7 +74,7 @@ $(AspNetCoreSharedFxRpmPackageName) - $(AspNetCoreMajorMinorVersion) + $(AspNetCoreVersion) $(SharedFxRpmPackageName) From 3bbab5edbfcee3dd01b41451147b34aa5466a98c Mon Sep 17 00:00:00 2001 From: Parallels Date: Tue, 8 May 2018 17:40:16 -0700 Subject: [PATCH 4/9] Updating tests to depend on -upgrade packages and also updating the versions of the runtime and asp.net to versions that have support for upgradable linux packages. --- build/BundledRuntimes.props | 13 ++++++++----- build/DependencyVersions.props | 8 ++++---- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/build/BundledRuntimes.props b/build/BundledRuntimes.props index 45234b98b..40003b788 100644 --- a/build/BundledRuntimes.props +++ b/build/BundledRuntimes.props @@ -6,21 +6,24 @@ -internal + + -upgrade + - dotnet-runtime-deps-$(SharedHostVersion)-$(CoreSetupRid)$(InstallerExtension) + dotnet-runtime-deps-$(SharedHostVersion)-$(CoreSetupRid)$(InstallerEndSuffix)$(InstallerExtension) $(PackagesDirectory)/$(DownloadedRuntimeDepsInstallerFileName) $(CoreSetupRid) x64 - dotnet-host$(InstallerStartSuffix)-$(SharedHostVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerExtension) + dotnet-host$(InstallerStartSuffix)-$(SharedHostVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerEndSuffix)$(InstallerExtension) $(PackagesDirectory)/$(DownloadedSharedHostInstallerFileName) - dotnet-hostfxr$(InstallerStartSuffix)-$(HostFxrVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerExtension) + dotnet-hostfxr$(InstallerStartSuffix)-$(HostFxrVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerEndSuffix)$(InstallerExtension) $(PackagesDirectory)/$(DownloadedHostFxrInstallerFileName) - dotnet-runtime$(InstallerStartSuffix)-$(MicrosoftNETCoreAppPackageVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerExtension) + dotnet-runtime$(InstallerStartSuffix)-$(MicrosoftNETCoreAppPackageVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerEndSuffix)$(InstallerExtension) $(PackagesDirectory)/$(DownloadedSharedFrameworkInstallerFileName) @@ -34,7 +37,7 @@ $(AspNetCoreSharedFxInstallerRid) x64 - aspnetcore-runtime-$(AspNetCoreVersion)-$(AspNetCoreSharedFxInstallerRid)$(InstallerExtension) + aspnetcore-runtime-$(AspNetCoreVersion)-$(AspNetCoreSharedFxInstallerRid)$(InstallerEndSuffix)$(InstallerExtension) aspnetcore-runtime-internal-$(AspNetCoreVersion)-$(AspNetCoreSharedFxInstallerRid).wixlib $(PackagesDirectory)/$(DownloadedAspNetCoreSharedFxInstallerFileName) diff --git a/build/DependencyVersions.props b/build/DependencyVersions.props index 67e932b73..a5ade70f7 100644 --- a/build/DependencyVersions.props +++ b/build/DependencyVersions.props @@ -1,9 +1,9 @@ - 2.1.0-rc1-30661 + 2.1.0-rtm-30752 $(MicrosoftAspNetCoreAllPackageVersion) - 2.1.0-rtm-26505-04 + 2.1.0-rtm-26508-02 $(MicrosoftNETCoreAppPackageVersion) 15.7.177 $(MicrosoftBuildPackageVersion) @@ -29,8 +29,8 @@ $(MicrosoftTemplateEngineCliPackageVersion) $(MicrosoftTemplateEngineCliPackageVersion) $(MicrosoftTemplateEngineCliPackageVersion) - 2.1.0-rtm-26505-04 - 2.1.0-rtm-26505-04 + 2.1.0-rtm-26508-02 + 2.1.0-rtm-26508-02 0.1.1-rtm-62905-02 1.3.1-alpha-62905-02 $(MicrosoftDotNetProjectJsonMigrationPackageVersion) From a3879f8eb961e93cc041faeb57a3188eaca359a0 Mon Sep 17 00:00:00 2001 From: Parallels Date: Tue, 8 May 2018 18:42:57 -0700 Subject: [PATCH 5/9] Updating the deb package of the SDK to specify a version range for the runtime and asp.net dependencies. --- build/package/Installer.DEB.targets | 6 ++++++ packaging/deb/dotnet-debian_config.json | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/build/package/Installer.DEB.targets b/build/package/Installer.DEB.targets index bf4cde6f3..d46b04a13 100644 --- a/build/package/Installer.DEB.targets +++ b/build/package/Installer.DEB.targets @@ -106,6 +106,12 @@ $(SdkBrandName) + + $(MicrosoftNETCoreAppPackageVersion) + + + $(AspNetCoreVersion) + $(SdkVersion) diff --git a/packaging/deb/dotnet-debian_config.json b/packaging/deb/dotnet-debian_config.json index 307c8b897..e6f046507 100644 --- a/packaging/deb/dotnet-debian_config.json +++ b/packaging/deb/dotnet-debian_config.json @@ -29,7 +29,7 @@ }, "debian_dependencies":{ - "%SHARED_FRAMEWORK_DEBIAN_PACKAGE_NAME%" : {}%SHARED_FRAMEWORK_DEBIAN_PACKAGE_ADDITIONAL_DEPENDENCY%, - "%ASPNETCORE_SHAREDFX_DEBIAN_PACKAGE_NAME%": {} + "%SHARED_FRAMEWORK_DEBIAN_PACKAGE_NAME%" : { "package_version": "%SHARED_FRAMEWORK_DEBIAN_PACKAGE_VERSIONS%" }%SHARED_FRAMEWORK_DEBIAN_PACKAGE_ADDITIONAL_DEPENDENCY%, + "%ASPNETCORE_SHAREDFX_DEBIAN_PACKAGE_NAME%": { "package_version": "%ASPNETCORE_SHAREDFX_DEBIAN_PACKAGE_VERSION%" } } } From e7cf325682412b535a019b355c443f535095b6ec Mon Sep 17 00:00:00 2001 From: Livar Cunha Date: Wed, 9 May 2018 11:52:26 -0700 Subject: [PATCH 6/9] Using Major.Minor.Patch versions for rpm packages dependencies. --- build/package/Installer.RPM.targets | 4 ++-- .../LinuxNativeInstallerDependencyVersions.targets | 8 ++++++++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/build/package/Installer.RPM.targets b/build/package/Installer.RPM.targets index 7b797e732..e6e4fa917 100644 --- a/build/package/Installer.RPM.targets +++ b/build/package/Installer.RPM.targets @@ -68,13 +68,13 @@ - $(MicrosoftNETCoreAppMajorMinorVersion) + $(MicrosoftNETCoreAppMajorMinorPatchVersion) $(AspNetCoreSharedFxRpmPackageName) - $(AspNetCoreVersion) + $(AspNetCoreMajorMinorPatchVersion) $(SharedFxRpmPackageName) diff --git a/build/package/LinuxNativeInstallerDependencyVersions.targets b/build/package/LinuxNativeInstallerDependencyVersions.targets index a2be36efb..520a7e3de 100644 --- a/build/package/LinuxNativeInstallerDependencyVersions.targets +++ b/build/package/LinuxNativeInstallerDependencyVersions.targets @@ -6,9 +6,17 @@ $(MicrosoftNETCoreAppPackageVersion.IndexOf('.', $(MicrosoftNETCoreAppPatchSeparatorIndex))) $(MicrosoftNETCoreAppPackageVersion.Substring(0, $(MicrosoftNETCoreAppPatchSeparatorIndex))) + $(MicrosoftNETCoreAppPackageVersion.IndexOf('-')) + $(MicrosoftNETCoreAppPackageVersion) + $(MicrosoftNETCoreAppPackageVersion.Substring(0, $(MicrosoftNETCoreAppVersionPreReleaseSeparator))) + $([MSBuild]::Add($(AspNetCoreVersion.IndexOf('.')), 1)) $(AspNetCoreVersion.IndexOf('.', $(AspNetCoreVersionPatchSeparatorIndex))) $(AspNetCoreVersion.Substring(0, $(AspNetCoreVersionPatchSeparatorIndex))) + + $(AspNetCoreVersion.IndexOf('-')) + $(AspNetCoreVersion) + $(AspNetCoreVersion.Substring(0, $(AspNetCoreVersionPreReleaseSeparator))) From e9d0b154a4f146817854a3ca313dfaa153519504 Mon Sep 17 00:00:00 2001 From: Parallels Date: Wed, 9 May 2018 12:33:25 -0700 Subject: [PATCH 7/9] Fixing deb native installer tests by installing packages using the package name instead of the file name. --- build/package/Installer.DEB.proj | 12 ++++++------ build/package/Installer.DEB.targets | 6 +++--- .../LinuxNativeInstallerDependencyVersions.targets | 5 +++++ 3 files changed, 14 insertions(+), 9 deletions(-) diff --git a/build/package/Installer.DEB.proj b/build/package/Installer.DEB.proj index 3b1ad6e6e..0e516f440 100644 --- a/build/package/Installer.DEB.proj +++ b/build/package/Installer.DEB.proj @@ -95,11 +95,11 @@ - - + + - + - - + + - + diff --git a/build/package/Installer.DEB.targets b/build/package/Installer.DEB.targets index d46b04a13..b01e9bfc3 100644 --- a/build/package/Installer.DEB.targets +++ b/build/package/Installer.DEB.targets @@ -22,8 +22,8 @@ - $(MicrosoftNETCoreAppPackageVersion) - dotnet-runtime-deps-$(RuntimeDepsPackageVersion) + $(MicrosoftNETCoreAppMajorMinorVersion) + dotnet-runtime-deps-$(RuntimeDepsPackageVersion) $(MajorMinorVersion) dotnet-sdk-$(SdkDebianPackageVersion) $(MicrosoftNETCoreAppPackageVersion) @@ -32,7 +32,7 @@ $(SharedFxDebianPackageFileName.ToLower()) dotnet-runtime-$(SharedFxDebianPackageVersion) $(SharedFxDebianPackageName.ToLower()) - $(HostFxrVersion) + $(HostFxrMajorMinorVersion) dotnet-hostfxr-$(HostFxrDebianPackageVersion) $(HostFxrDebianPackageName.ToLower()) dotnet-host diff --git a/build/package/LinuxNativeInstallerDependencyVersions.targets b/build/package/LinuxNativeInstallerDependencyVersions.targets index 520a7e3de..e3b915e81 100644 --- a/build/package/LinuxNativeInstallerDependencyVersions.targets +++ b/build/package/LinuxNativeInstallerDependencyVersions.targets @@ -17,6 +17,11 @@ $(AspNetCoreVersion.IndexOf('-')) $(AspNetCoreVersion) $(AspNetCoreVersion.Substring(0, $(AspNetCoreVersionPreReleaseSeparator))) + + $([MSBuild]::Add($(HostFxrVersion.IndexOf('.')), 1)) + $(HostFxrVersion.IndexOf('.', $(HostFxrVersionPatchSeparatorIndex))) + $(HostFxrVersion.Substring(0, $(HostFxrVersionPatchSeparatorIndex))) + From 6b1b89a00693593f26c36f77f3c4c362b4e92dee Mon Sep 17 00:00:00 2001 From: Parallels Date: Wed, 9 May 2018 14:24:47 -0700 Subject: [PATCH 8/9] Using ~ versions for dependencies of deb packages, so that we do the right thing when comparing release/pre-release package versions. --- build/package/Installer.DEB.targets | 4 ++-- .../LinuxNativeInstallerDependencyVersions.targets | 8 ++++++++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/build/package/Installer.DEB.targets b/build/package/Installer.DEB.targets index b01e9bfc3..349089d86 100644 --- a/build/package/Installer.DEB.targets +++ b/build/package/Installer.DEB.targets @@ -107,10 +107,10 @@ $(SdkBrandName) - $(MicrosoftNETCoreAppPackageVersion) + $(MicrosoftNETCoreAppPackageVersionWithTilda) - $(AspNetCoreVersion) + $(AspNetCoreVersionWithTilda) diff --git a/build/package/LinuxNativeInstallerDependencyVersions.targets b/build/package/LinuxNativeInstallerDependencyVersions.targets index e3b915e81..27acc4fb3 100644 --- a/build/package/LinuxNativeInstallerDependencyVersions.targets +++ b/build/package/LinuxNativeInstallerDependencyVersions.targets @@ -9,6 +9,10 @@ $(MicrosoftNETCoreAppPackageVersion.IndexOf('-')) $(MicrosoftNETCoreAppPackageVersion) $(MicrosoftNETCoreAppPackageVersion.Substring(0, $(MicrosoftNETCoreAppVersionPreReleaseSeparator))) + $([MSBuild]::Add($(MicrosoftNETCoreAppVersionPreReleaseSeparator), 1)) + $(MicrosoftNETCoreAppPackageVersion.Substring($(MicrosoftNETCoreAppVersionPreReleaseSeparatorStartIndex))) + $(MicrosoftNETCoreAppMajorMinorPatchVersion) + $(MicrosoftNETCoreAppMajorMinorPatchVersion)~$(MicrosoftNETCoreVersionSuffix) $([MSBuild]::Add($(AspNetCoreVersion.IndexOf('.')), 1)) $(AspNetCoreVersion.IndexOf('.', $(AspNetCoreVersionPatchSeparatorIndex))) @@ -17,6 +21,10 @@ $(AspNetCoreVersion.IndexOf('-')) $(AspNetCoreVersion) $(AspNetCoreVersion.Substring(0, $(AspNetCoreVersionPreReleaseSeparator))) + $([MSBuild]::Add($(AspNetCoreVersionPreReleaseSeparator), 1)) + $(AspNetCoreVersion.Substring($(AspNetCoreVersionPreReleaseSeparatorStartIndex))) + $(AspNetCoreMajorMinorPatchVersion) + $(AspNetCoreMajorMinorPatchVersion)~$(AspNetCoreVersionSuffix) $([MSBuild]::Add($(HostFxrVersion.IndexOf('.')), 1)) $(HostFxrVersion.IndexOf('.', $(HostFxrVersionPatchSeparatorIndex))) From b18efcea854555461ba40d71cb763f6b5c4befd3 Mon Sep 17 00:00:00 2001 From: abhishkk Date: Fri, 11 May 2018 16:11:54 +0530 Subject: [PATCH 9/9] 15.8.0-preview-20180510-03 testplatform insertion --- build/DependencyVersions.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/DependencyVersions.props b/build/DependencyVersions.props index 541798aac..5f84dd0c7 100644 --- a/build/DependencyVersions.props +++ b/build/DependencyVersions.props @@ -44,7 +44,7 @@ $(NuGetBuildTasksPackageVersion) $(NuGetBuildTasksPackageVersion) $(NuGetBuildTasksPackageVersion) - 15.7.0 + 15.8.0-preview-20180510-03 $(MicrosoftNETTestSdkPackageVersion) $(MicrosoftNETTestSdkPackageVersion) 0.2.0-beta-000042