incorporate CR feedback for the first PR

This commit is contained in:
Lakshan Fernando 2016-03-28 17:17:21 -07:00 committed by Dan Quirk
parent 6b84a10e57
commit 689a72ffb5
6 changed files with 80 additions and 72 deletions

View file

@ -117,18 +117,13 @@ namespace Microsoft.DotNet.Cli
["test"] = TestCommand.Run
};
int exitCode = 100;
string arguments = string.Empty;
int exitCode;
var arguments = string.Empty;
Func<string[], int> builtIn;
if (builtIns.TryGetValue(command, out builtIn))
{
exitCode = builtIn(appArgs.ToArray());
appArgs.ToList().ForEach(a => { arguments += a + " "; });
arguments = string.Join(" ", appArgs);
}
else
{
@ -140,7 +135,9 @@ namespace Microsoft.DotNet.Cli
exitCode = result.ExitCode;
}
Telemetry.TrackCommand(
Telemetry telemetryClient = new Telemetry();
telemetryClient.TrackCommand(
command,
new Dictionary<string, string>
{
@ -155,7 +152,7 @@ namespace Microsoft.DotNet.Cli
}
private static void PrintVersion()
private static void PrintVersion()
{
Reporter.Output.WriteLine(Product.Version);
}