From 64c36e46ff3ba2d946b4db24415b9e40f0409a98 Mon Sep 17 00:00:00 2001 From: Matt Mitchell Date: Tue, 20 Jul 2021 12:33:43 -0700 Subject: [PATCH] Use arcade's conditional pattern for publishing (#11172) Arcade runs CI/PR builds with --publish on. This does a general dry run of some parts of publishing. However, in this mode, packages are NOT published, as the azdo publishing target does not run if DotNetPublishUsingPipelines is false. This is false in non-official scenarios. installer is missing a check of this conditional for its custom installer publishing. Add it. Note that we could probably remove the explicit use of PushToAzureDevOpsArtifacts in installer, by using `eng/Publishing.props` in a more typical workflow. See https://github.com/dotnet/aspnetcore/blob/main/eng/Publishing.props for an example of this. That would also avoid this bug. --- eng/Publishing.props | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/eng/Publishing.props b/eng/Publishing.props index cab8f45f0..3d0751dd8 100644 --- a/eng/Publishing.props +++ b/eng/Publishing.props @@ -87,7 +87,8 @@ + BeforeTargets="Publish" + Condition="$(DotNetPublishUsingPipelines)">