diff --git a/TestAssets/TestProjects/MSBuildTestApp/MSBuildTestApp.csproj b/TestAssets/TestProjects/MSBuildTestApp/MSBuildTestApp.csproj index df18650a4..0ba5479f9 100644 --- a/TestAssets/TestProjects/MSBuildTestApp/MSBuildTestApp.csproj +++ b/TestAssets/TestProjects/MSBuildTestApp/MSBuildTestApp.csproj @@ -3,7 +3,7 @@ Exe netcoreapp3.0 - $(TEST_PACKAGES) + $(RestoreAdditionalProjectSources);$(TEST_PACKAGES) diff --git a/eng/Versions.props b/eng/Versions.props index 499071cc1..ec04a3aea 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -12,7 +12,7 @@ preview - 3.0.100-preview4.19118.4 + 3.0.100-preview3.19121.2 @@ -20,7 +20,7 @@ - 3.0.0-preview3-19119-08 + 3.0.0-preview3-19120-02 $(MicrosoftAspNetCoreAppPackageVersion) $(MicrosoftAspNetCoreAppPackageVersion) $(MicrosoftAspNetCoreAppPackageVersion) @@ -32,11 +32,14 @@ 3.0.100-preview4.19111.1 - 3.0.0-preview4-27421-3 + 3.0.0-preview3-27420-6 $(MicrosoftNETCoreAppPackageVersion) 2.1.0-prerelease.19121.3 + + $(NETStandardLibraryPackageVersion) 1.0.2-beta5.19115.3 @@ -48,8 +51,10 @@ $(MicrosoftNETCoreAppPackageVersion) $(MicrosoftNETCoreAppPackageVersion) + $(MicrosoftNETCoreAppPackageVersion) $(MicrosoftAspNetCoreAppPackageVersion) 3.0.0-preview4-27421-4 + $(MicrosoftAspNetCoreAppPackageVersion) $(MicrosoftWindowsDesktopAppPackageVersion) $(MicrosoftWindowsDesktopPackageVersion) $(MicrosoftWindowsDesktopPackageVersion) diff --git a/src/core-sdk-tasks/GenerateGuidFromName.cs b/src/core-sdk-tasks/GenerateGuidFromName.cs index 05b6198d9..3ae08347b 100644 --- a/src/core-sdk-tasks/GenerateGuidFromName.cs +++ b/src/core-sdk-tasks/GenerateGuidFromName.cs @@ -23,6 +23,7 @@ namespace Microsoft.DotNet.Cli.Build return true; } + // Generate a Version 5 (SHA1 Name Based) Guid from a name. public static Guid GenerateGuid(string name) { // Any fixed GUID will do for a namespace. diff --git a/src/redist/targets/Crossgen.targets b/src/redist/targets/Crossgen.targets index 8e038c640..8d3091307 100644 --- a/src/redist/targets/Crossgen.targets +++ b/src/redist/targets/Crossgen.targets @@ -60,6 +60,9 @@ + + + diff --git a/src/redist/targets/GenerateBundledVersions.targets b/src/redist/targets/GenerateBundledVersions.targets index bc20fce8d..bced20582 100644 --- a/src/redist/targets/GenerateBundledVersions.targets +++ b/src/redist/targets/GenerateBundledVersions.targets @@ -161,6 +161,8 @@ Copyright (c) .NET Foundation. All rights reserved. --> + %24([MSBuild]::NormalizePath('%24(MSBuildThisFileDirectory)..\..\packs')) + $(_NETCoreAppTargetFrameworkVersion) $(_NETCoreAppTargetFrameworkVersion) $(_NETCoreAppPackageVersion) @@ -199,8 +201,8 @@ Copyright (c) .NET Foundation. All rights reserved. RuntimeFrameworkName="Microsoft.NETCore.App" DefaultRuntimeFrameworkVersion="$(_NETCoreAppPackageVersion)" LatestRuntimeFrameworkVersion="$(_NETCoreAppPackageVersion)" - TargetingPackName="Microsoft.NETCore.App" - TargetingPackVersion="$(_NETCoreAppPackageVersion)" + TargetingPackName="Microsoft.NETCore.App.Ref" + TargetingPackVersion="$(NetCoreAppTargetingPackVersion)" AppHostPackNamePattern="runtime.**RID**.Microsoft.NETCore.DotNetAppHost" AppHostRuntimeIdentifiers="@(NetCoreRuntimePackRids, '%3B')" RuntimePackNamePatterns="runtime.**RID**.Microsoft.NETCore.App%3Bruntime.**RID**.Microsoft.NETCore.DotNetHostResolver%3Bruntime.**RID**.Microsoft.NETCore.DotNetHostPolicy" @@ -230,8 +232,8 @@ Copyright (c) .NET Foundation. All rights reserved. RuntimeFrameworkName="Microsoft.AspNetCore.App" DefaultRuntimeFrameworkVersion="$(MicrosoftAspNetCoreAppPackageVersion)" LatestRuntimeFrameworkVersion="$(MicrosoftAspNetCoreAppPackageVersion)" - TargetingPackName="Microsoft.AspNetCore.App" - TargetingPackVersion="$(MicrosoftAspNetCoreAppPackageVersion)" + TargetingPackName="Microsoft.AspNetCore.App.Ref" + TargetingPackVersion="$(AspNetTargetingPackVersion)" RuntimePackNamePatterns="runtime.**RID**.Microsoft.AspNetCore.App" RuntimePackRuntimeIdentifiers="@(AspNetCoreRuntimePackRids, '%3B')" /> @@ -239,7 +241,7 @@ Copyright (c) .NET Foundation. All rights reserved. diff --git a/src/redist/targets/GenerateLayout.targets b/src/redist/targets/GenerateLayout.targets index 30df5a3b9..0aaab42a1 100644 --- a/src/redist/targets/GenerateLayout.targets +++ b/src/redist/targets/GenerateLayout.targets @@ -19,23 +19,16 @@ dotnet-runtime-deps-$(SharedHostVersion)-$(CoreSetupRid)$(InstallerExtension) - $(CoreSetupRid) x64 dotnet-host$(InstallerStartSuffix)-$(SharedHostVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerExtension) - - dotnet-hostfxr$(InstallerStartSuffix)-$(HostFxrVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerExtension) - - dotnet-runtime$(InstallerStartSuffix)-$(MicrosoftNETCoreAppPackageVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerExtension) - - dotnet-extension-$(MicrosoftWindowsDesktopPackageVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerExtension) - + dotnet-targeting-pack$(InstallerStartSuffix)-$(NetCoreAppTargetingPackVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerExtension) $(CoreSetupRid) @@ -51,17 +44,12 @@ aspnetcore-runtime-$(AspNetCoreVersion)-$(AspNetCoreSharedFxInstallerRid)$(InstallerExtension) aspnetcore-runtime-internal-$(AspNetCoreVersion)-$(AspNetCoreSharedFxInstallerRid).wixlib - - + aspnetcore-targeting-pack$(InstallerStartSuffix)-$(AspNetTargetingPackVersion)-$(AspNetCoreSharedFxInstallerRid)$(InstallerExtension) aspnetcore-runtime-internal-$(AspNetCoreVersion)-$(AspNetCoreSharedFxArchiveRid)$(ArchiveExtension) - - dotnet-extension-$(MicrosoftWindowsDesktopPackageVersion)-$(Architecture)$(ArchiveExtension) - aspnetcore_base_runtime.version - $(PackagesDirectory)/$(AspNetCoreSharedFxBaseRuntimeVersionFileName) @@ -82,6 +70,18 @@ + + Microsoft.NETCore.App.Ref + $(NetCoreAppTargetingPackVersion) + packs/%(PackageName)/%(PackageVersion) + + + + Microsoft.AspNetCore.App.Ref + $(AspNetTargetingPackVersion) + packs/%(PackageName)/%(PackageVersion) + + $(CoreSetupRootUrl)$(MicrosoftNETCoreAppPackageVersion) @@ -97,7 +97,7 @@ + Condition="'$(SkipBuildingInstallers)' != 'true' And '$(InstallerExtension)' != '' And !$(Architecture.StartsWith('arm'))"> $(CoreSetupRootUrl)$(SharedHostVersion) $(DownloadedSharedHostInstallerFileName) $(CoreSetupBlobAccessTokenParam) @@ -109,7 +109,14 @@ $(DownloadedHostFxrInstallerFileName) $(CoreSetupBlobAccessTokenParam) - + + + $(CoreSetupRootUrl)$(NetCoreAppTargetingPackVersion) + $(DownloadedNetCoreAppTargetingPackInstallerFileName) + $(CoreSetupBlobAccessTokenParam) + + $(CoreSetupBlobRootUrl)Toolset/$(MicrosoftDotnetToolsetInternalPackageVersion) dotnet-toolset-internal-$(MicrosoftDotnetToolsetInternalPackageVersion).zip @@ -126,7 +133,13 @@ - + + $(AspNetCoreSharedFxRootUrl)$(AspNetTargetingPackVersion) + $(DownloadedAspNetTargetingPackInstallerFileName) + $(CoreSetupBlobAccessTokenParam) + + $(AspNetCoreSharedFxRootUrl)$(AspNetCoreVersion) @@ -157,7 +170,7 @@ + Condition="'$(SkipBuildingInstallers)' != 'true' And '$(InstallerExtension)' != '' And !$(Architecture.StartsWith('arm'))"> $(WinFormsAndWpfSharedFxRootUrl)$(MicrosoftWindowsDesktopPackageVersion) $(DownloadedWinFormsAndWpfSharedFrameworkInstallerFileName) $(CoreSetupBlobAccessTokenParam) @@ -182,7 +195,52 @@ - + + + + + PackageToRestore=%(BundledLayoutPackage.PackageName); + PackageVersionToRestore=%(BundledLayoutPackage.PackageVersion); + TargetFramework=$(TargetFramework); + LayoutPackageDescription=%(BundledLayoutPackage.Identity) + + + + + + + + + + + $([MSBuild]::ValueOrDefault('%(BundledLayoutPackage.PackageName)', '').ToLower()) + + + + %(BundledLayoutPackage.RelativeLayoutPath) + %(BundledLayoutPackage.Identity) + + + + + + + + %(BundledLayoutPackageDownloadFiles.RecursiveDir)%(BundledLayoutPackageDownloadFiles.Filename)%(BundledLayoutPackageDownloadFiles.Extension) + + + $(RedistLayoutPath)/%(BundledLayoutPackageDownloadFiles.RelativeLayoutPath)/%(BundledLayoutPackageDownloadFiles.DestinationPath) + + + $([MSBuild]::NormalizePath(%(BundledLayoutPackageDownloadFiles.DestinationPath))) + + + + + @@ -191,9 +249,15 @@ - + + DestinationDirectory="$(RedistLayoutPath)/%(BundledLayoutComponent.RelativeLayoutPath)" /> + + + @@ -284,7 +348,7 @@ $(SdkDebianIntermediateDirectory)debianLayoutDirectory @@ -70,7 +71,7 @@ PropertyName="SdkInstallerUpgradeCode" /> - + @@ -137,6 +138,8 @@ '$(DownloadsFolder)$(DownloadedHostFxrInstallerFileName)' ^ '$(DownloadsFolder)$(DownloadedSharedHostInstallerFileName)' ^ '$(DownloadsFolder)$(DownloadedWinFormsAndWpfSharedFrameworkInstallerFileName)' ^ + '$(DownloadsFolder)$(DownloadedNetCoreAppTargetingPackInstallerFileName)' ^ + '$(DownloadsFolder)$(DownloadedAspNetTargetingPackInstallerFileName)' ^ '$(CombinedFrameworkSdkHostMSIInstallerFile)' ^ '$(WixRoot)' ^ '$(SdkBrandName)' ^ @@ -148,6 +151,7 @@ '$(Architecture)' ^ '$(MicrosoftNETCoreAppPackageVersion)' ^ '$(AspNetCoreVersion)' ^ + '$(CliProductBandVersion)' ^ -InformationAction Continue " /> diff --git a/src/redist/targets/GetRuntimeInformation.targets b/src/redist/targets/GetRuntimeInformation.targets index 183c6413d..ff9ee1781 100644 --- a/src/redist/targets/GetRuntimeInformation.targets +++ b/src/redist/targets/GetRuntimeInformation.targets @@ -47,8 +47,11 @@ $(ArtifactNameSdk)-$(SdkVersion)-$(ProductMonikerRid) dotnet-standard-support-vs2015-$(SdkVersion)-$(ProductMonikerRid) $(ArtifactNameCombinedHostHostFxrFrameworkSdk)-$(SdkVersion)-$(ProductMonikerRid) + + Dotnet SDK Bundle Installer $(CliProductBandVersion) $(ProductMonikerRid) $(ArtifactNameCombinedHostHostFxrFrameworkSdk)-$(SdkVersion)- $(DistroSpecificArtifactNameWithVersionCombinedHostHostFxrFrameworkSdkWithoutHostMonikerRid)$(HostMonikerRidForFileName) - + diff --git a/src/redist/targets/Versions.targets b/src/redist/targets/Versions.targets index 7976e0411..f59d228ea 100644 --- a/src/redist/targets/Versions.targets +++ b/src/redist/targets/Versions.targets @@ -2,7 +2,8 @@ 3 0 - 100 + 1 + 00 preview4 @@ -27,7 +28,8 @@ $(VersionMajor).$(VersionMinor) - $(VersionMajor).$(VersionMinor).$(VersionPatch) + $(MajorMinorVersion).$(VersionSDKMinor) + $(CliProductBandVersion)$(VersionPatch) $(CliVersionNoSuffix)-$(ReleaseSuffix) $(CliVersionNoSuffix) - $(ReleaseSuffix) $(CliVersionNoSuffix) diff --git a/src/redist/targets/packaging/windows/clisdk/bundle.wxs b/src/redist/targets/packaging/windows/clisdk/bundle.wxs index 8ce12580b..3944adbab 100644 --- a/src/redist/targets/packaging/windows/clisdk/bundle.wxs +++ b/src/redist/targets/packaging/windows/clisdk/bundle.wxs @@ -10,10 +10,27 @@ AboutUrl="https://dotnet.github.io/" Compressed="yes"> - + WixBundleInstalled OR ((NOT (DOTNETHOME_X64 ~= DOTNETHOME_X86)) OR DOTNETHOMESIMILARITYCHECKOVERRIDE) - + + + + + + + + + + + + + + + + + +