code review feedback and clean-up

This commit is contained in:
Andrew Stanton-Nurse 2015-10-07 14:39:36 -07:00
parent 78858b0edb
commit 6395ffbff5
9 changed files with 73 additions and 63 deletions

View file

@ -1,7 +1,6 @@
using System;
using System.IO;
using System.Linq;
using System.Reflection;
using Microsoft.Dnx.Runtime.Common.CommandLine;
using Microsoft.DotNet.Cli.Utils;
@ -110,10 +109,10 @@ namespace Microsoft.DotNet.Tools.Compiler
// Build csc args
var cscArgs = new[]
{
"/nostdlib",
$"/out:{Path.Combine(outputPath, projectDir.Name + ".dll")}"
"-nostdlib",
$"-out:{Path.Combine(outputPath, projectDir.Name + ".dll")}"
}
.Concat(references.Select(r => $"/r:{r}"))
.Concat(references.Select(r => $"-r:{r}"))
.Concat(sources);
var rsp = Path.Combine(outputPath, "csc.rsp");
if(File.Exists(rsp))

View file

@ -4,15 +4,16 @@ using System.Linq;
using Microsoft.Dnx.Runtime.Common.CommandLine;
using NuGet.Frameworks;
namespace DotNet.Tools.DependencyResolver
namespace Microsoft.DotNet.Tools.DependencyResolver
{
public class Program
{
public void Main(string[] args)
{
var app = new CommandLineApplication();
app.HelpOption("-h|--help");
app.Name = "dotnet resolve-references";
app.Description = "Resolves the absolute path of all dependencies for a project";
app.HelpOption("-h|--help");
var packages = app.Option("-p|--packages <PACKAGES_DIRECTORY>", "Path to the directories containing packages to resolve.", CommandOptionType.MultipleValue);
var framework = app.Option("-f|--framework <FRAMEWORK_NAME>", "The framework to resolve dependencies for.", CommandOptionType.SingleValue);

View file

@ -1,10 +1,9 @@
using System;
using System.Collections.Generic;
using System.IO;
using System.Threading.Tasks;
using Newtonsoft.Json.Linq;
namespace DotNet.Tools.DependencyResolver
namespace Microsoft.DotNet.Tools.DependencyResolver
{
public static class Resolver
{

View file

@ -1,11 +1,9 @@
using System;
using System.IO;
using System.Linq;
using System.Reflection;
using Microsoft.Dnx.Runtime.Common.CommandLine;
using Microsoft.DotNet.Cli.Utils;
namespace Microsoft.DotNet.Tools.Compiler
namespace Microsoft.DotNet.Tools.Publish
{
public class Program
{

View file

@ -1,12 +1,10 @@
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Reflection;
using Microsoft.Dnx.Runtime.Common.CommandLine;
using Microsoft.DotNet.Cli.Utils;
namespace Microsoft.DotNet.Tools.Compiler
namespace Microsoft.DotNet.Tools.Run
{
public class Program
{

View file

@ -2,15 +2,16 @@
using System.IO;
using Microsoft.Dnx.Runtime.Common.CommandLine;
namespace DotNet.Tools.DependencyResolver
namespace Microsoft.DotNet.Tools.SourceResolver
{
public class Program
{
public void Main(string[] args)
{
var app = new CommandLineApplication();
app.HelpOption("-h|--help");
app.Name = "dotnet resolve-sources";
app.Description = "Resolves the absolute path of all source files used by a project";
app.HelpOption("-h|--help");
var output = app.Option("-o|--output <OUTPUT_FILE>", "The path in which to write the output file (formatted as text with one line per dependency)", CommandOptionType.SingleValue);
var project = app.Argument("PROJECT", "The project to resolve. A directory or a path to a project.json may be used. Defaults to the current directory");

View file

@ -1,11 +1,9 @@
using System;
using System.Collections.Generic;
using System.IO;
using System.Threading.Tasks;
using Microsoft.Dnx.Runtime;
using Newtonsoft.Json.Linq;
namespace DotNet.Tools.DependencyResolver
namespace Microsoft.DotNet.Tools.SourceResolver
{
public static class Resolver
{