From 5c6bf47e10cb4b9af7d53bea0985e48bf8025f31 Mon Sep 17 00:00:00 2001 From: Eric Erhardt Date: Wed, 27 Apr 2016 17:23:28 -0500 Subject: [PATCH] Address PR feedback. --- .../.noautobuild | 0 .../Helper.cs | 0 .../project.json | 2 +- .../GivenDotnetBuildBuildsProjects.cs | 18 ++++++++++++++---- 4 files changed, 15 insertions(+), 5 deletions(-) rename TestAssets/TestProjects/{TestLibrary With Spaces => TestLibraryWithXmlDoc}/.noautobuild (100%) rename TestAssets/TestProjects/{TestLibrary With Spaces => TestLibraryWithXmlDoc}/Helper.cs (100%) rename TestAssets/TestProjects/{TestLibrary With Spaces => TestLibraryWithXmlDoc}/project.json (87%) diff --git a/TestAssets/TestProjects/TestLibrary With Spaces/.noautobuild b/TestAssets/TestProjects/TestLibraryWithXmlDoc/.noautobuild similarity index 100% rename from TestAssets/TestProjects/TestLibrary With Spaces/.noautobuild rename to TestAssets/TestProjects/TestLibraryWithXmlDoc/.noautobuild diff --git a/TestAssets/TestProjects/TestLibrary With Spaces/Helper.cs b/TestAssets/TestProjects/TestLibraryWithXmlDoc/Helper.cs similarity index 100% rename from TestAssets/TestProjects/TestLibrary With Spaces/Helper.cs rename to TestAssets/TestProjects/TestLibraryWithXmlDoc/Helper.cs diff --git a/TestAssets/TestProjects/TestLibrary With Spaces/project.json b/TestAssets/TestProjects/TestLibraryWithXmlDoc/project.json similarity index 87% rename from TestAssets/TestProjects/TestLibrary With Spaces/project.json rename to TestAssets/TestProjects/TestLibraryWithXmlDoc/project.json index d3022b01b..e05c28140 100644 --- a/TestAssets/TestProjects/TestLibrary With Spaces/project.json +++ b/TestAssets/TestProjects/TestLibraryWithXmlDoc/project.json @@ -7,6 +7,6 @@ "NETStandard.Library": "1.5.0-rc2-24027" }, "frameworks": { - "netstandard1.3": {} + "netstandard1.5": {} } } diff --git a/test/dotnet-build.Tests/GivenDotnetBuildBuildsProjects.cs b/test/dotnet-build.Tests/GivenDotnetBuildBuildsProjects.cs index 6c9802f05..9f1e5db60 100644 --- a/test/dotnet-build.Tests/GivenDotnetBuildBuildsProjects.cs +++ b/test/dotnet-build.Tests/GivenDotnetBuildBuildsProjects.cs @@ -22,7 +22,7 @@ namespace Microsoft.DotNet.Tools.Builder.Tests var buildCommand = new BuildCommand(""); buildCommand.WorkingDirectory = testProjectDirectory; - + buildCommand.ExecuteWithCapturedOutput() .Should() .Pass(); @@ -44,17 +44,27 @@ namespace Microsoft.DotNet.Tools.Builder.Tests } [Fact] - public void It_builds_projects_with_spaces_in_the_path() + public void It_builds_projects_with_xmlDoc_and_spaces_in_the_path() { var testInstance = TestAssetsManager - .CreateTestInstance("TestLibrary With Spaces") + .CreateTestInstance("TestLibraryWithXmlDoc", identifier: "With Space") .WithLockFiles(); - new BuildCommand("") + testInstance.TestRoot.Should().Contain(" "); + + var output = new DirectoryInfo(Path.Combine(testInstance.TestRoot, "output")); + + new BuildCommand("", output: output.FullName, framework: DefaultLibraryFramework) .WithWorkingDirectory(testInstance.TestRoot) .ExecuteWithCapturedOutput() .Should() .Pass(); + + output.Should().HaveFiles(new[] + { + "TestLibraryWithXmlDoc.dll", + "TestLibraryWithXmlDoc.xml" + }); } } }