mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Update implicit versions

Browse source 
Disable and fix tests do not work with non-existent
LastRuntimeFrameworkVersion
This commit is contained in:
William Li 2020-12-10 13:51:19 -08:00 • committed by Sarah Oslund
parent 7f2f577a62
commit 56797e67ed
2 changed files with 44 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

20
test/EndToEnd/GivenWeWantToRequireWindowsForDesktopApps.cs
View file

@ -3,6 +3,7 @@
using System;
using System.IO;
using System.Xml.Linq;
using EndToEnd;
using FluentAssertions;
using Microsoft.DotNet.Tools.Test.Utilities;
@ -48,7 +49,24 @@ namespace Microsoft.DotNet.Tests.EndToEnd
testProjectCreator.AdditionalProperties["OutputType"] = "exe";
testProjectCreator.AdditionalProperties["RuntimeIdentifier"] = Rid;
var testInstance = testProjectCreator.Create();
// At certain point of the release cycle LatestRuntimeFrameworkVersion in eng folder may not exist on the nuget feed
static void overrideLastRuntimeFrameworkVersionToExistingOlderVersion(XDocument project)
{
XNamespace ns = project.Root.Name.Namespace;
var target = XElement.Parse(@" <ItemGroup>
<KnownFrameworkReference Update=""@(KnownFrameworkReference)"">
<LatestRuntimeFrameworkVersion Condition=""'%(TargetFramework)' == 'netcoreapp3.1'"">3.1.10</LatestRuntimeFrameworkVersion>
</KnownFrameworkReference>
<KnownAppHostPack Update=""@(KnownAppHostPack)"">
<AppHostPackVersion Condition=""'%(TargetFramework)' == 'netcoreapp3.1'"">3.1.10</AppHostPackVersion>
</KnownAppHostPack>
</ItemGroup>");
target.Name = ns + target.Name.LocalName;
project.Root.Add(target);
}
TestFramework.TestAssetInstance testInstance
= testProjectCreator.Create().WithProjectChanges(overrideLastRuntimeFrameworkVersionToExistingOlderVersion);
new PublishCommand()
.WithWorkingDirectory(testInstance.Root.FullName)